From mboxrd@z Thu Jan 1 00:00:00 1970 From: torvalds@linux-foundation.org (Linus Torvalds) Date: Mon, 29 Apr 2019 13:07:33 -0700 Subject: [PATCH 3/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation In-Reply-To: References: <20190427100639.15074-1-nstange@suse.de> <20190427100639.15074-4-nstange@suse.de> <20190427102657.GF2623@hirez.programming.kicks-ass.net> <20190428133826.3e142cfd@oasis.local.home> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190429200733.sZZhCSqZNyvm2mM3ERGC3y6ue3RoIF3mLlx5RfIUifA@z> On Mon, Apr 29, 2019@12:24 PM Andy Lutomirski wrote: > > Side note: we *already* depend on sti shadow working in other parts of the kernel, namely sti->iret. > > Where? STI; IRET would be nuts. Sorry, not 'sti;iret' but 'sti;sysexit' > before commit 4214a16b02971c60960afd675d03544e109e0d75 > x86/asm/entry/64/compat: Use SYSRETL to return from compat mode SYSENTER > > we did sti; sysxit, but, when we discussed this, I don't recall anyone > speaking up in favor of the safely of the old code. We still have that sti sysexit in the 32-bit code. Linus