All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	<netdev@vger.kernel.org>
Subject: [PATCH 07/12] vti4: removed duplicate log message.
Date: Tue, 30 Apr 2019 07:30:25 +0200	[thread overview]
Message-ID: <20190430053030.27009-8-steffen.klassert@secunet.com> (raw)
In-Reply-To: <20190430053030.27009-1-steffen.klassert@secunet.com>

From: Jeremy Sowden <jeremy@azazel.net>

Removed info log-message if ipip tunnel registration fails during
module-initialization: it adds nothing to the error message that is
written on all failures.

Fixes: dd9ee3444014e ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel")
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
 net/ipv4/ip_vti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c
index b6235ca09fa5..35d8346742e2 100644
--- a/net/ipv4/ip_vti.c
+++ b/net/ipv4/ip_vti.c
@@ -646,10 +646,8 @@ static int __init vti_init(void)
 
 	msg = "ipip tunnel";
 	err = xfrm4_tunnel_register(&ipip_handler, AF_INET);
-	if (err < 0) {
-		pr_info("%s: cant't register tunnel\n",__func__);
+	if (err < 0)
 		goto xfrm_tunnel_failed;
-	}
 
 	msg = "netlink interface";
 	err = rtnl_link_register(&vti_link_ops);
-- 
2.17.1


  parent reply	other threads:[~2019-04-30  5:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30  5:30 pull request (net): ipsec 2019-04-30 Steffen Klassert
2019-04-30  5:30 ` [PATCH 01/12] xfrm: policy: Fix out-of-bound array accesses in __xfrm_policy_unlink Steffen Klassert
2019-04-30  5:30 ` [PATCH 02/12] xfrm: Reset secpath in xfrm failure Steffen Klassert
2019-04-30  5:30 ` [PATCH 03/12] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm Steffen Klassert
2019-04-30  5:30 ` [PATCH 04/12] xfrm6_tunnel: Fix potential panic when unloading xfrm6_tunnel module Steffen Klassert
2019-04-30  5:30 ` [PATCH 05/12] Revert "net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm" Steffen Klassert
2019-04-30  5:30 ` [PATCH 06/12] vti4: ipip tunnel deregistration fixes Steffen Klassert
2019-04-30  5:30 ` Steffen Klassert [this message]
2019-04-30  5:30 ` [PATCH 08/12] xfrm: clean up xfrm protocol checks Steffen Klassert
2019-04-30  5:30 ` [PATCH 09/12] esp4: add length check for UDP encapsulation Steffen Klassert
2019-04-30  5:30 ` [PATCH 10/12] xfrm: Honor original L3 slave device in xfrmi policy lookup Steffen Klassert
2019-04-30  5:30 ` [PATCH 11/12] xfrm4: Fix uninitialized memory read in _decode_session4 Steffen Klassert
2019-04-30  5:30 ` [PATCH 12/12] xfrm: update doc about xfrm[46]_gc_thresh Steffen Klassert
2019-04-30 13:18 ` pull request (net): ipsec 2019-04-30 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430053030.27009-8-steffen.klassert@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.