All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@kernel.org>,
	Eric W Biederman <ebiederm@xmission.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@kernel.org>,
	Ying Huang <ying.huang@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] latencytop lock usage improvement
Date: Tue, 30 Apr 2019 16:35:05 +0800	[thread overview]
Message-ID: <20190430083505.n5mozwybbnwydo3z@shbuild888> (raw)
In-Reply-To: <20190430080910.GI2623@hirez.programming.kicks-ass.net>

Hi Peter,

On Tue, Apr 30, 2019 at 10:09:10AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 29, 2019 at 04:03:28PM +0800, Feng Tang wrote:
> > Hi All,
> > 
> > latencytop is a very nice tool for tracing system latency hotspots, and
> > we heavily use it in our LKP test suites.
> 
> What data does latency-top give that perf cannot give you? Ideally we'd
> remove latencytop entirely.

Thanks for the review. In 0day/LKP test service, we have many tools for
monitoring and analyzing the test results, perf is the most important
one, which has the most parts in our auto-generated comparing results.   
For example to identify spinlock contentions and system hotspots.

latencytop is another tool we used to find why systems go idle, like why
workload chose to sleep or waiting for something. 

Thanks,
Feng

  reply	other threads:[~2019-04-30  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  8:03 [RFC PATCH 0/3] latencytop lock usage improvement Feng Tang
2019-04-29  8:03 ` [RFC PATCH 1/3] kernel/sysctl: add description for "latencytop" Feng Tang
2019-04-29  8:03 ` [RFC PATCH 2/3] latencytop: split latency_lock to global lock and per task lock Feng Tang
2019-04-29  8:03 ` [RFC PATCH 3/3] latencytop: add a lazy mode for updating global latency data Feng Tang
2019-04-30  8:09 ` [RFC PATCH 0/3] latencytop lock usage improvement Peter Zijlstra
2019-04-30  8:35   ` Feng Tang [this message]
2019-04-30  9:10     ` Peter Zijlstra
2019-04-30  9:22       ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430083505.n5mozwybbnwydo3z@shbuild888 \
    --to=feng.tang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=dvyukov@google.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.