From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B248EC43219 for ; Tue, 30 Apr 2019 12:06:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 810A921734 for ; Tue, 30 Apr 2019 12:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556625981; bh=XNbZaC2bkVzYwueJFav1qBoTyWkP1EoYo+A+OBXkHqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=T9rr0E+g8afLRdWxRTkw3qVY1mxZJPb2LClWYhiTKZM4U3zEF4gpUSsr5RnI39Me7 rYxTMonCyTEBZmESzmwT7CK1fLdJKksU6hUrRX4BlO9TdaYjJELoL/t9DTX/o1d+uZ KpKPSjRiD2LwT8sWpe7+DIFhRCpal3j0IawVCA3Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbfD3MGO (ORCPT ); Tue, 30 Apr 2019 08:06:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:49114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728049AbfD3Ll1 (ORCPT ); Tue, 30 Apr 2019 07:41:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D9EB21743; Tue, 30 Apr 2019 11:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624486; bh=XNbZaC2bkVzYwueJFav1qBoTyWkP1EoYo+A+OBXkHqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fe4aaC6ggJi5mxM43q/36xM/QHSzeyNpWYIjHNxDcfDiFAQqAVoFjGuH2BtaxNOSb G2wwKJKoFbdrU7cdhEN1/YTrF1LmSicX3MZzA8Bvp+p9sesMj6I/DIqo1XLxdBjGs+ u9fskAtockTtJ7kmR7us8CpK+cHfNMWUMSDbPJBg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Layton , "Yan, Zheng" , Ilya Dryomov Subject: [PATCH 4.14 12/53] ceph: ensure d_name stability in ceph_dentry_hash() Date: Tue, 30 Apr 2019 13:38:19 +0200 Message-Id: <20190430113552.650887870@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113549.400132183@linuxfoundation.org> References: <20190430113549.400132183@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton commit 76a495d666e5043ffc315695f8241f5e94a98849 upstream. Take the d_lock here to ensure that d_name doesn't change. Cc: stable@vger.kernel.org Signed-off-by: Jeff Layton Reviewed-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/dir.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -1454,6 +1454,7 @@ void ceph_dentry_lru_del(struct dentry * unsigned ceph_dentry_hash(struct inode *dir, struct dentry *dn) { struct ceph_inode_info *dci = ceph_inode(dir); + unsigned hash; switch (dci->i_dir_layout.dl_dir_hash) { case 0: /* for backward compat */ @@ -1461,8 +1462,11 @@ unsigned ceph_dentry_hash(struct inode * return dn->d_name.hash; default: - return ceph_str_hash(dci->i_dir_layout.dl_dir_hash, + spin_lock(&dn->d_lock); + hash = ceph_str_hash(dci->i_dir_layout.dl_dir_hash, dn->d_name.name, dn->d_name.len); + spin_unlock(&dn->d_lock); + return hash; } }