From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 15/19] drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}() Date: Tue, 30 Apr 2019 16:41:15 +0200 Message-ID: <20190430144115.GY3271@phenom.ffwll.local> References: <20190429144341.12615-1-tzimmermann@suse.de> <20190429144341.12615-16-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0691891A1 for ; Tue, 30 Apr 2019 14:41:21 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id l25so12511902eda.9 for ; Tue, 30 Apr 2019 07:41:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190429144341.12615-16-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: airlied@linux.ie, puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, z.liuxinliang@hisilicon.com, hdegoede@redhat.com, kong.kongxinwei@hisilicon.com, ray.huang@amd.com, kraxel@redhat.com, zourongrong@gmail.com, Jerry.Zhang@amd.com, christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMjksIDIwMTkgYXQgMDQ6NDM6MzdQTSArMDIwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gVGhlIG1nYWcyMDAgZHJpdmVyIGVzdGFibGlzaGVzIHNldmVyYWwgbWVtb3J5 IG1hcHBpbmdzIGZvciBmcmFtZSBidWZmZXJzCj4gYW5kIGN1cnNvcnMuIFRoaXMgcGF0Y2ggY29u dmVydHMgdGhlIGRyaXZlciB0byB1c2UgdGhlIGVxdWl2YWxlbnQKPiBkcm1fZ2VtX3ZyYW1fa21h cCgpIGZ1bmN0aW9ucy4gSXQgcmVtb3ZlcyB0aGUgZGVwZW5kZW5jaWVzIG9uIFRUTQo+IGFuZCBj bGVhbnMgdXAgdGhlIGNvZGUuCgpzLW8tYiBtaXNzaW5nIGhlcmUuCi1EYW5pZWwKCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfY3Vyc29yLmMgfCAzNSArKysrKysrKysr Ky0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9kcnYuaCAg ICB8ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9mYi5jICAgICB8IDIy ICsrKysrKysrKy0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX21vZGUu YyAgIHwgIDkgKysrKy0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMzEg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21n YWcyMDBfY3Vyc29yLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2N1cnNvci5j Cj4gaW5kZXggY2NhMzkyMmY5ZjY3Li42YzFhOWQ3MjRkODUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9jdXJzb3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZ2FnMjAwL21nYWcyMDBfY3Vyc29yLmMKPiBAQCAtNDMsNiArNDMsNyBAQCBpbnQgbWdhX2Ny dGNfY3Vyc29yX3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAlzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iajsKPiAgCXN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8gPSBOVUxMOwo+ ICAJaW50IHJldCA9IDA7Cj4gKwl1OCAqc3JjLCAqZHN0Owo+ICAJdW5zaWduZWQgaW50IGksIHJv dywgY29sOwo+ICAJdWludDMyX3QgY29sb3VyX3NldFsxNl07Cj4gIAl1aW50MzJfdCAqbmV4dF9z cGFjZSA9ICZjb2xvdXJfc2V0WzBdOwo+IEBAIC0xMjYsMTggKzEyNywxNyBAQCBpbnQgbWdhX2Ny dGNfY3Vyc29yX3NldChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJZGV2X2VycigmZGV2LT5w ZGV2LT5kZXYsICJmYWlsZWQgdG8gcmVzZXJ2ZSB1c2VyIGJvXG4iKTsKPiAgCQlnb3RvIG91dDE7 Cj4gIAl9Cj4gLQlpZiAoIWdiby0+a21hcC52aXJ0dWFsKSB7Cj4gLQkJcmV0ID0gdHRtX2JvX2tt YXAoJmdiby0+Ym8sIDAsIGdiby0+Ym8ubnVtX3BhZ2VzLCAmZ2JvLT5rbWFwKTsKPiAtCQlpZiAo cmV0KSB7Cj4gLQkJCWRldl9lcnIoJmRldi0+cGRldi0+ZGV2LCAiZmFpbGVkIHRvIGttYXAgdXNl ciBidWZmZXIgdXBkYXRlc1xuIik7Cj4gLQkJCWdvdG8gb3V0MjsKPiAtCQl9Cj4gKwlzcmMgPSBk cm1fZ2VtX3ZyYW1fa21hcChnYm8sIHRydWUsIE5VTEwpOwo+ICsJaWYgKElTX0VSUihzcmMpKSB7 Cj4gKwkJcmV0ID0gUFRSX0VSUihzcmMpOwo+ICsJCWRldl9lcnIoJmRldi0+cGRldi0+ZGV2LCAi ZmFpbGVkIHRvIGttYXAgdXNlciBidWZmZXIgdXBkYXRlc1xuIik7Cj4gKwkJZ290byBvdXQyOwo+ ICAJfQo+ICAKPiAgCW1lbXNldCgmY29sb3VyX3NldFswXSwgMCwgc2l6ZW9mKHVpbnQzMl90KSox Nik7Cj4gIAkvKiB3aWR0aCpoZWlnaHQqNCA9IDE2Mzg0ICovCj4gIAlmb3IgKGkgPSAwOyBpIDwg MTYzODQ7IGkgKz0gNCkgewo+IC0JCXRoaXNfY29sb3VyID0gaW9yZWFkMzIoZ2JvLT5rbWFwLnZp cnR1YWwgKyBpKTsKPiArCQl0aGlzX2NvbG91ciA9IGlvcmVhZDMyKHNyYyArIGkpOwo+ICAJCS8q IE5vIHRyYW5zcGFyZW5jeSAqLwo+ICAJCWlmICh0aGlzX2NvbG91cj4+MjQgIT0gMHhmZiAmJgo+ ICAJCQl0aGlzX2NvbG91cj4+MjQgIT0gMHgwKSB7Cj4gQEAgLTE4OSwyMSArMTg5LDE4IEBAIGlu dCBtZ2FfY3J0Y19jdXJzb3Jfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCX0KPiAgCj4g IAkvKiBNYXAgdXAtY29taW5nIGJ1ZmZlciB0byB3cml0ZSBjb2xvdXIgaW5kaWNlcyAqLwo+IC0J aWYgKCFwaXhlbHNfcHJldi0+a21hcC52aXJ0dWFsKSB7Cj4gLQkJcmV0ID0gdHRtX2JvX2ttYXAo JnBpeGVsc19wcmV2LT5ibywgMCwKPiAtCQkJCSAgcGl4ZWxzX3ByZXYtPmJvLm51bV9wYWdlcywK PiAtCQkJCSAgJnBpeGVsc19wcmV2LT5rbWFwKTsKPiAtCQlpZiAocmV0KSB7Cj4gLQkJCWRldl9l cnIoJmRldi0+cGRldi0+ZGV2LCAiZmFpbGVkIHRvIGttYXAgY3Vyc29yIHVwZGF0ZXNcbiIpOwo+ IC0JCQlnb3RvIG91dDM7Cj4gLQkJfQo+ICsJZHN0ID0gZHJtX2dlbV92cmFtX2ttYXAocGl4ZWxz X3ByZXYsIHRydWUsIE5VTEwpOwo+ICsJaWYgKElTX0VSUihkc3QpKSB7Cj4gKwkJcmV0ID0gUFRS X0VSUihkc3QpOwo+ICsJCWRldl9lcnIoJmRldi0+cGRldi0+ZGV2LCAiZmFpbGVkIHRvIGttYXAg Y3Vyc29yIHVwZGF0ZXNcbiIpOwo+ICsJCWdvdG8gb3V0MzsKPiAgCX0KPiAgCj4gIAkvKiBub3cg d3JpdGUgY29sb3VyIGluZGljZXMgaW50byBoYXJkd2FyZSBjdXJzb3IgYnVmZmVyICovCj4gIAlm b3IgKHJvdyA9IDA7IHJvdyA8IDY0OyByb3crKykgewo+ICAJCW1lbXNldCgmdGhpc19yb3dbMF0s IDAsIDQ4KTsKPiAgCQlmb3IgKGNvbCA9IDA7IGNvbCA8IDY0OyBjb2wrKykgewo+IC0JCQl0aGlz X2NvbG91ciA9IGlvcmVhZDMyKGdiby0+a21hcC52aXJ0dWFsICsgNCooY29sICsgNjQqcm93KSk7 Cj4gKwkJCXRoaXNfY29sb3VyID0gaW9yZWFkMzIoc3JjICsgNCooY29sICsgNjQqcm93KSk7Cj4g IAkJCS8qIHdyaXRlIHRyYW5zcGFyZW50IHBpeGVscyAqLwo+ICAJCQlpZiAodGhpc19jb2xvdXI+ PjI0ID09IDB4MCkgewo+ICAJCQkJdGhpc19yb3dbNDcgLSBjb2wvOF0gfD0gMHg4MD4+KGNvbCU4 KTsKPiBAQCAtMjIxLDcgKzIxOCw3IEBAIGludCBtZ2FfY3J0Y19jdXJzb3Jfc2V0KHN0cnVjdCBk cm1fY3J0YyAqY3J0YywKPiAgCQkJCX0KPiAgCQkJfQo+ICAJCX0KPiAtCQltZW1jcHlfdG9pbyhw aXhlbHNfcHJldi0+a21hcC52aXJ0dWFsICsgcm93KjQ4LCAmdGhpc19yb3dbMF0sIDQ4KTsKPiAr CQltZW1jcHlfdG9pbyhkc3QgKyByb3cqNDgsICZ0aGlzX3Jvd1swXSwgNDgpOwo+ICAJfQo+ICAK PiAgCS8qIFByb2dyYW0gZ3B1IGFkZHJlc3Mgb2YgY3Vyc29yIGJ1ZmZlciAqLwo+IEBAIC0yNDcs OSArMjQ0LDkgQEAgaW50IG1nYV9jcnRjX2N1cnNvcl9zZXQoc3RydWN0IGRybV9jcnRjICpjcnRj LAo+ICAJfQo+ICAJcmV0ID0gMDsKPiAgCj4gLQl0dG1fYm9fa3VubWFwKCZwaXhlbHNfcHJldi0+ a21hcCk7Cj4gKwlkcm1fZ2VtX3ZyYW1fa3VubWFwKHBpeGVsc19wcmV2KTsKPiAgIG91dDM6Cj4g LQl0dG1fYm9fa3VubWFwKCZnYm8tPmttYXApOwo+ICsJZHJtX2dlbV92cmFtX2t1bm1hcChnYm8p Owo+ICAgb3V0MjoKPiAgCWRybV9nZW1fdnJhbV91bnJlc2VydmUoZ2JvKTsKPiAgIG91dDE6Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2Rydi5oCj4gaW5kZXggMTZjZTZiMzM4ZGNlLi42 MTgwYWNiY2E3Y2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIw MF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBfZHJ2LmgKPiBA QCAtMTE1LDcgKzExNSw2IEBAIHN0cnVjdCBtZ2FfZmJkZXYgewo+ICAJc3RydWN0IG1nYV9mcmFt ZWJ1ZmZlciBtZmI7Cj4gIAl2b2lkICpzeXNyYW07Cj4gIAlpbnQgc2l6ZTsKPiAtCXN0cnVjdCB0 dG1fYm9fa21hcF9vYmogbWFwcGluZzsKPiAgCWludCB4MSwgeTEsIHgyLCB5MjsgLyogZGlydHkg cmVjdCAqLwo+ICAJc3BpbmxvY2tfdCBkaXJ0eV9sb2NrOwo+ICB9Owo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2ZiLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWdh ZzIwMC9tZ2FnMjAwX2ZiLmMKPiBpbmRleCA1MDhlYzJkZGRiYmEuLjdjNDU3ZGFkNWQ5ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2ZiLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2ZiLmMKPiBAQCAtMjcsNiArMjcsNyBAQCBz dGF0aWMgdm9pZCBtZ2FfZGlydHlfdXBkYXRlKHN0cnVjdCBtZ2FfZmJkZXYgKm1mYmRldiwKPiAg CWludCBzcmNfb2Zmc2V0LCBkc3Rfb2Zmc2V0Owo+ICAJaW50IGJwcCA9IG1mYmRldi0+bWZiLmJh c2UuZm9ybWF0LT5jcHBbMF07Cj4gIAlpbnQgcmV0ID0gLUVCVVNZOwo+ICsJdTggKmRzdDsKPiAg CWJvb2wgdW5tYXAgPSBmYWxzZTsKPiAgCWJvb2wgc3RvcmVfZm9yX2xhdGVyID0gZmFsc2U7Cj4g IAlpbnQgeDIsIHkyOwo+IEBAIC03NSwyNCArNzYsMjkgQEAgc3RhdGljIHZvaWQgbWdhX2RpcnR5 X3VwZGF0ZShzdHJ1Y3QgbWdhX2ZiZGV2ICptZmJkZXYsCj4gIAltZmJkZXYtPngyID0gbWZiZGV2 LT55MiA9IDA7Cj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZtZmJkZXYtPmRpcnR5X2xvY2ss IGZsYWdzKTsKPiAgCj4gLQlpZiAoIWdiby0+a21hcC52aXJ0dWFsKSB7Cj4gLQkJcmV0ID0gdHRt X2JvX2ttYXAoJmdiby0+Ym8sIDAsIGdiby0+Ym8ubnVtX3BhZ2VzLCAmZ2JvLT5rbWFwKTsKPiAt CQlpZiAocmV0KSB7Cj4gKwlkc3QgPSBkcm1fZ2VtX3ZyYW1fa21hcChnYm8sIGZhbHNlLCBOVUxM KTsKPiArCWlmIChJU19FUlIoZHN0KSkgewo+ICsJCURSTV9FUlJPUigiZmFpbGVkIHRvIGttYXAg ZmIgdXBkYXRlc1xuIik7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9IGVsc2UgaWYgKCFkc3QpIHsKPiAr CQlkc3QgPSBkcm1fZ2VtX3ZyYW1fa21hcChnYm8sIHRydWUsIE5VTEwpOwo+ICsJCWlmIChJU19F UlIoZHN0KSkgewo+ICAJCQlEUk1fRVJST1IoImZhaWxlZCB0byBrbWFwIGZiIHVwZGF0ZXNcbiIp Owo+IC0JCQlkcm1fZ2VtX3ZyYW1fdW5yZXNlcnZlKGdibyk7Cj4gLQkJCXJldHVybjsKPiArCQkJ Z290byBvdXQ7Cj4gIAkJfQo+ICAJCXVubWFwID0gdHJ1ZTsKPiAgCX0KPiArCj4gIAlmb3IgKGkg PSB5OyBpIDw9IHkyOyBpKyspIHsKPiAgCQkvKiBhc3N1bWUgZXF1YWwgc3RyaWRlIGZvciBub3cg Ki8KPiAgCQlzcmNfb2Zmc2V0ID0gZHN0X29mZnNldCA9IGkgKiBtZmJkZXYtPm1mYi5iYXNlLnBp dGNoZXNbMF0gKyAoeCAqIGJwcCk7Cj4gLQkJbWVtY3B5X3RvaW8oZ2JvLT5rbWFwLnZpcnR1YWwg KyBzcmNfb2Zmc2V0LCBtZmJkZXYtPnN5c3JhbSArIHNyY19vZmZzZXQsICh4MiAtIHggKyAxKSAq IGJwcCk7Cj4gLQo+ICsJCW1lbWNweV90b2lvKGRzdCArIGRzdF9vZmZzZXQsIG1mYmRldi0+c3lz cmFtICsgc3JjX29mZnNldCwgKHgyIC0geCArIDEpICogYnBwKTsKPiAgCX0KPiArCj4gIAlpZiAo dW5tYXApCj4gLQkJdHRtX2JvX2t1bm1hcCgmZ2JvLT5rbWFwKTsKPiArCQlkcm1fZ2VtX3ZyYW1f a3VubWFwKGdibyk7Cj4gIAo+ICtvdXQ6Cj4gIAlkcm1fZ2VtX3ZyYW1fdW5yZXNlcnZlKGdibyk7 Cj4gIH0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBf bW9kZS5jIGIvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9tb2RlLmMKPiBpbmRleCBk ZGVjMmM0ODUzODEuLjc2OWFjZTEzOTM3NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bWdhZzIwMC9tZ2FnMjAwX21vZGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21n YWcyMDBfbW9kZS5jCj4gQEAgLTg3MCw2ICs4NzAsNyBAQCBzdGF0aWMgaW50IG1nYV9jcnRjX2Rv X3NldF9iYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCXN0cnVjdCBkcm1fZ2VtX3ZyYW1f b2JqZWN0ICpnYm87Cj4gIAlpbnQgcmV0Owo+ICAJczY0IGdwdV9hZGRyOwo+ICsJdm9pZCogYmFz ZTsKPiAgCj4gIAkvKiBwdXNoIHRoZSBwcmV2aW91cyBmYiB0byBzeXN0ZW0gcmFtICovCj4gIAlp ZiAoIWF0b21pYyAmJiBmYikgewo+IEBAIC05MDIsMTEgKzkwMywxMyBAQCBzdGF0aWMgaW50IG1n YV9jcnRjX2RvX3NldF9iYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4gIAlpZiAoJm1k ZXYtPm1mYmRldi0+bWZiID09IG1nYV9mYikgewo+ICAJCS8qIGlmIHB1c2hpbmcgY29uc29sZSBp biBrbWFwIGl0ICovCj4gLQkJcmV0ID0gdHRtX2JvX2ttYXAoJmdiby0+Ym8sIDAsIGdiby0+Ym8u bnVtX3BhZ2VzLCAmZ2JvLT5rbWFwKTsKPiAtCQlpZiAocmV0KQo+ICsJCWJhc2UgPSBkcm1fZ2Vt X3ZyYW1fa21hcChnYm8sIHRydWUsIE5VTEwpOwo+ICsJCWlmIChJU19FUlIoYmFzZSkpIHsKPiAr CQkJcmV0ID0gUFRSX0VSUihiYXNlKTsKPiAgCQkJRFJNX0VSUk9SKCJmYWlsZWQgdG8ga21hcCBm YmNvblxuIik7Cj4gLQo+ICsJCX0KPiAgCX0KPiArCj4gIAlkcm1fZ2VtX3ZyYW1fdW5yZXNlcnZl KGdibyk7Cj4gIAo+ICAJbWdhX3NldF9zdGFydF9hZGRyZXNzKGNydGMsICh1MzIpZ3B1X2FkZHIp Owo+IC0tIAo+IDIuMjEuMAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==