All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Perr Zhang <strongbox8@zoho.com>,
	pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
	stable@vger.kernel.org, mingo@redhat.com, x86@kernel.org,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: revert the order of calls in kvm_fast_pio()
Date: Tue, 30 Apr 2019 07:57:24 -0700	[thread overview]
Message-ID: <20190430145724.GA32170@linux.intel.com> (raw)
In-Reply-To: <20190430143201.GH2589@hirez.programming.kicks-ass.net>

On Tue, Apr 30, 2019 at 04:32:01PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 30, 2019 at 10:24:23PM +0800, Perr Zhang wrote:
> > In commit 45def77ebf79, the order of function calls in kvm_fast_pio()
> > was changed. This causes that the vm(XP,and also XP's iso img) failed
> > to boot. This doesn't happen with win10 or ubuntu.
> > 
> > After revert the order, the vm(XP) succeedes to boot. In addition, the
> > change of calls's order of kvm_fast_pio() in commit 45def77ebf79 has no
> > obvious reason.

There are three reasons explicitly listed in the changelog:

    Updating %rip prior to executing to userspace has several drawbacks:
    
      - Userspace sees the wrong %rip on the exit, e.g. if PIO emulation
        fails it will likely yell about the wrong address.
      - Single step exits to userspace for are effectively dropped as
        KVM_EXIT_DEBUG is overwritten with KVM_EXIT_IO.
      - Behavior of PIO emulation is different depending on whether it
        goes down the fast path or the slow path.

> 
> This Changelog fails to explain why the order is important and equally
> fails to inform the future reader of that code. So this very same thing
> will happen again in 6 months time or thereabout.

There's a more precise fix submitted for this bug[1].  In theory v2
already went out, but I still don't see it posted to the KVM list.
Either the KVM list or my mail client is being weird.

[1] https://patchwork.kernel.org/patch/10919849/

  reply	other threads:[~2019-04-30 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 14:24 [PATCH] KVM: x86: revert the order of calls in kvm_fast_pio() Perr Zhang
2019-04-30 14:32 ` Peter Zijlstra
2019-04-30 14:57   ` Sean Christopherson [this message]
2019-04-30 15:05     ` Peter Zijlstra
2019-04-30 14:58   ` Perr Zhang
  -- strict thread matches above, loose matches on Subject: below --
2019-04-30 14:24 Perr Zhang
2019-04-30 14:20 Perr Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430145724.GA32170@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=strongbox8@zoho.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.