From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70D1C43219 for ; Wed, 1 May 2019 18:29:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C88F2081C for ; Wed, 1 May 2019 18:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726116AbfEAS3z (ORCPT ); Wed, 1 May 2019 14:29:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37416 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfEAS3z (ORCPT ); Wed, 1 May 2019 14:29:55 -0400 Received: from localhost (adsl-173-228-226-134.prtc.net [173.228.226.134]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 37D421263F1F3; Wed, 1 May 2019 11:29:53 -0700 (PDT) Date: Wed, 01 May 2019 14:29:48 -0400 (EDT) Message-Id: <20190501.142948.1053446771181544161.davem@davemloft.net> To: yuehaibing@huawei.com Cc: grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, andrew@lunn.ch, ilias.apalodimas@linaro.org, julia.lawall@lip6.fr, linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v3 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() From: David Miller In-Reply-To: <20190430015524.50997-1-yuehaibing@huawei.com> References: <20190429143157.79035-1-yuehaibing@huawei.com> <20190430015524.50997-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 May 2019 11:29:54 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: YueHaibing Date: Tue, 30 Apr 2019 01:55:24 +0000 > Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe, > The proper pointer to use is clk instead of mode. > > This issue was detected with the help of Coccinelle. > > Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") > Signed-off-by: YueHaibing > Reviewed-by: Andrew Lunn > --- > v3: Fix commit log > v2: add Fixes tag Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 01 May 2019 18:29:48 +0000 Subject: Re: [PATCH v3 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() Message-Id: <20190501.142948.1053446771181544161.davem@davemloft.net> List-Id: References: <20190429143157.79035-1-yuehaibing@huawei.com> <20190430015524.50997-1-yuehaibing@huawei.com> In-Reply-To: <20190430015524.50997-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: yuehaibing@huawei.com Cc: grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, andrew@lunn.ch, ilias.apalodimas@linaro.org, julia.lawall@lip6.fr, linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org From: YueHaibing Date: Tue, 30 Apr 2019 01:55:24 +0000 > Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe, > The proper pointer to use is clk instead of mode. > > This issue was detected with the help of Coccinelle. > > Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") > Signed-off-by: YueHaibing > Reviewed-by: Andrew Lunn > --- > v3: Fix commit log > v2: add Fixes tag Applied.