From mboxrd@z Thu Jan 1 00:00:00 1970 From: torvalds@linux-foundation.org (Linus Torvalds) Date: Tue, 30 Apr 2019 18:58:08 -0700 Subject: [RFC][PATCH v2] ftrace/x86: Emulate call function while updating in breakpoint handler In-Reply-To: <20190430213517.7bcfaf8e@oasis.local.home> References: <20190428133826.3e142cfd@oasis.local.home> <20190430135602.GD2589@hirez.programming.kicks-ass.net> <20190430130359.330e895b@gandalf.local.home> <20190430132024.0f03f5b8@gandalf.local.home> <20190430134913.4e29ce72@gandalf.local.home> <20190430175334.423821c0@gandalf.local.home> <20190430213517.7bcfaf8e@oasis.local.home> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190501015808.xRFdLTzKh4bxe6Hyp6DkX0HJCsNVXjMFcOIniTYrNIs@z> On Tue, Apr 30, 2019@6:35 PM Steven Rostedt wrote: > > > Probably easier to move it from inline asm to ftrace_X.S and use the > lockdep TRACE_ON/OFF macros. Yeah, that should clean up the percpu stuff too since we have helper macros for it for *.S files anyway. I only did the asm() in C because it made the "look, something like this" patch simpler to test (and it made it easy to check the generated asm file). Not because it was a good idea ;) Linus