From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve resuming from hibernation
Date: Wed, 1 May 2019 22:34:24 +0200 [thread overview]
Message-ID: <20190501203424.GG19809@lunn.ch> (raw)
In-Reply-To: <1b6fc016-b4cd-a27a-216b-d17441072809@gmail.com>
On Wed, May 01, 2019 at 10:14:21PM +0200, Heiner Kallweit wrote:
> I got an interesting report [0] that after resuming from hibernation
> the link has 100Mbps instead of 1Gbps. Reason is that another OS has
> been used whilst Linux was hibernated. And this OS speeds down the link
> due to WoL. Therefore, when resuming, we shouldn't expect that what
> the PHY advertises is what it did when hibernating.
> Easiest way to do this is removing state PHY_RESUMING. Instead always
> go via PHY_UP that configures PHY advertisement.
Hi Heiner
Going via PHY_UP is reasonable. I'm doing the same in my WIP cable
test code, to restore the PHY after it finishes the test.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-05-01 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 20:14 [PATCH net-next] net: phy: improve resuming from hibernation Heiner Kallweit
2019-05-01 20:34 ` Andrew Lunn [this message]
2019-05-04 4:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501203424.GG19809@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.