From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1486EC43219 for ; Thu, 2 May 2019 07:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D29D52085A for ; Thu, 2 May 2019 07:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556780870; bh=R58soqJU4/GFbmzVt6nBZnewIAmHT909NOZ409AkhRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PPguWB9CIIJfHYYqBEFd/Nc5Ymmka8+qNboabbSUoUidKBT/eeG6hjd014RzyGjzO 1h6drCsljfm9xmCAM5V483YrAYNEd1cZj7ZWf1Qln/9Fx+29s2IB4pkKDI2zO9wuCn A9hAtWVetXlH7uBfZN5C7FRYKDmzwucvSWQMTPp8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbfEBHHt (ORCPT ); Thu, 2 May 2019 03:07:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbfEBHHt (ORCPT ); Thu, 2 May 2019 03:07:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9159208C4; Thu, 2 May 2019 07:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556780868; bh=R58soqJU4/GFbmzVt6nBZnewIAmHT909NOZ409AkhRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BO285Ep1LVasDMxvVq5Od9DRgRNO6bDWc1jYgn8yTtbgsFfHfewSjEVStJsT8NoOX JE3DiwPqAY24RWeqhUvVu5iPxDvrgLOBCG2FKR+EKtD88UumZ50usRkb0kDkqcvlR3 fDbgLrJVG5TsOSfcOW6M3RP1qdznJtq2VvCZYhO4= Date: Thu, 2 May 2019 09:07:46 +0200 From: Greg Kroah-Hartman To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Nishad Kamdar , Manivannan Sadhasivam , Michael Turquette , Stephen Boyd , Joe Perches , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier Message-ID: <20190502070746.GA16247@kroah.com> References: <20190501070707.GA5619@nishad> <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas Färber wrote: > + linux-actions > > Am 01.05.19 um 09:07 schrieb Nishad Kamdar: > > This patch corrects the SPDX License Identifier style > > in header files related to Clock Drivers for Actions Semi Socs. > > For C header files Documentation/process/license-rules.rst > > mandates C-like comments (opposed to C source files where > > C++ style should be used) > [...] > > drivers/clk/actions/owl-common.h | 2 +- > > drivers/clk/actions/owl-composite.h | 2 +- > > drivers/clk/actions/owl-divider.h | 2 +- > > drivers/clk/actions/owl-factor.h | 2 +- > > drivers/clk/actions/owl-fixed-factor.h | 2 +- > > drivers/clk/actions/owl-gate.h | 2 +- > > drivers/clk/actions/owl-mux.h | 2 +- > > drivers/clk/actions/owl-pll.h | 2 +- > > drivers/clk/actions/owl-reset.h | 2 +- > > 9 files changed, 9 insertions(+), 9 deletions(-) > > Where's the practical benefit of this patch? These are all private > headers used from C files, so they can handle C++ comments just fine, > otherwise we would've seen build failures. Please read Documentation/process/license-rules.rst, the section entitled "Style", for what the documented formats are for SPDX lines, depending on the file type. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0762FC43219 for ; Thu, 2 May 2019 07:07:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C78232085A for ; Thu, 2 May 2019 07:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pn86oyak"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BO285Ep1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C78232085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kwfv9E6CCaOZNfu0d6PNSOv5dPA0bEg0GfDjrBpYVls=; b=Pn86oyakIPP8eA Qi7f/rbpGAfpjTYrsaeBM1YLQM64UEMBdqsx3phebOUyEypQxTvx8FDfVpvGSV3DgGYkejPb5P6UQ Ttfh+4XD+Uob4goSyQQSMxTZ9dVhguug0d3MEbvTPYHnGUpmeeds2ZNAAGOGPTr0Gprw9VSLrt9xE 29/s/jN6aNKIU1+7N/lXi9IXyC6qj4niuaV/Y+elR006tAVNpcfLODb7VElhln1qFisrVVywbM7Z2 DNSGHHEvqJ3USqWy96rq+SPXZTRw3IkjpPgtpviQh8VOfv+5luAucRomfxMDN8kom9L4ijvlFsWM8 D/esS0lY3cZD0QCGCc3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM5ou-0001On-Nb; Thu, 02 May 2019 07:07:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM5or-0001OH-9z; Thu, 02 May 2019 07:07:50 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9159208C4; Thu, 2 May 2019 07:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556780868; bh=R58soqJU4/GFbmzVt6nBZnewIAmHT909NOZ409AkhRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BO285Ep1LVasDMxvVq5Od9DRgRNO6bDWc1jYgn8yTtbgsFfHfewSjEVStJsT8NoOX JE3DiwPqAY24RWeqhUvVu5iPxDvrgLOBCG2FKR+EKtD88UumZ50usRkb0kDkqcvlR3 fDbgLrJVG5TsOSfcOW6M3RP1qdznJtq2VvCZYhO4= Date: Thu, 2 May 2019 09:07:46 +0200 From: Greg Kroah-Hartman To: Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier Message-ID: <20190502070746.GA16247@kroah.com> References: <20190501070707.GA5619@nishad> <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190502_000749_359654_6AC498EA X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishad Kamdar , Stephen Boyd , Michael Turquette , Manivannan Sadhasivam , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Joe Perches , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas F=E4rber wrote: > + linux-actions > = > Am 01.05.19 um 09:07 schrieb Nishad Kamdar: > > This patch corrects the SPDX License Identifier style > > in header files related to Clock Drivers for Actions Semi Socs. > > For C header files Documentation/process/license-rules.rst > > mandates C-like comments (opposed to C source files where > > C++ style should be used) > [...] > > drivers/clk/actions/owl-common.h | 2 +- > > drivers/clk/actions/owl-composite.h | 2 +- > > drivers/clk/actions/owl-divider.h | 2 +- > > drivers/clk/actions/owl-factor.h | 2 +- > > drivers/clk/actions/owl-fixed-factor.h | 2 +- > > drivers/clk/actions/owl-gate.h | 2 +- > > drivers/clk/actions/owl-mux.h | 2 +- > > drivers/clk/actions/owl-pll.h | 2 +- > > drivers/clk/actions/owl-reset.h | 2 +- > > 9 files changed, 9 insertions(+), 9 deletions(-) > = > Where's the practical benefit of this patch? These are all private > headers used from C files, so they can handle C++ comments just fine, > otherwise we would've seen build failures. Please read Documentation/process/license-rules.rst, the section entitled "Style", for what the documented formats are for SPDX lines, depending on the file type. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel