From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Thu, 2 May 2019 13:05:13 +0200 Message-ID: <20190502110513.GF12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190502105053.GA12416@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins Cc: frowand.list@gmail.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com List-Id: linux-nvdimm@lists.01.org On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally trees are already closed now for > 5.2-rc1 if 5.1-final comes out this Sunday. > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > we would merge through your tree when the time came? Am I remembering > > correctly? > > No objection from me. > > Let me go review the latest round of patches now. Overall, looks good to me, and provides a framework we can build on. I'm a bit annoyed at the reliance on uml at the moment, but we can work on that in the future :) Thanks for sticking with this, now the real work begins... Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3430EC43219 for ; Thu, 2 May 2019 11:05:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0442520873 for ; Thu, 2 May 2019 11:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556795118; bh=g52VJv58ny9inOghbRxttm2JEOFg/YzNJiIi1xgevz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gJKn5iiq4pAh9KZTHpOAsWUwHs0NOefh07k0gX6eQx/MM7vvScWr6wUvINSs4czAx AW81o9A0+LJiDOARVyUDRfU2D+KqycgFVSPqR4VH5tZS8dwpmGkjKhkWF5FVsC0B4q AIdblvlTRLlGMBNJdlyRvoza9C8Cg5hu28+RcH58= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbfEBLFR (ORCPT ); Thu, 2 May 2019 07:05:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:50982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfEBLFQ (ORCPT ); Thu, 2 May 2019 07:05:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4391720656; Thu, 2 May 2019 11:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556795115; bh=g52VJv58ny9inOghbRxttm2JEOFg/YzNJiIi1xgevz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srcuUUfJlFr42/9IsMaL5I/QT1gc7U4FMTE1sI3n6k8wik0XOQdtZ3s/SmQvEj2j3 nem5uAwCIgmlBdJqoOCKPYyD7+0J7m4Es/11yPHJKGUPXjz6aLsDABY2+K1HZTiH2j NwAGsAXg2Nr8uriB/0jqHcN2lzmFJtLPXJT3z5pc= Date: Thu, 2 May 2019 13:05:13 +0200 From: Greg KH To: Brendan Higgins Cc: frowand.list@gmail.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190502110513.GF12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502105053.GA12416@kroah.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally trees are already closed now for > 5.2-rc1 if 5.1-final comes out this Sunday. > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > we would merge through your tree when the time came? Am I remembering > > correctly? > > No objection from me. > > Let me go review the latest round of patches now. Overall, looks good to me, and provides a framework we can build on. I'm a bit annoyed at the reliance on uml at the moment, but we can work on that in the future :) Thanks for sticking with this, now the real work begins... Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh at linuxfoundation.org (Greg KH) Date: Thu, 2 May 2019 13:05:13 +0200 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <20190502105053.GA12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> Message-ID: <20190502110513.GF12416@kroah.com> On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally trees are already closed now for > 5.2-rc1 if 5.1-final comes out this Sunday. > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > we would merge through your tree when the time came? Am I remembering > > correctly? > > No objection from me. > > Let me go review the latest round of patches now. Overall, looks good to me, and provides a framework we can build on. I'm a bit annoyed at the reliance on uml at the moment, but we can work on that in the future :) Thanks for sticking with this, now the real work begins... Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Thu, 2 May 2019 13:05:13 +0200 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <20190502105053.GA12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> Message-ID: <20190502110513.GF12416@kroah.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190502110513.WIQLa9-oL_7NNnhfK-QKjQYrf0GNcMxGS1RB16dhbOk@z> On Thu, May 02, 2019@12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019@04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally trees are already closed now for > 5.2-rc1 if 5.1-final comes out this Sunday. > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > we would merge through your tree when the time came? Am I remembering > > correctly? > > No objection from me. > > Let me go review the latest round of patches now. Overall, looks good to me, and provides a framework we can build on. I'm a bit annoyed at the reliance on uml at the moment, but we can work on that in the future :) Thanks for sticking with this, now the real work begins... Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM9We-00034Z-2L for linux-um@lists.infradead.org; Thu, 02 May 2019 11:05:20 +0000 Date: Thu, 2 May 2019 13:05:13 +0200 From: Greg KH Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190502110513.GF12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190502105053.GA12416@kroah.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, shuah@kernel.org, robh@kernel.org, linux-nvdimm@lists.01.org, frowand.list@gmail.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, dan.j.williams@intel.com, kunit-dev@googlegroups.com, richard@nod.at, sboyd@kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org, logang@deltatee.com, khilman@baylibre.com On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally trees are already closed now for > 5.2-rc1 if 5.1-final comes out this Sunday. > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > we would merge through your tree when the time came? Am I remembering > > correctly? > > No objection from me. > > Let me go review the latest round of patches now. Overall, looks good to me, and provides a framework we can build on. I'm a bit annoyed at the reliance on uml at the moment, but we can work on that in the future :) Thanks for sticking with this, now the real work begins... Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um