From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA8FC43219 for ; Thu, 2 May 2019 14:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82E2920652 for ; Thu, 2 May 2019 14:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556807475; bh=y5jVx1Vr45IYZXdnuMmQlJ963MVRseLeFnp2Z3e8K7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jlZiFw3/dlOY1I2ve4gSJbelqkTSiy5X3wHVECdOg1lPZg7oHpopGd2p76xNR0Ka9 ABN4AUSS3Wp93Sr2pHCYAk+JYiZfcziBWDovmizV40/Erz/212DF+VzatsIbCn1rXz eFl1FAQfhR16YFVj5BY/dNrf9phgneLN2TG3fuq8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbfEBObO (ORCPT ); Thu, 2 May 2019 10:31:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:51336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfEBObO (ORCPT ); Thu, 2 May 2019 10:31:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F5D5205F4; Thu, 2 May 2019 14:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556807473; bh=y5jVx1Vr45IYZXdnuMmQlJ963MVRseLeFnp2Z3e8K7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lb0LwYB5aV/+RONxcgf7wOlwTkwen8aazd2+1ujBiUjq1kHVOrZVjlgzIY95xfCAQ L1Qi3hK6a1MiB3I8n4Elvi0Zo0fDGNJDrx87crP2tmf+vo48Y+4ksgNAnqS4dXXHaz S6FIRV+ta5qdUjX6SF0HeJYSrOdOdpp5QWoO5PSc= Date: Thu, 2 May 2019 16:31:10 +0200 From: Greg KH To: Martin Schwidefsky Cc: Linus Torvalds , Christoph Hellwig , Linux List Kernel Mailing , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-s390 Subject: Re: Linux 5.1-rc5 Message-ID: <20190502143110.GC17577@kroah.com> References: <20190415051919.GA31481@infradead.org> <20190502122128.GA2670@kroah.com> <20190502161758.26972bb2@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502161758.26972bb2@mschwideX1> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote: > On Thu, 2 May 2019 14:21:28 +0200 > Greg KH wrote: > > > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig wrote: > > > > > > > > Can we please have the page refcount overflow fixes out on the list > > > > for review, even if it is after the fact? > > > > > > They were actually on a list for review long before the fact, but it > > > was the security mailing list. The issue actually got discussed back > > > in January along with early versions of the patches, but then we > > > dropped the ball because it just wasn't on anybody's radar and it got > > > resurrected late March. Willy wrote a rather bigger patch-series, and > > > review of that is what then resulted in those commits. So they may > > > look recent, but that's just because the original patches got > > > seriously edited down and rewritten. > > > > > > That said, powerpc and s390 should at least look at maybe adding a > > > check for the page ref in their gup paths too. Powerpc has the special > > > gup_hugepte() case, and s390 has its own version of gup entirely. I > > > was actually hoping the s390 guys would look at using the generic gup > > > code. > > > > > > I ruthlessly also entirely ignored MIPS, SH and sparc, since they seem > > > largely irrelevant, partly since even theoretically this whole issue > > > needs a _lot_ of memory. > > > > > > Michael, Martin, see commit 6b3a70773630 ("Merge branch 'page-refs' > > > (page ref overflow)"). You may or may not really care. > > > > I've now queued these patches up for the next round of stable releases, > > as some people seem to care about these. > > > > I didn't see any follow-on patches for s390 or ppc64 hit the tree for > > these changes, am I just missing them and should also queue up a few > > more to handle this issue on those platforms? > > I fixed that with a different approach. The following two patches are > queued for the next merge window: > > d1874a0c2805 "s390/mm: make the pxd_offset functions more robust" > 1a42010cdc26 "s390/mm: convert to the generic get_user_pages_fast code" > > With these two s390 now uses the generic gup code in mm/gup.c Nice! Do you want me to queue those up for the stable backports once they hit a public -rc release? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 2 May 2019 16:31:10 +0200 From: Greg KH Subject: Re: Linux 5.1-rc5 Message-ID: <20190502143110.GC17577@kroah.com> References: <20190415051919.GA31481@infradead.org> <20190502122128.GA2670@kroah.com> <20190502161758.26972bb2@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502161758.26972bb2@mschwideX1> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Archive: To: Martin Schwidefsky Cc: linux-s390 , Linux List Kernel Mailing , Christoph Hellwig , Linus Torvalds , linuxppc-dev@lists.ozlabs.org List-ID: On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote: > On Thu, 2 May 2019 14:21:28 +0200 > Greg KH wrote: > > > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig wrote: > > > > > > > > Can we please have the page refcount overflow fixes out on the list > > > > for review, even if it is after the fact? > > > > > > They were actually on a list for review long before the fact, but it > > > was the security mailing list. The issue actually got discussed back > > > in January along with early versions of the patches, but then we > > > dropped the ball because it just wasn't on anybody's radar and it got > > > resurrected late March. Willy wrote a rather bigger patch-series, and > > > review of that is what then resulted in those commits. So they may > > > look recent, but that's just because the original patches got > > > seriously edited down and rewritten. > > > > > > That said, powerpc and s390 should at least look at maybe adding a > > > check for the page ref in their gup paths too. Powerpc has the special > > > gup_hugepte() case, and s390 has its own version of gup entirely. I > > > was actually hoping the s390 guys would look at using the generic gup > > > code. > > > > > > I ruthlessly also entirely ignored MIPS, SH and sparc, since they seem > > > largely irrelevant, partly since even theoretically this whole issue > > > needs a _lot_ of memory. > > > > > > Michael, Martin, see commit 6b3a70773630 ("Merge branch 'page-refs' > > > (page ref overflow)"). You may or may not really care. > > > > I've now queued these patches up for the next round of stable releases, > > as some people seem to care about these. > > > > I didn't see any follow-on patches for s390 or ppc64 hit the tree for > > these changes, am I just missing them and should also queue up a few > > more to handle this issue on those platforms? > > I fixed that with a different approach. The following two patches are > queued for the next merge window: > > d1874a0c2805 "s390/mm: make the pxd_offset functions more robust" > 1a42010cdc26 "s390/mm: convert to the generic get_user_pages_fast code" > > With these two s390 now uses the generic gup code in mm/gup.c Nice! Do you want me to queue those up for the stable backports once they hit a public -rc release? thanks, greg k-h