From: joeyli <jlee@suse.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
David Howells <dhowells@redhat.com>,
Josh Boyer <jwboyer@fedoraproject.org>,
Nayna Jain <nayna@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-efi <linux-efi@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 1/2 v2] efi: add a function to convert the status value to string
Date: Fri, 3 May 2019 14:15:18 +0800 [thread overview]
Message-ID: <20190503061518.GM11486@linux-l9pv.suse> (raw)
In-Reply-To: <CAKv+Gu9mjtNEWN-w4ix7VJMZ_kk-Qf6FfYFRu2mCosaAjMA4Vg@mail.gmail.com>
On Thu, May 02, 2019 at 10:53:31AM +0200, Ard Biesheuvel wrote:
> On Thu, 2 May 2019 at 06:04, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> >
> > This function can be used to convert EFI status value to string
> > for printing out debug message. Using this function can improve
> > the readability of log.
> >
> > v2.
>
> Please move the changelog out of the commit log (move it below the ---
> further down)
>
OK! I will moved the changelog out of the commit log.
> > - Changed the wording in subject and description.
> > - Moved the marco immediately after the status value definitions.
> > - Turned into a proper function instead of inline.
> >
>
> You missed my point here. A proper function means the function in a .c
> file, and only the declaration in a .h file. This way, you are still
> duplicating the literal strings into every object file that references
> this function.
>
Sorry for I missunderstood. I will move the function to load_uefi.c.
Thanks a lot!
Joey Lee
next prev parent reply other threads:[~2019-05-03 6:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 4:04 [PATCH 1/2 v2] efi: add a function to convert the status value to string Lee, Chun-Yi
2019-05-02 4:04 ` [PATCH 2/2 v3] efi: print appropriate status message when loading certificates Lee, Chun-Yi
2019-05-02 9:04 ` Ard Biesheuvel
2019-05-03 7:18 ` joeyli
2019-05-03 8:07 ` Ard Biesheuvel
2019-05-03 8:58 ` joeyli
2019-05-03 14:23 ` Ard Biesheuvel
2019-05-07 8:43 ` joeyli
2019-05-02 8:53 ` [PATCH 1/2 v2] efi: add a function to convert the status value to string Ard Biesheuvel
2019-05-03 6:15 ` joeyli [this message]
2019-05-03 6:16 ` Ard Biesheuvel
2019-05-03 8:01 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503061518.GM11486@linux-l9pv.suse \
--to=jlee@suse.com \
--cc=anton@enomsg.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ccross@android.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=joeyli.kernel@gmail.com \
--cc=jwboyer@fedoraproject.org \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=tony.luck@intel.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.