All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: phy: improve pause handling
Date: Sat, 04 May 2019 00:48:11 -0400 (EDT)	[thread overview]
Message-ID: <20190504.004811.237662972933481916.davem@davemloft.net> (raw)
In-Reply-To: <d437c5d8-e683-4d69-7818-c6f69053bc02@gmail.com>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 1 May 2019 21:34:43 +0200

> When probing the phy device we set sym and asym pause in the "supported"
> bitmap (unless the PHY tells us otherwise). However we don't know yet
> whether the MAC supports pause. Simply copying phy->supported to
> phy->advertising will trigger advertising pause, and that's not
> what we want. Therefore add phy_advertise_supported() that copies all
> modes but doesn't touch the pause bits.
> 
> In phy_support_(a)sym_pause we shouldn't set any bits in the supported
> bitmap because we may set a bit the PHY intentionally disabled.
> Effective pause support should be the AND-combined PHY and MAC pause
> capabilities. If the MAC supports everything, then it's only relevant
> what the PHY supports. If MAC supports sym pause only, then we have to
> clear the asym bit in phydev->supported.
> Copy the pause flags only and don't touch the modes, because a driver
> may have intentionally removed a mode from phydev->advertising.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - removed patch 2 from the series

Applied.

      parent reply	other threads:[~2019-05-04  4:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 20:12 [PATCH net-next 0/2] net: phy: improve pause handling Heiner Kallweit
2019-04-29 20:13 ` [PATCH net-next 1/2] " Heiner Kallweit
2019-04-29 20:14 ` [PATCH net-next 2/2] net: phy: improve phy_set_sym_pause and phy_set_asym_pause Heiner Kallweit
2019-04-29 21:52   ` Andrew Lunn
2019-04-30  5:06     ` Heiner Kallweit
2019-05-01 19:32       ` Heiner Kallweit
2019-05-01 19:34 ` [PATCH v2 net-next] net: phy: improve pause handling Heiner Kallweit
2019-05-01 20:35   ` Andrew Lunn
2019-05-04  4:48   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190504.004811.237662972933481916.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.