From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A6CC04AAB for ; Mon, 6 May 2019 08:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2614C2082F for ; Mon, 6 May 2019 08:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbfEFI3j (ORCPT ); Mon, 6 May 2019 04:29:39 -0400 Received: from mga18.intel.com ([134.134.136.126]:4122 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfEFI3i (ORCPT ); Mon, 6 May 2019 04:29:38 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 01:29:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,437,1549958400"; d="scan'208";a="229830002" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga001.jf.intel.com with ESMTP; 06 May 2019 01:29:35 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hNZ0A-00086o-9W; Mon, 06 May 2019 11:29:34 +0300 Date: Mon, 6 May 2019 11:29:34 +0300 From: Andy Shevchenko To: Bjorn Helgaas Cc: Frederick Lawler , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, lukas@wunner.de, keith.busch@intel.com, mr.nuke.me@gmail.com, liudongdong3@huawei.com, thesven73@gmail.com Subject: Re: [PATCH v2 6/9] PCI: hotplug: Prefix dmesg logs with PCIe service name Message-ID: <20190506082934.GI9224@smile.fi.intel.com> References: <20190503035946.23608-1-fred@fredlawl.com> <20190503035946.23608-7-fred@fredlawl.com> <20190503200437.GD180403@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503200437.GD180403@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 03, 2019 at 03:04:37PM -0500, Bjorn Helgaas wrote: > On Thu, May 02, 2019 at 10:59:43PM -0500, Frederick Lawler wrote: > > +#define pr_fmt(fmt) "pciehp: " fmt > > +#define dev_fmt pr_fmt > > Can these go in pciehp.h? In general, no, it can't. The pr_fmt() / dev_fmt() macro must precede any header inclusion, thus it makes them position dependent. Otherwise, one has to guarantee above by accurately keeping a header inclusion ordering. -- With Best Regards, Andy Shevchenko