From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F2CC004C9 for ; Tue, 7 May 2019 08:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7506620B7C for ; Tue, 7 May 2019 08:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbfEGIkG (ORCPT ); Tue, 7 May 2019 04:40:06 -0400 Received: from sauhun.de ([88.99.104.3]:41954 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726159AbfEGIkG (ORCPT ); Tue, 7 May 2019 04:40:06 -0400 Received: from localhost (p54B332BA.dip0.t-ipconnect.de [84.179.50.186]) by pokefinder.org (Postfix) with ESMTPSA id 6C28C2C28E9; Tue, 7 May 2019 10:40:03 +0200 (CEST) Date: Tue, 7 May 2019 10:40:03 +0200 From: Wolfram Sang To: Rob Herring Cc: Chuanhua Han , mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, leoyang.li@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com, wsa+renesas@sang-engineering.com, u.kleine-koenig@pengutronix.de, eha@deif.com, linux@rempel-privat.de, sumit.batra@nxp.com, l.stach@pengutronix.de, peda@axentia.se Subject: Re: [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding Message-ID: <20190507084002.GA25688@kunai> References: <20190430043242.29687-1-chuanhua.han@nxp.com> <20190502205901.GA24224@bogus> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: <20190502205901.GA24224@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 02, 2019 at 03:59:01PM -0500, Rob Herring wrote: > On Tue, Apr 30, 2019 at 12:32:40PM +0800, Chuanhua Han wrote: > > NXP Layerscape SoC have up to three MUL options available for all > > divider values, we choice of MUL determines the internal monitor rate > > of the I2C bus (SCL and SDA signals): > > A lower MUL value results in a higher sampling rate of the I2C signals. > > A higher MUL value results in a lower sampling rate of the I2C signals. > >=20 > > So in Optional properties we added our custom mul-value property in the > > binding to select which mul option for the device tree i2c controller > > node. > >=20 > > Signed-off-by: Chuanhua Han > > --- > > Documentation/devicetree/bindings/i2c/i2c-imx.txt | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.txt b/Docume= ntation/devicetree/bindings/i2c/i2c-imx.txt > > index b967544590e8..ba8e7b7b3fa8 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > @@ -18,6 +18,9 @@ Optional properties: > > - sda-gpios: specify the gpio related to SDA pin > > - pinctrl: add extra pinctrl to configure i2c pins to gpio function fo= r i2c > > bus recovery, call it "gpio" state > > +- mul-value: NXP Layerscape SoC have up to three MUL options available= for > > +all I2C divider values, it describes which MUL we choose to use for th= e driver, > > +the values should be 1,2,4. >=20 > Needs a vendor prefix. I don't find 'value' to add anything nor do I=20 > understand what MUL is. >=20 > If it is determined by SoC rather than board, then it should perhaps be= =20 > implied by compatible. I was wondering the same. --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlzRRF8ACgkQFA3kzBSg KbbUbRAApE4I45wTxiU40khw2A2mDLGqByh6dKjqeRVRHGsUrLdKN3tptV5pVqgM LdX5QFuA4Hp1TEkPLhuie+S7y0DfcN1NQEOPtP2ofZFTcMV93MhvZ7W2KEegnbld RzvlIcqxMHoQgDBsJunkOcZuqUVicSwYETYXsbFGBAMJGTzhZR4Sh2Qt0VNRUmwu UMFuBqnnhDXBkl7VSeKXDgjctCJnVaiyqj2jnz5HD4eOBtHj7zvPXnSYyMfYhrUL Z6TXVxdloC6j8noqtORUM4YmlleDepXqp/L2SGRhZ1Qi55XQd6oexxiP7ndDZV0W WRu3GaJOtXyOQYqeYMkfLbUPn90FkDLCFun1HKPBO07fcX/qWZmZnoXVX2799odV jofYTj6X0ILs79fIUT8wAUnMCmEgjgPOynl57loP4f8lh6VoWeDAEI1nwCoPxi0l TKabxPYDHpbT7vFP2eaR7/dXQxb+pgLNMUeqzPpIQ7XnSHrLl+7nrhVDcpzSWTr2 ci6eWscPRJNr/OVa0wd+L4nthna/K89ZApK4zf9aioBTLPZ/EEZscAJ/YuZiJZ2d ZtwvTt6ewEz6D5OF6vsNjn7FOuqp7CIEhyPqFU+E5SC3iO05TqBhb9w34F5mO2oK Oswf5Q47JpcE4stdbVJa7ZTUd+P8gfmH+X71qLQzcU3wujem2K4= =cq07 -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2ABBC004C9 for ; Tue, 7 May 2019 08:40:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 911AA20B7C for ; Tue, 7 May 2019 08:40:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XZ7AecTR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 911AA20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhiIeKQ7RjeXH63elyEyx1hljxd/LYmmSVVIdqm005o=; b=XZ7AecTRtk1YrS15Y5XAbKvmM 3sKPC3QUXipNKsn7sd17GriXrxGP5SFOhVEjlfaU2uC+73KCgCID/Y9V3/OEU5y/mPheI9i2bv19R JRXZoWPQ7QcGFKLF/PtiEVz9wWmM/YSiVhdr0RkjHP9HaQTjR5W/UcdquuSqwNfzCJVWWJNixeWQE T1pJQX60ZCjJdFGlGNKZ4PHVwYwdH4r4zHQrgHmmXeV0824qemLq/MXrMHo3HTNCH1medcU5x5iRl jCEWxigZcojzMe4AVtOV48WiuYUCWQ5JiqlDnU8JjFTkXq+wwFwWLq5bdBfght8AuGXjen/CEjea/ cluvPEr9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNvdz-0007qS-Na; Tue, 07 May 2019 08:40:11 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNvdv-0006oe-El for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 08:40:09 +0000 Received: from localhost (p54B332BA.dip0.t-ipconnect.de [84.179.50.186]) by pokefinder.org (Postfix) with ESMTPSA id 6C28C2C28E9; Tue, 7 May 2019 10:40:03 +0200 (CEST) Date: Tue, 7 May 2019 10:40:03 +0200 From: Wolfram Sang To: Rob Herring Subject: Re: [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding Message-ID: <20190507084002.GA25688@kunai> References: <20190430043242.29687-1-chuanhua.han@nxp.com> <20190502205901.GA24224@bogus> MIME-Version: 1.0 In-Reply-To: <20190502205901.GA24224@bogus> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_014007_800369_F6BD293C X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sumit.batra@nxp.com, eha@deif.com, festevam@gmail.com, s.hauer@pengutronix.de, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, wsa+renesas@sang-engineering.com, l.stach@pengutronix.de, linux-i2c@vger.kernel.org, kernel@pengutronix.de, Chuanhua Han , linux@rempel-privat.de, shawnguo@kernel.org, peda@axentia.se, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Content-Type: multipart/mixed; boundary="===============3827498726113570625==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3827498726113570625== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 02, 2019 at 03:59:01PM -0500, Rob Herring wrote: > On Tue, Apr 30, 2019 at 12:32:40PM +0800, Chuanhua Han wrote: > > NXP Layerscape SoC have up to three MUL options available for all > > divider values, we choice of MUL determines the internal monitor rate > > of the I2C bus (SCL and SDA signals): > > A lower MUL value results in a higher sampling rate of the I2C signals. > > A higher MUL value results in a lower sampling rate of the I2C signals. > >=20 > > So in Optional properties we added our custom mul-value property in the > > binding to select which mul option for the device tree i2c controller > > node. > >=20 > > Signed-off-by: Chuanhua Han > > --- > > Documentation/devicetree/bindings/i2c/i2c-imx.txt | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.txt b/Docume= ntation/devicetree/bindings/i2c/i2c-imx.txt > > index b967544590e8..ba8e7b7b3fa8 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.txt > > @@ -18,6 +18,9 @@ Optional properties: > > - sda-gpios: specify the gpio related to SDA pin > > - pinctrl: add extra pinctrl to configure i2c pins to gpio function fo= r i2c > > bus recovery, call it "gpio" state > > +- mul-value: NXP Layerscape SoC have up to three MUL options available= for > > +all I2C divider values, it describes which MUL we choose to use for th= e driver, > > +the values should be 1,2,4. >=20 > Needs a vendor prefix. I don't find 'value' to add anything nor do I=20 > understand what MUL is. >=20 > If it is determined by SoC rather than board, then it should perhaps be= =20 > implied by compatible. I was wondering the same. --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlzRRF8ACgkQFA3kzBSg KbbUbRAApE4I45wTxiU40khw2A2mDLGqByh6dKjqeRVRHGsUrLdKN3tptV5pVqgM LdX5QFuA4Hp1TEkPLhuie+S7y0DfcN1NQEOPtP2ofZFTcMV93MhvZ7W2KEegnbld RzvlIcqxMHoQgDBsJunkOcZuqUVicSwYETYXsbFGBAMJGTzhZR4Sh2Qt0VNRUmwu UMFuBqnnhDXBkl7VSeKXDgjctCJnVaiyqj2jnz5HD4eOBtHj7zvPXnSYyMfYhrUL Z6TXVxdloC6j8noqtORUM4YmlleDepXqp/L2SGRhZ1Qi55XQd6oexxiP7ndDZV0W WRu3GaJOtXyOQYqeYMkfLbUPn90FkDLCFun1HKPBO07fcX/qWZmZnoXVX2799odV jofYTj6X0ILs79fIUT8wAUnMCmEgjgPOynl57loP4f8lh6VoWeDAEI1nwCoPxi0l TKabxPYDHpbT7vFP2eaR7/dXQxb+pgLNMUeqzPpIQ7XnSHrLl+7nrhVDcpzSWTr2 ci6eWscPRJNr/OVa0wd+L4nthna/K89ZApK4zf9aioBTLPZ/EEZscAJ/YuZiJZ2d ZtwvTt6ewEz6D5OF6vsNjn7FOuqp7CIEhyPqFU+E5SC3iO05TqBhb9w34F5mO2oK Oswf5Q47JpcE4stdbVJa7ZTUd+P8gfmH+X71qLQzcU3wujem2K4= =cq07 -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE-- --===============3827498726113570625== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3827498726113570625==--