From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17479C004C9 for ; Tue, 7 May 2019 09:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E73A3204FD for ; Tue, 7 May 2019 09:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726501AbfEGJF5 (ORCPT ); Tue, 7 May 2019 05:05:57 -0400 Received: from foss.arm.com ([217.140.101.70]:47416 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfEGJF5 (ORCPT ); Tue, 7 May 2019 05:05:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DE3B374; Tue, 7 May 2019 02:05:57 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 868BD3F238; Tue, 7 May 2019 02:05:55 -0700 (PDT) Date: Tue, 7 May 2019 10:05:50 +0100 From: Will Deacon To: Christoph Hellwig Cc: Catalin Marinas , Robin Murphy , Joerg Roedel , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/25] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Message-ID: <20190507090550.GA16148@fuggles.cambridge.arm.com> References: <20190430105214.24628-1-hch@lst.de> <20190430105214.24628-2-hch@lst.de> <20190503113352.GA55449@arrakis.emea.arm.com> <20190507063720.GB28147@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190507063720.GB28147@lst.de> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 08:37:20AM +0200, Christoph Hellwig wrote: > On Fri, May 03, 2019 at 12:33:53PM +0100, Catalin Marinas wrote: > > On Tue, Apr 30, 2019 at 06:51:50AM -0400, Christoph Hellwig wrote: > > > DMA allocations that can't sleep may return non-remapped addresses, but > > > we do not properly handle them in the mmap and get_sgtable methods. > > > Resolve non-vmalloc addresses using virt_to_page to handle this corner > > > case. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Robin Murphy > > > > Acked-by: Catalin Marinas > > Given that this is a bug fix mostly separate from the rest of the > series - do you want to pick it up for 5.2 and maybe add a Cc for > stable? Sure thing; I'll probably send it after -rc1 unless we get some other fixes in during the merge window. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45580C004C9 for ; Tue, 7 May 2019 11:35:06 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22435205ED for ; Tue, 7 May 2019 11:35:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22435205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 10514130E; Tue, 7 May 2019 11:34:53 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CF4E412F3 for ; Tue, 7 May 2019 11:34:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 748198C3 for ; Tue, 7 May 2019 09:05:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DE3B374; Tue, 7 May 2019 02:05:57 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 868BD3F238; Tue, 7 May 2019 02:05:55 -0700 (PDT) Date: Tue, 7 May 2019 10:05:50 +0100 From: Will Deacon To: Christoph Hellwig Subject: Re: [PATCH 01/25] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Message-ID: <20190507090550.GA16148@fuggles.cambridge.arm.com> References: <20190430105214.24628-1-hch@lst.de> <20190430105214.24628-2-hch@lst.de> <20190503113352.GA55449@arrakis.emea.arm.com> <20190507063720.GB28147@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507063720.GB28147@lst.de> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Cc: Tom Lendacky , Catalin Marinas , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, May 07, 2019 at 08:37:20AM +0200, Christoph Hellwig wrote: > On Fri, May 03, 2019 at 12:33:53PM +0100, Catalin Marinas wrote: > > On Tue, Apr 30, 2019 at 06:51:50AM -0400, Christoph Hellwig wrote: > > > DMA allocations that can't sleep may return non-remapped addresses, but > > > we do not properly handle them in the mmap and get_sgtable methods. > > > Resolve non-vmalloc addresses using virt_to_page to handle this corner > > > case. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Robin Murphy > > > > Acked-by: Catalin Marinas > > Given that this is a bug fix mostly separate from the rest of the > series - do you want to pick it up for 5.2 and maybe add a Cc for > stable? Sure thing; I'll probably send it after -rc1 unless we get some other fixes in during the merge window. Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09127C004C9 for ; Tue, 7 May 2019 09:06:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD208204FD for ; Tue, 7 May 2019 09:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ik2EOfSF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD208204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Qed2YcAyrrrh6lH5YXg1gNxaIwd0HwLhM220w30134=; b=Ik2EOfSFRVMUh9 KG1EAXNelqcFvWIlPNf6bq0iTIkoZE/gfseW2EmZjS8hDXREkSHgExSslrQ2qfsoRaGLH35NRURMh r+uyd8C0fCwi9fbznaTJnbavzzo4g3S7tNUcOfXKWPb68/O8aTi+gsXViAh01thIt3JfKMMBhRK5+ iCwf54Spt/R0SCZu5n90ROzovjXsIdG4UyhQtR43nfVTJqvzusM+OvNKVORk7diVkmQgJmwF/Zk2Y fa3L00LXHIot7pR/JJ/Eq+lmE8jVW4azlvRQkfBwqmUmQ0NyapYRhNsxBtJYBMy+jZLhruDTrf0dQ 0fN6h6G8JRQDKTV1wYMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNw2y-0004Ay-Nu; Tue, 07 May 2019 09:06:00 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNw2v-00049A-QP for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 09:05:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DE3B374; Tue, 7 May 2019 02:05:57 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 868BD3F238; Tue, 7 May 2019 02:05:55 -0700 (PDT) Date: Tue, 7 May 2019 10:05:50 +0100 From: Will Deacon To: Christoph Hellwig Subject: Re: [PATCH 01/25] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Message-ID: <20190507090550.GA16148@fuggles.cambridge.arm.com> References: <20190430105214.24628-1-hch@lst.de> <20190430105214.24628-2-hch@lst.de> <20190503113352.GA55449@arrakis.emea.arm.com> <20190507063720.GB28147@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507063720.GB28147@lst.de> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_020557_915960_AFB784DB X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Catalin Marinas , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2019 at 08:37:20AM +0200, Christoph Hellwig wrote: > On Fri, May 03, 2019 at 12:33:53PM +0100, Catalin Marinas wrote: > > On Tue, Apr 30, 2019 at 06:51:50AM -0400, Christoph Hellwig wrote: > > > DMA allocations that can't sleep may return non-remapped addresses, but > > > we do not properly handle them in the mmap and get_sgtable methods. > > > Resolve non-vmalloc addresses using virt_to_page to handle this corner > > > case. > > > > > > Signed-off-by: Christoph Hellwig > > > Reviewed-by: Robin Murphy > > > > Acked-by: Catalin Marinas > > Given that this is a bug fix mostly separate from the rest of the > series - do you want to pick it up for 5.2 and maybe add a Cc for > stable? Sure thing; I'll probably send it after -rc1 unless we get some other fixes in during the merge window. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel