From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FEFAC004C9 for ; Tue, 7 May 2019 09:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E170205ED for ; Tue, 7 May 2019 09:32:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NKcG+r6/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfEGJcp (ORCPT ); Tue, 7 May 2019 05:32:45 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35245 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfEGJco (ORCPT ); Tue, 7 May 2019 05:32:44 -0400 Received: by mail-wr1-f68.google.com with SMTP id w12so7845941wrp.2 for ; Tue, 07 May 2019 02:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=G7Dumy4AOd1vCBggiJHZKL6Nn0KP4/1BivjvxQRWHRk=; b=NKcG+r6/zP79zGYJQFgwyIJuD7cMOk/77HIGMvK1mr6K0hvINAMEtSAJpXL1Bbc1wE kiWtshjAD0n63GZ+InjbXUYB+y/J8xLsBihWtOfb74XrJLiQzYcRzW1y9MIbsSFtgDH+ 3HKIAXBuy0mD5UCzu7U6GvNZBu6UKWb8YGpvDpjo2OkM0/r7ophexlilpXli02aeBkbg X+Tyoz6UIB7fPDUx+yUlEA4zw4ELZAs7v85oq7yF/NB3EXsf+PxVAY9+YCocUV7/spJg 3DoyBOxPIbRw9zAxsHjbXC5EMqzT39QDPqSeiYAyGRrs9jMoTMk4Ad1gpSNomauuxUyg mLBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=G7Dumy4AOd1vCBggiJHZKL6Nn0KP4/1BivjvxQRWHRk=; b=jMQGuieKFBi++QHa3DXRtzfU/CM060vyOSafYoART/xM/tUUmhyzPK6/sg8E93/n/s zKnICybkgfeZZ5gM1ASx4ETPh+WfDjNoNWrVq6ZSU/Ft5miK49Qx8T1O9VnUptUi08Co iH9z4YDMGE1lgTGuN6Mamq7hF+uJnoUYnVzoJABvMK5FxlZJXUYmLzKLeDwYvYI3dt49 a8pBzyYDvLhXfgRN3voTlZ65Y7N91zbsSCaWpP8OVRf2QHyAzAdapOymhF3g4dsedSVH RqmvBbR+gijd3ug0Ynlt6S0j5+Id0zgV8TSUcPR4HcYx1MVaKxg19Icqh2AkVpN+MS94 ZInw== X-Gm-Message-State: APjAAAXP1/dhBBnrEJvNE8PWFWGRp0xk8190NNiJjxlC9xmUU9Y5IE6H 99La1M+6bFNvzupZ3KNG/lXiKCOOZsA= X-Google-Smtp-Source: APXvYqzzMke6HbKJ7MgmPbfT9g2onn2MByckb//Ing49zbvFroSoe7K25cgK8jM9yeL80ui3gBbjGQ== X-Received: by 2002:a5d:4642:: with SMTP id j2mr1210049wrs.268.1557221563105; Tue, 07 May 2019 02:32:43 -0700 (PDT) Received: from dell ([2.27.167.43]) by smtp.gmail.com with ESMTPSA id h24sm15794834wmb.40.2019.05.07.02.32.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 02:32:41 -0700 (PDT) Date: Tue, 7 May 2019 10:32:39 +0100 From: Lee Jones To: Esben Haabendal Cc: Andy Shevchenko , linux-serial@vger.kernel.org, Enrico Weigelt , Greg Kroah-Hartman , Jiri Slaby , Darwin Dingel , Jisheng Zhang , Sebastian Andrzej Siewior , He Zhe , Marek Vasut , Douglas Anderson , Paul Burton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250: Add support for using platform_device resources Message-ID: <20190507093239.GB4529@dell> References: <20190430140416.4707-1-esben@geanix.com> <20190430153736.GL9224@smile.fi.intel.com> <874l6efxta.fsf@haabendal.dk> <20190502104556.GS9224@smile.fi.intel.com> <87pnp11112.fsf@haabendal.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pnp11112.fsf@haabendal.dk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 May 2019, Esben Haabendal wrote: > Hi Lee > > Could you help clarify whether or not this patch is trying to do > something odd/wrong? > > I might be misunderstanding Andy (probably is), but the discussion > revolves around the changes I propose where I change the serial8250 > driver to use platform_get_resource() in favour of > request_mem_region()/release_mem_region(). Since 'serial8250' is registered as a platform device, I don't see any reason why it shouldn't have the capability to obtain its memory regions from the platform_get_*() helpers. > In my understanding, use of platform_get_resource() is the right thing > to do in order to integrate properly with with MFD drivers that splits a > common memory resource in mfd_add_device() using the mem_base argument. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog