From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF8D8C004C9 for ; Tue, 7 May 2019 15:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75BA02087F for ; Tue, 7 May 2019 15:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="q3WfvQiY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfEGPYy (ORCPT ); Tue, 7 May 2019 11:24:54 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57396 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfEGPYy (ORCPT ); Tue, 7 May 2019 11:24:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FtjyM26XsYTblD9NmW/RCrjv8PwkOYDcOPzujGk6vtk=; b=q3WfvQiY7Z7At64kvXI0x7gNhh wqXcJUShVLJJ9CiVFG7L1C7yV7cKTnnehPkjG2mKfL9z+ZBEZrvnleMapbQEJn2eS90kzKh1iX3dI rXHcdqjK+RlZn3uF3/YVSCVf8zqAudqKeN1R/RV9vjMkwTuQ9hfdSTmEzOujD29gXTxY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hO1xR-00019y-TJ; Tue, 07 May 2019 17:24:41 +0200 Date: Tue, 7 May 2019 17:24:41 +0200 From: Andrew Lunn To: Sagar Shrikant Kadam Cc: robh+dt@kernel.org, mark.rutland@arm.com, peter@korsgaard.com, palmer@sifive.com, paul.walmsley@sifive.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings. Message-ID: <20190507152441.GC25013@lunn.ch> References: <1557242108-13580-1-git-send-email-sagar.kadam@sifive.com> <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +or > + /* > + An Opencore based I2C node in FU540-C000 chip from SiFive > + This chip has a hardware erratum for broken IRQ > + so it's recommended not to define interrupt in the device node > + */ > + i2c@10030000 { > + compatible = "sifive,i2c0","sifive,fu540-c000-i2c"; The most specific compatible comes first. You also need to be forward thinking. The next revision of the silicon could have the bug fixed. You can then use plain "sifive,i2c0" to indicate just polling is needed, not bug workaround. But for that to work, you need "sifive,fu540-c000-i2c" first. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A62AC004C9 for ; Tue, 7 May 2019 15:24:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D04C2087F for ; Tue, 7 May 2019 15:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WmxgaXsK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="q3WfvQiY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D04C2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Lsu8NW314O8EBbLqQ53EmmXllmkUAVIs2iDFy7c0+I=; b=WmxgaXsKQnWcu9 wvuhxu2INz/8dxXhI38oRhvH9E2g4g2Jy8Btx5UWom9Hco2a76ZStCbqRFK0yI0aRtjjFk7gBCLo9 +A3RRU8HCOsgpa3Gz2qfpnPmBUaUd5zYsA9hoeZUU0njmdpGVY8DtkhgqN5w00d7ocUmWozaAmT5V c3lMacjOmMg8gevu4YoARVGkFPzLmr/yqK/R0S31N1Cgy1Ir6NCP7MxvKzsrQAKqWeX9qVoRv3NIL PVbKOs40rd0g70aVr+HoxCKJI7XghIKZJzaSg4eedZ633be+1PMr8gQKVb4uWheL0PydAP3oDMK2p 2AgzAXD+Y49je0vkyYSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO1xf-0003uj-Qk; Tue, 07 May 2019 15:24:55 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO1xd-0003tx-3E for linux-riscv@lists.infradead.org; Tue, 07 May 2019 15:24:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FtjyM26XsYTblD9NmW/RCrjv8PwkOYDcOPzujGk6vtk=; b=q3WfvQiY7Z7At64kvXI0x7gNhh wqXcJUShVLJJ9CiVFG7L1C7yV7cKTnnehPkjG2mKfL9z+ZBEZrvnleMapbQEJn2eS90kzKh1iX3dI rXHcdqjK+RlZn3uF3/YVSCVf8zqAudqKeN1R/RV9vjMkwTuQ9hfdSTmEzOujD29gXTxY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hO1xR-00019y-TJ; Tue, 07 May 2019 17:24:41 +0200 Date: Tue, 7 May 2019 17:24:41 +0200 From: Andrew Lunn To: Sagar Shrikant Kadam Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings. Message-ID: <20190507152441.GC25013@lunn.ch> References: <1557242108-13580-1-git-send-email-sagar.kadam@sifive.com> <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_082453_291883_1C58C32A X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, peter@korsgaard.com, palmer@sifive.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-i2c@vger.kernel.org, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org > +or > + /* > + An Opencore based I2C node in FU540-C000 chip from SiFive > + This chip has a hardware erratum for broken IRQ > + so it's recommended not to define interrupt in the device node > + */ > + i2c@10030000 { > + compatible = "sifive,i2c0","sifive,fu540-c000-i2c"; The most specific compatible comes first. You also need to be forward thinking. The next revision of the silicon could have the bug fixed. You can then use plain "sifive,i2c0" to indicate just polling is needed, not bug workaround. But for that to work, you need "sifive,fu540-c000-i2c" first. Andrew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv