From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FECC04AAB for ; Tue, 7 May 2019 17:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3752206BF for ; Tue, 7 May 2019 17:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557251118; bh=mE/YighewZji2jdALogvRxl+gKJULhzu19FRdUZqyHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=T9NDbAw8UL962E3Ll4k6jLqzQ9pE91YPjm4LeBc3/Qbe/ctP9pntz5NtG0Xuy3Lig PUH8/7wwVpKxgEUT9KSR9XOWPvKE/pFCjbKuI0uMQAAe1SLQbcLwd+bBGPj6dhBywK AUeXq8M5tkqyhzoDyu/W68jGFKxHdGoNiBz0GeDY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbfEGRpR (ORCPT ); Tue, 7 May 2019 13:45:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:44954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726699AbfEGRpQ (ORCPT ); Tue, 7 May 2019 13:45:16 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D85A205C9; Tue, 7 May 2019 17:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557251115; bh=mE/YighewZji2jdALogvRxl+gKJULhzu19FRdUZqyHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sY8/+8XQ92ZXJgN8PAqu8UrV/K07qeZA1yYTfgXcoC/e6WoGCQKN8S+/hRLPmUZhS 0aJgZ3eezGGEiPFqd+8x7IGAN0cHy4GBimd72MOJC7icpy9MMCykrksZnR+0EeWn0k KT9xDdfYUnnWMNzK2P2eNli9huwC2R6ijAa7gcb4= Date: Tue, 7 May 2019 13:45:14 -0400 From: Sasha Levin To: Matthew Wilcox Cc: Michal Hocko , Linus Torvalds , Alexander Duyck , LKML , stable , Mikhail Zaslonko , Gerald Schaefer , Mikhail Gavrilov , Dave Hansen , Alexander Duyck , Pasha Tatashin , Martin Schwidefsky , Heiko Carstens , Andrew Morton , Sasha Levin , linux-mm Subject: Re: [PATCH AUTOSEL 4.14 62/95] mm, memory_hotplug: initialize struct pages for the full memory section Message-ID: <20190507174514.GI1747@sasha-vm> References: <20190507053826.31622-1-sashal@kernel.org> <20190507053826.31622-62-sashal@kernel.org> <20190507170208.GF1747@sasha-vm> <20190507171806.GG1747@sasha-vm> <20190507173224.GS31017@dhcp22.suse.cz> <20190507173655.GA1403@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190507173655.GA1403@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 10:36:55AM -0700, Matthew Wilcox wrote: >On Tue, May 07, 2019 at 07:32:24PM +0200, Michal Hocko wrote: >> On Tue 07-05-19 13:18:06, Sasha Levin wrote: >> > Michal, is there a testcase I can plug into kselftests to make sure we >> > got this right (and don't regress)? We care a lot about memory hotplug >> > working right. >> >> As said in other email. The memory hotplug tends to work usually. It >> takes unexpected memory layouts which trigger corner cases. This makes >> testing really hard. > >Can we do something with qemu? Is it flexible enough to hotplug memory >at the right boundaries? That was my thinking too. qemu should be able to reproduce all these "unexpected" memory layouts we've had issue with so far and at the very least make sure we don't regress on those. We're going to have (quite a) large amount of systems with "weird" memory layouts that do memory hotplug quite frequently in production, so this whole "tends to work usually" thing kinda scares me. -- Thanks, Sasha