All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH 05/11] memory: Pass mr into snapshot_and_clear_dirty
Date: Wed,  8 May 2019 14:15:17 +0800	[thread overview]
Message-ID: <20190508061523.17666-6-peterx@redhat.com> (raw)
In-Reply-To: <20190508061523.17666-1-peterx@redhat.com>

Also we change the 2nd parameter of it to be the relative offset
within the memory region. This is to be used in follow up patches.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 exec.c                  | 3 ++-
 include/exec/ram_addr.h | 2 +-
 memory.c                | 3 +--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/exec.c b/exec.c
index 4e734770c2..2615b4cfed 100644
--- a/exec.c
+++ b/exec.c
@@ -1387,9 +1387,10 @@ bool cpu_physical_memory_test_and_clear_dirty(ram_addr_t start,
 }
 
 DirtyBitmapSnapshot *cpu_physical_memory_snapshot_and_clear_dirty
-     (ram_addr_t start, ram_addr_t length, unsigned client)
+(MemoryRegion *mr, hwaddr addr, hwaddr length, unsigned client)
 {
     DirtyMemoryBlocks *blocks;
+    ram_addr_t start = memory_region_get_ram_addr(mr) + addr;
     unsigned long align = 1UL << (TARGET_PAGE_BITS + BITS_PER_LEVEL);
     ram_addr_t first = QEMU_ALIGN_DOWN(start, align);
     ram_addr_t last  = QEMU_ALIGN_UP(start + length, align);
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index 86bc8e1a4a..69cc528c98 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -403,7 +403,7 @@ bool cpu_physical_memory_test_and_clear_dirty(ram_addr_t start,
                                               unsigned client);
 
 DirtyBitmapSnapshot *cpu_physical_memory_snapshot_and_clear_dirty
-    (ram_addr_t start, ram_addr_t length, unsigned client);
+(MemoryRegion *mr, ram_addr_t start, hwaddr length, unsigned client);
 
 bool cpu_physical_memory_snapshot_get_dirty(DirtyBitmapSnapshot *snap,
                                             ram_addr_t start,
diff --git a/memory.c b/memory.c
index 1cc3531df5..be16beea76 100644
--- a/memory.c
+++ b/memory.c
@@ -2071,8 +2071,7 @@ DirtyBitmapSnapshot *memory_region_snapshot_and_clear_dirty(MemoryRegion *mr,
 {
     assert(mr->ram_block);
     memory_region_sync_dirty_bitmap(mr);
-    return cpu_physical_memory_snapshot_and_clear_dirty(
-                memory_region_get_ram_addr(mr) + addr, size, client);
+    return cpu_physical_memory_snapshot_and_clear_dirty(mr, addr, size, client);
 }
 
 bool memory_region_snapshot_get_dirty(MemoryRegion *mr, DirtyBitmapSnapshot *snap,
-- 
2.17.1



  parent reply	other threads:[~2019-05-08  6:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08  6:15 [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 01/11] migration: No need to take rcu during sync_dirty_bitmap Peter Xu
2019-05-08 10:09   ` Paolo Bonzini
2019-05-08  6:15 ` [Qemu-devel] [PATCH 02/11] memory: Remove memory_region_get_dirty() Peter Xu
2019-05-08 10:09   ` Paolo Bonzini
2019-05-08  6:15 ` [Qemu-devel] [PATCH 03/11] memory: Don't set migration bitmap when without migration Peter Xu
2019-05-08 10:09   ` Paolo Bonzini
2019-05-08  6:15 ` [Qemu-devel] [PATCH 04/11] bitmap: Add bitmap_copy_with_{src|dst}_offset() Peter Xu
2019-05-08  6:15 ` Peter Xu [this message]
2019-05-08  6:15 ` [Qemu-devel] [PATCH 06/11] memory: Introduce memory listener hook log_clear() Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 07/11] kvm: Update comments for sync_dirty_bitmap Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 08/11] kvm: Persistent per kvmslot dirty bitmap Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 09/11] kvm: Introduce slots lock for memory listener Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 10/11] kvm: Support KVM_CLEAR_DIRTY_LOG Peter Xu
2019-05-08  6:15 ` [Qemu-devel] [PATCH 11/11] migration: Split log_clear() into smaller chunks Peter Xu
2019-05-08 10:09 ` [Qemu-devel] [PATCH 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG Paolo Bonzini
2019-05-08 11:39   ` Peter Xu
2019-05-08 11:55     ` Paolo Bonzini
2019-05-09  2:33       ` Peter Xu
2019-05-16  9:26         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508061523.17666-6-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.