From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Angus Ainslie (Purism)" <angus@akkea.ca>,
angus.ainslie@puri.sm,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] usb: typec: tcpci: Clear the fault status register
Date: Wed, 8 May 2019 08:37:23 +0200 [thread overview]
Message-ID: <20190508063723.GA14085@kroah.com> (raw)
In-Reply-To: <5f0bec69-9579-f153-c3fd-d7b8deea75c4@roeck-us.net>
On Tue, May 07, 2019 at 05:49:14PM -0700, Guenter Roeck wrote:
> On 5/7/19 5:27 PM, Angus Ainslie (Purism) wrote:
> > If the fault status register doesn't get cleared then
> > the ptn5110 interrupt gets stuck on. As the fault register gets
> > set everytime the ptn5110 powers on the interrupt is always stuck.
> >
> > Fixes: fault status register stuck
>
> That is not how Fixes: tags are supposed to work. This should probably be
>
> Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Nit:
Fixes: 74e656d6b055 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
You only need 12 characters of the sha1 :)
next prev parent reply other threads:[~2019-05-08 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 0:27 [PATCH v2 0/1] usb: typec: tcpm: Add some FAULT_STATUS processing Angus Ainslie (Purism)
2019-05-08 0:27 ` [PATCH v2 1/1] usb: typec: tcpci: Clear the fault status register Angus Ainslie (Purism)
2019-05-08 0:49 ` Guenter Roeck
2019-05-08 6:37 ` Greg Kroah-Hartman [this message]
2019-05-08 2:03 ` Guenter Roeck
2019-05-08 2:49 ` Angus Ainslie
2019-05-08 5:18 ` Guenter Roeck
2019-05-08 13:48 ` Angus Ainslie
2019-05-08 16:22 ` Guenter Roeck
2019-05-08 16:33 ` Angus Ainslie
2019-05-08 16:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508063723.GA14085@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.