From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v3 1/4] cpufreq: Add imx-cpufreq-dt driver Date: Thu, 9 May 2019 14:53:36 +0530 Message-ID: <20190509092336.jw54pzq7i7gzcuky@vireshk-i7> References: <607242a278a4532d0b4285e0fb56abfd5767fdd1.1557236799.git.leonard.crestez@nxp.com> <20190508035402.7pbikzpkzxxesmlw@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Leonard Crestez Cc: Aisheng Dong , Mark Rutland , Abel Vesa , Anson Huang , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Rob Herring , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , Lucas Stach , "linux-arm-kernel@lists.infradead.org" , Jacky Bai List-Id: devicetree@vger.kernel.org On 09-05-19, 09:03, Leonard Crestez wrote: > On 5/8/2019 6:54 AM, Viresh Kumar wrote: > > On 07-05-19, 13:52, Leonard Crestez wrote: > > >> +config ARM_IMX_CPUFREQ_DT > >> + tristate "Freescale i.MX8M cpufreq support" > >> + depends on ARCH_MXC && CPUFREQ_DT > >> + default m if ARCH_MXC && CPUFREQ_DT > > > > As I said in the previous version, the if block above is redundant and > > not required. > > Sorry, I misread and thought you were referring to () rather than what's > inside. > > Is "default m" otherwise OK? It's a reasonable implication of ARCH_MXC I think it would be better to keep it disabled by default and so removing the line all together would be a good option. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04181C04AB1 for ; Thu, 9 May 2019 09:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C242521479 for ; Thu, 9 May 2019 09:23:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NIb2WRlP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725892AbfEIJXk (ORCPT ); Thu, 9 May 2019 05:23:40 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34666 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbfEIJXk (ORCPT ); Thu, 9 May 2019 05:23:40 -0400 Received: by mail-pf1-f196.google.com with SMTP id n19so1016623pfa.1 for ; Thu, 09 May 2019 02:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qMvKlIPlrNL8Lr3tsJwCK+5Y/oer0uCBV35dDO8Zkrk=; b=NIb2WRlPHYJaY9APSYPOmpC5vacCSIV3cMrBiWQ3B/dHkyFxJvA/UfHvbpyMUbKDCz gsufdXoTyBDhCnJyNmutfJSncarmM/zS6n0dbQA8l6odxlzRq6vvgDBAcaAz4Y3CprJ+ TYr/norj9dDW0G+uGhWb6id+gMBiW4Yp7jk8QLbjv4shl0/JdOjGCOqDJNr8kIkjJeP1 To4l6DWyIZpgoDAKXVGV5D4hssD0JJYO28tTGbBiN/ICU9cfY4dgv8JvNeoZ6fIExqES oR/gnsa/+UMi1JMtVbQ/VajewNslieyh6+0dGBjIeIsRQmQZfmJPyHm8JRhUAoudd9N1 fwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qMvKlIPlrNL8Lr3tsJwCK+5Y/oer0uCBV35dDO8Zkrk=; b=j+Ibw+ED0XR3xpuOof5NwoHj79mdUMzdGTOlhqektqqgEaBsArCgNdk7PIZI5sPXDi FQPSGJL1ptxehb4oLuSm9eOKtGKE4Ge1felFug+ow+3LC7C55TQEKwfpPOaUBiU63cmm UYbPECbUTgl+SFc1H5bRw96elx6ZF0UZ9Ag3qvz8+0t2CkzVx26TU1BDv4qSLLcZTnME F2TKxM4873/Y757CpsvK4X9r56ZOBemcyBG7C4S+6uJRZaR4ZlyGAbAIIzop704ts8yy HKvr/3MUhFTtNqDGntGUUGvLgMh8kfTSmiKk7e0Q1Y2ar/UZhSeYypuKIJ1fsyLG8faM 8n6Q== X-Gm-Message-State: APjAAAUrexcralnBfeNEx3r2vl16MJCZsqVeEZc7hn8mBPvDjdWB2kcS hIukzOlSJM5eoKocT7jJ8x4eJGpyyf4= X-Google-Smtp-Source: APXvYqypzpGZwMmGq/H4pQzwC/KWTbyJwztPpSpuLhtDasGDGxwbvdZQyeDTYFPbKi+URMbMIDz2NA== X-Received: by 2002:a63:5608:: with SMTP id k8mr3998732pgb.393.1557393819018; Thu, 09 May 2019 02:23:39 -0700 (PDT) Received: from localhost ([122.172.118.99]) by smtp.gmail.com with ESMTPSA id 124sm2897822pfe.124.2019.05.09.02.23.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 02:23:38 -0700 (PDT) Date: Thu, 9 May 2019 14:53:36 +0530 From: Viresh Kumar To: Leonard Crestez Cc: Lucas Stach , Rob Herring , Anson Huang , Jacky Bai , "Rafael J. Wysocki" , Abel Vesa , Aisheng Dong , Fabio Estevam , Mark Rutland , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/4] cpufreq: Add imx-cpufreq-dt driver Message-ID: <20190509092336.jw54pzq7i7gzcuky@vireshk-i7> References: <607242a278a4532d0b4285e0fb56abfd5767fdd1.1557236799.git.leonard.crestez@nxp.com> <20190508035402.7pbikzpkzxxesmlw@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190509092336.-3b4HJ72fgoq-6MB-UYG_qqIBjQgKujYvPFnh5NDhmE@z> On 09-05-19, 09:03, Leonard Crestez wrote: > On 5/8/2019 6:54 AM, Viresh Kumar wrote: > > On 07-05-19, 13:52, Leonard Crestez wrote: > > >> +config ARM_IMX_CPUFREQ_DT > >> + tristate "Freescale i.MX8M cpufreq support" > >> + depends on ARCH_MXC && CPUFREQ_DT > >> + default m if ARCH_MXC && CPUFREQ_DT > > > > As I said in the previous version, the if block above is redundant and > > not required. > > Sorry, I misread and thought you were referring to () rather than what's > inside. > > Is "default m" otherwise OK? It's a reasonable implication of ARCH_MXC I think it would be better to keep it disabled by default and so removing the line all together would be a good option. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FB0C04AB1 for ; Thu, 9 May 2019 09:23:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56BC72175B for ; Thu, 9 May 2019 09:23:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BdG6LPD9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NIb2WRlP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56BC72175B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U4um+zI5tmAAcmE0WPADbBqQChH+qPiFvQiPTzDJrUI=; b=BdG6LPD9wLYRNv fQ2TqbFanZieByJLnSN4nUbjXrlZgjuRXarJPX+UDxXbOIVHK79UsV80Z8P9jqdEO1j8zW4QJrMiE UW/g7hKYqnjnoBZ0MeX5WwXph2hCxAdbUPHarVkvt3N/H5gpSFLtCGnyAVJCSSJCKehJ1VwBb3R6C Z7LmAYWy7Dv/oc4zvlsrE8MXGgf9Dxfe+9I14/+b80usjHhom8XqwApmju2HUtQ3sCzFXF+Sm7hzw i3qIDM/ugBRmgo+TnQr/0YZxOxeUoMzpLBcJ1Br8848HrxKlAnMRM9P4sQ7aC9V3mlHeEjOMjji5W wdrhXxpZHzBZpcwqnDFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOfHI-00035G-K1; Thu, 09 May 2019 09:23:48 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOfHA-00031d-Ei for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2019 09:23:41 +0000 Received: by mail-pf1-x441.google.com with SMTP id s11so988597pfm.12 for ; Thu, 09 May 2019 02:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qMvKlIPlrNL8Lr3tsJwCK+5Y/oer0uCBV35dDO8Zkrk=; b=NIb2WRlPHYJaY9APSYPOmpC5vacCSIV3cMrBiWQ3B/dHkyFxJvA/UfHvbpyMUbKDCz gsufdXoTyBDhCnJyNmutfJSncarmM/zS6n0dbQA8l6odxlzRq6vvgDBAcaAz4Y3CprJ+ TYr/norj9dDW0G+uGhWb6id+gMBiW4Yp7jk8QLbjv4shl0/JdOjGCOqDJNr8kIkjJeP1 To4l6DWyIZpgoDAKXVGV5D4hssD0JJYO28tTGbBiN/ICU9cfY4dgv8JvNeoZ6fIExqES oR/gnsa/+UMi1JMtVbQ/VajewNslieyh6+0dGBjIeIsRQmQZfmJPyHm8JRhUAoudd9N1 fwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qMvKlIPlrNL8Lr3tsJwCK+5Y/oer0uCBV35dDO8Zkrk=; b=Ynn/I11WK0csXtfZzkXaC4Z9S9Z0Kk9OpYcqyWrmDfO7z/G7WmxPnUTibIcLObQzJy L+hLrxULKz1T2ayHMk0r3sjV2b0o3sJdPpFMfHQ1OEHmF0oFxzChuKbs65rir77Xm0H6 DCAWDpnMH7qcYIWcJygACwIjBdpIUn0c/B4l33hE+OkxHpVhg6tF3m3GgDfTo029Wkq1 k2jMm7GypqECCH1B1a4G9Ofs8Z6WKN6cvuqm6YTQ6mnjtzWn6yCe6dJY7RVD6QZnI7Ll /+ZD8VydI6TNe9ZgfODBRoqY8mPUTx6hS5thVb+vbdbKqGXspMEkBdzpyG0R4Qwm504x aC+w== X-Gm-Message-State: APjAAAUvT0yOfrm7ud+By4Dp2GT/E9hNuFokuQdVtJ8BJIb3ZCCekmIw Bqfvxvo6go1T/h/twiagvbfC1A== X-Google-Smtp-Source: APXvYqypzpGZwMmGq/H4pQzwC/KWTbyJwztPpSpuLhtDasGDGxwbvdZQyeDTYFPbKi+URMbMIDz2NA== X-Received: by 2002:a63:5608:: with SMTP id k8mr3998732pgb.393.1557393819018; Thu, 09 May 2019 02:23:39 -0700 (PDT) Received: from localhost ([122.172.118.99]) by smtp.gmail.com with ESMTPSA id 124sm2897822pfe.124.2019.05.09.02.23.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 02:23:38 -0700 (PDT) Date: Thu, 9 May 2019 14:53:36 +0530 From: Viresh Kumar To: Leonard Crestez Subject: Re: [PATCH v3 1/4] cpufreq: Add imx-cpufreq-dt driver Message-ID: <20190509092336.jw54pzq7i7gzcuky@vireshk-i7> References: <607242a278a4532d0b4285e0fb56abfd5767fdd1.1557236799.git.leonard.crestez@nxp.com> <20190508035402.7pbikzpkzxxesmlw@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190509_022340_568780_49B03971 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Mark Rutland , Abel Vesa , Anson Huang , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Rob Herring , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , Lucas Stach , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09-05-19, 09:03, Leonard Crestez wrote: > On 5/8/2019 6:54 AM, Viresh Kumar wrote: > > On 07-05-19, 13:52, Leonard Crestez wrote: > > >> +config ARM_IMX_CPUFREQ_DT > >> + tristate "Freescale i.MX8M cpufreq support" > >> + depends on ARCH_MXC && CPUFREQ_DT > >> + default m if ARCH_MXC && CPUFREQ_DT > > > > As I said in the previous version, the if block above is redundant and > > not required. > > Sorry, I misread and thought you were referring to () rather than what's > inside. > > Is "default m" otherwise OK? It's a reasonable implication of ARCH_MXC I think it would be better to keep it disabled by default and so removing the line all together would be a good option. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel