From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 10 May 2019 00:11:12 +0200 From: Halil Pasic Subject: Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio In-Reply-To: <20190509121106.48aa04db.cohuck@redhat.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-6-pasic@linux.ibm.com> <20190508232210.5a555caa.pasic@linux.ibm.com> <20190509121106.48aa04db.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20190510001112.479b2fd7.pasic@linux.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Cornelia Huck Cc: Sebastian Ott , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman , Michael Mueller List-ID: On Thu, 9 May 2019 12:11:06 +0200 Cornelia Huck wrote: > On Wed, 8 May 2019 23:22:10 +0200 > Halil Pasic wrote: > > > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > > Sebastian Ott wrote: > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > goto out_unregister; > > > > } > > > > + cio_dma_pool_init(); > > > > > > This is too late for early devices (ccw console!). > > > > You have already raised concern about this last time (thanks). I think, > > I've addressed this issue: tje cio_dma_pool is only used by the airq > > stuff. I don't think the ccw console needs it. Please have an other look > > at patch #6, and explain your concern in more detail if it persists. > > What about changing the naming/adding comments here, so that (1) folks > aren't confused by the same thing in the future and (2) folks don't try > to use that pool for something needed for the early ccw consoles? > I'm all for clarity! Suggestions for better names? Regards, Halil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Halil Pasic Subject: Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio Date: Fri, 10 May 2019 00:11:12 +0200 Message-ID: <20190510001112.479b2fd7.pasic@linux.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-6-pasic@linux.ibm.com> <20190508232210.5a555caa.pasic@linux.ibm.com> <20190509121106.48aa04db.cohuck@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190509121106.48aa04db.cohuck@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Cornelia Huck Cc: Vasily Gorbik , linux-s390@vger.kernel.org, Thomas Huth , Claudio Imbrenda , Sebastian Ott , kvm@vger.kernel.org, "Michael S. Tsirkin" , Farhan Ali , Eric Farman , virtualization@lists.linux-foundation.org, Christoph Hellwig , Martin Schwidefsky , Michael Mueller , Viktor Mihajlovski , Janosch Frank List-Id: virtualization@lists.linuxfoundation.org On Thu, 9 May 2019 12:11:06 +0200 Cornelia Huck wrote: > On Wed, 8 May 2019 23:22:10 +0200 > Halil Pasic wrote: > > > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > > Sebastian Ott wrote: > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > goto out_unregister; > > > > } > > > > + cio_dma_pool_init(); > > > > > > This is too late for early devices (ccw console!). > > > > You have already raised concern about this last time (thanks). I think, > > I've addressed this issue: tje cio_dma_pool is only used by the airq > > stuff. I don't think the ccw console needs it. Please have an other look > > at patch #6, and explain your concern in more detail if it persists. > > What about changing the naming/adding comments here, so that (1) folks > aren't confused by the same thing in the future and (2) folks don't try > to use that pool for something needed for the early ccw consoles? > I'm all for clarity! Suggestions for better names? Regards, Halil