From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 6/8] drm/i915: Align dumb buffer stride to 4k to allow for gtt remapping Date: Fri, 10 May 2019 10:40:55 +0200 Message-ID: <20190510084055.GI17751@phenom.ffwll.local> References: <20190509122159.24376-1-ville.syrjala@linux.intel.com> <20190509122159.24376-7-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB775898EE for ; Fri, 10 May 2019 08:40:59 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id g57so4371238edc.12 for ; Fri, 10 May 2019 01:40:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190509122159.24376-7-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDksIDIwMTkgYXQgMDM6MjE6NTdQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEFsaWduIGR1bWIgYnVmZmVyIHN0cmlkZSB0byA0ayBpZiB0aGUgZmIgd2lsbCBi ZSBiaWcgZW5vdWdoIHRvCj4gcmVxdWlyZSBndHQgcmVtYXBwaW5nLgo+IAo+IHYyOiBMZWF2ZSB0 aGUgc3RyaWRlIGFsb25lIGZvciBidWZmZXJzIHRoYXQgbG9vayB0byBiZSBmb3IgdGhlIGN1cnNv cgo+IHYzOiBNYWtlIGl0IG5vdCBhIGhhY2sgKERhbmllbCkKPiAKPiBDYzogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKWWVhaCBJIHRoaW5rIHRoaXMgaXMg YSByZWFzb25hYmxlIGhldXJpc3RpY3MuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgICAgICB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKystCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICAxIC0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5oIHwgIDIgKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDRl NDc0YmNmNGMyMi4uN2NhZmQ1NjEyZjcxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g QEAgLTUyLDYgKzUyLDcgQEAKPiAgI2luY2x1ZGUgImk5MTVfdHJhY2UuaCIKPiAgI2luY2x1ZGUg Imk5MTVfdmdwdS5oIgo+ICAKPiArI2luY2x1ZGUgImludGVsX2Rpc3BsYXkuaCIKPiAgI2luY2x1 ZGUgImludGVsX2Rydi5oIgo+ICAjaW5jbHVkZSAiaW50ZWxfZnJvbnRidWZmZXIuaCIKPiAgI2lu Y2x1ZGUgImludGVsX3BtLmgiCj4gQEAgLTU2MCw4ICs1NjEsMzEgQEAgaTkxNV9nZW1fZHVtYl9j cmVhdGUoc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICAJCSAgICAgc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPiAgCQkgICAgIHN0cnVjdCBkcm1fbW9kZV9jcmVhdGVfZHVtYiAqYXJncykKPiAgewo+ ICsJaW50IGNwcCA9IERJVl9ST1VORF9VUChhcmdzLT5icHAsIDgpOwo+ICsJdTMyIGZvcm1hdDsK PiArCj4gKwlzd2l0Y2ggKGNwcCkgewo+ICsJY2FzZSAxOgo+ICsJCWZvcm1hdCA9IERSTV9GT1JN QVRfQzg7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDI6Cj4gKwkJZm9ybWF0ID0gRFJNX0ZPUk1BVF9S R0I1NjU7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDQ6Cj4gKwkJZm9ybWF0ID0gRFJNX0ZPUk1BVF9Y UkdCODg4ODsKPiArCQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g Kwl9Cj4gKwo+ICAJLyogaGF2ZSB0byB3b3JrIG91dCBzaXplL3BpdGNoIGFuZCByZXR1cm4gdGhl bSAqLwo+IC0JYXJncy0+cGl0Y2ggPSBBTElHTihhcmdzLT53aWR0aCAqIERJVl9ST1VORF9VUChh cmdzLT5icHAsIDgpLCA2NCk7Cj4gKwlhcmdzLT5waXRjaCA9IEFMSUdOKGFyZ3MtPndpZHRoICog Y3BwLCA2NCk7Cj4gKwo+ICsJLyogYWxpZ24gc3RyaWRlIHRvIHBhZ2Ugc2l6ZSBzbyB0aGF0IHdl IGNhbiByZW1hcCAqLwo+ICsJaWYgKGFyZ3MtPnBpdGNoID4gaW50ZWxfcGxhbmVfZmJfbWF4X3N0 cmlkZSh0b19pOTE1KGRldiksIGZvcm1hdCwKPiArCQkJCQkJICAgIERSTV9GT1JNQVRfTU9EX0xJ TkVBUikpCj4gKwkJYXJncy0+cGl0Y2ggPSBBTElHTihhcmdzLT5waXRjaCwgNDA5Nik7Cj4gKwo+ ICAJYXJncy0+c2l6ZSA9IGFyZ3MtPnBpdGNoICogYXJncy0+aGVpZ2h0Owo+ICAJcmV0dXJuIGk5 MTVfZ2VtX2NyZWF0ZShmaWxlLCB0b19pOTE1KGRldiksCj4gIAkJCSAgICAgICAmYXJncy0+c2l6 ZSwgJmFyZ3MtPmhhbmRsZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGlu ZGV4IDk0ZmFhYzllMzY2Ni4uZmEzMTdjNDBkNTQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IEBAIC0yNDk4LDcgKzI0OTgsNiBAQCBib29sIGlzX2Njc19tb2RpZmll cih1NjQgbW9kaWZpZXIpCj4gIAkgICAgICAgbW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lm X1RJTEVEX0NDUzsKPiAgfQo+ICAKPiAtc3RhdGljCj4gIHUzMiBpbnRlbF9wbGFuZV9mYl9tYXhf c3RyaWRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICAgICAgdTMy IHBpeGVsX2Zvcm1hdCwgdTY0IG1vZGlmaWVyKQo+ICB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuaAo+IGluZGV4IDUwMGVlYzkwOTI4ZC4uMWU2NTMzZmJkMDYxIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuaAo+IEBAIC00MzYsNiArNDM2LDggQEAgdm9pZCBp bnRlbF9saW5rX2NvbXB1dGVfbV9uKHUxNiBicHAsIGludCBubGFuZXMsCj4gIAkJCSAgICBib29s IGNvbnN0YW50X24pOwo+ICBib29sIGlzX2Njc19tb2RpZmllcih1NjQgbW9kaWZpZXIpOwo+ICB2 b2lkIGxwdF9kaXNhYmxlX2Nsa291dF9kcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpOwo+ICt1MzIgaW50ZWxfcGxhbmVfZmJfbWF4X3N0cmlkZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gKwkJCSAgICAgIHUzMiBwaXhlbF9mb3JtYXQsIHU2NCBtb2RpZmll cik7Cj4gIGJvb2wgaW50ZWxfcGxhbmVfY2FuX3JlbWFwKGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFu ZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+ICAKPiAgI2VuZGlmCj4gLS0gCj4gMi4yMS4wCj4gCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4