From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BF9C04A6B for ; Fri, 10 May 2019 18:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACCD8217D7 for ; Fri, 10 May 2019 18:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="yOSTv0Oi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbfEJSQj (ORCPT ); Fri, 10 May 2019 14:16:39 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60433 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbfEJSQj (ORCPT ); Fri, 10 May 2019 14:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uFC+y3ZsLGupA5I1JlrkRkVbQ7hVyAZFCrpjLKH9AI4=; b=yOSTv0OiuyDMVvB44pRedqLQTE vsxq7GsXe/xTmAxMj+ywreVo9JDWPfQPaS/qbQyoQ8YneWPLk01Bb0yPnzoBeL3oyZULBirbeniJX Sl75FAZoWWjPl3aMZHfyq7Mf0tVm/9JEamPRcFtnw1PtoiXj4GYS1EBydlgqhurOHv4M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hPA4N-0004im-SX; Fri, 10 May 2019 20:16:31 +0200 Date: Fri, 10 May 2019 20:16:31 +0200 From: Andrew Lunn To: Andy Duan Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "ynezz@true.cz" , "john@phrozen.org" , "bgolaszewski@baylibre.com" Subject: Re: [PATCH net 1/3] net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order Message-ID: <20190510181631.GE11588@lunn.ch> References: <1557476567-17397-1-git-send-email-fugang.duan@nxp.com> <1557476567-17397-2-git-send-email-fugang.duan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557476567-17397-2-git-send-email-fugang.duan@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 10, 2019 at 08:24:00AM +0000, Andy Duan wrote: > ethernet controller driver call .of_get_mac_address() to get > the mac address from devictree tree, if these properties are > not present, then try to read from nvmem. > > For example, read MAC address from nvmem: > of_get_mac_address() > of_get_mac_addr_nvmem() > nvmem_get_mac_address() > > i.MX6x/7D/8MQ/8MM platforms ethernet MAC address read from > nvmem ocotp eFuses, but it requires to swap the six bytes > order. > > The patch add optional property "nvmem_macaddr_swap" to swap Please use nvmem-macaddr-swap. It is very unusal to use _ in property names. Andrew