From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D7CC04AB1 for ; Mon, 13 May 2019 09:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55229214AE for ; Mon, 13 May 2019 09:35:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbfEMJfp (ORCPT ); Mon, 13 May 2019 05:35:45 -0400 Received: from smtp-out.xnet.cz ([178.217.244.18]:37461 "EHLO smtp-out.xnet.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfEMJfp (ORCPT ); Mon, 13 May 2019 05:35:45 -0400 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 5E283383E; Mon, 13 May 2019 11:35:41 +0200 (CEST) Received: from localhost (meh.true.cz [local]) by meh.true.cz (OpenSMTPD) with ESMTPA id 466aa462; Mon, 13 May 2019 11:35:40 +0200 (CEST) Date: Mon, 13 May 2019 11:35:39 +0200 From: ynezz To: Andy Duan Cc: Maxime Ripard , Petr =?utf-8?Q?=C5=A0tetiar?= , "davem@davemloft.net" , "netdev@vger.kernel.org" , "john@phrozen.org" , "bgolaszewski@baylibre.com" , Srinivas Kandagatla , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Rob Herring , Frank Rowand , Mark Rutland , Alban Bedel , "devicetree@vger.kernel.org" Subject: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order Message-ID: <20190513082625.GA14498@ibawizard.net> References: <1557476567-17397-4-git-send-email-fugang.duan@nxp.com> <1557476567-17397-3-git-send-email-fugang.duan@nxp.com> <1557476567-17397-2-git-send-email-fugang.duan@nxp.com> <1557476567-17397-1-git-send-email-fugang.duan@nxp.com> <20190510112822.GT81826@meh.true.cz> <20190510113155.mvpuhe4yzxdaanei@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Andy Duan [2019-05-13 03:38:32]: > From: Maxime Ripard Sent: Friday, May 10, 2019 7:32 PM > > > > It looks to me that it should be abstracted away by the nvmem interface and > > done at the provider level, not the customer. > > > If to implement add above features like Petr Štetiar described, it should be abstracted > In nvmem core driver. Maxime made it clear, that network layer as a consumer of the nvmem provider doesn't need to know about this byte order swapping details, so this byte order swapping should be implemented in nvmem as well, as a bonus it doesn't matter if you're going to swap 3, 6 or whatever other amount of bytes described by the reg property, so this functionality could be reused which is always good. -- ynezz