From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 03/12] x86/IRQ: avoid UB (or worse) in trace_irq_mask() Date: Mon, 13 May 2019 11:08:52 +0200 Message-ID: <20190513090852.qy5l2mtxheafjjxu@Air-de-Roger> References: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> <5CD2D2C8020000780022CCF2@prv1-mh.provo.novell.com> <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ6xE-0005Sr-SH for xen-devel@lists.xenproject.org; Mon, 13 May 2019 09:09:04 +0000 Content-Disposition: inline In-Reply-To: <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , xen-devel , Wei Liu , Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMDc6MDc6MjFBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gRHluYW1pY2FsbHkgYWxsb2NhdGVkIENQVSBtYXNrIG9iamVjdHMgbWF5IGJlIHNtYWxs ZXIgdGhhbiBjcHVtYXNrX3QsIHNvCj4gY29weWluZyBoYXMgdG8gYmUgcmVzdHJpY3RlZCB0byB0 aGUgYWN0dWFsIGFsbG9jYXRpb24gc2l6ZS4gVGhpcyBpcwo+IHBhcnRpY3VsYXJ5IGltcG9ydGFu dCBzaW5jZSB0aGUgZnVuY3Rpb24gZG9lc24ndCBiYWlsIGVhcmx5IHdoZW4gdHJhY2luZwo+IGlz IG5vdCBhY3RpdmUsIHNvIGV2ZW4gcHJvZHVjdGlvbiBidWlsZHMgd291bGQgYmUgYWZmZWN0ZWQg YnkgcG90ZW50aWFsCj4gbWlzYmVoYXZpb3IgaGVyZS4KPiAKPiBUYWtlIHRoZSBvcHBvcnR1bml0 eSBhbmQgYWxzbwo+IC0gdXNlIGluaXRpYWxpemVycyBpbnN0ZWFkIG9mIGFzc2lnbm1lbnQgKyBt ZW1zZXQoKSwKPiAtIGNvbnN0aWZ5IHRoZSBjcHVtYXNrX3QgaW5wdXQgcG9pbnRlciwKPiAtIHUz MiAtPiB1aW50MzJfdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+CgpUaGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D25DC04AB1 for ; Mon, 13 May 2019 09:09:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAD8220989 for ; Mon, 13 May 2019 09:09:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAD8220989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ6xG-0005Sw-9D; Mon, 13 May 2019 09:09:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQ6xE-0005Sr-SH for xen-devel@lists.xenproject.org; Mon, 13 May 2019 09:09:04 +0000 X-Inumbo-ID: bec80c08-755e-11e9-82d3-1363f3a63372 Received: from SMTP.EU.CITRIX.COM (unknown [185.25.65.24]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bec80c08-755e-11e9-82d3-1363f3a63372; Mon, 13 May 2019 09:09:00 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,465,1549929600"; d="scan'208";a="89705394" Date: Mon, 13 May 2019 11:08:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Message-ID: <20190513090852.qy5l2mtxheafjjxu@Air-de-Roger> References: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> <5CD2D2C8020000780022CCF2@prv1-mh.provo.novell.com> <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5CD2D489020000780022CD34@prv1-mh.provo.novell.com> User-Agent: NeoMutt/20180716 X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) Subject: Re: [Xen-devel] [PATCH v2 03/12] x86/IRQ: avoid UB (or worse) in trace_irq_mask() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , xen-devel , Wei Liu , Andrew Cooper Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190513090852.jNZFwawFJHx6t3L3SkKuINLmnqyT-rDL2hr34CnrXyU@z> T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMDc6MDc6MjFBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gRHluYW1pY2FsbHkgYWxsb2NhdGVkIENQVSBtYXNrIG9iamVjdHMgbWF5IGJlIHNtYWxs ZXIgdGhhbiBjcHVtYXNrX3QsIHNvCj4gY29weWluZyBoYXMgdG8gYmUgcmVzdHJpY3RlZCB0byB0 aGUgYWN0dWFsIGFsbG9jYXRpb24gc2l6ZS4gVGhpcyBpcwo+IHBhcnRpY3VsYXJ5IGltcG9ydGFu dCBzaW5jZSB0aGUgZnVuY3Rpb24gZG9lc24ndCBiYWlsIGVhcmx5IHdoZW4gdHJhY2luZwo+IGlz IG5vdCBhY3RpdmUsIHNvIGV2ZW4gcHJvZHVjdGlvbiBidWlsZHMgd291bGQgYmUgYWZmZWN0ZWQg YnkgcG90ZW50aWFsCj4gbWlzYmVoYXZpb3IgaGVyZS4KPiAKPiBUYWtlIHRoZSBvcHBvcnR1bml0 eSBhbmQgYWxzbwo+IC0gdXNlIGluaXRpYWxpemVycyBpbnN0ZWFkIG9mIGFzc2lnbm1lbnQgKyBt ZW1zZXQoKSwKPiAtIGNvbnN0aWZ5IHRoZSBjcHVtYXNrX3QgaW5wdXQgcG9pbnRlciwKPiAtIHUz MiAtPiB1aW50MzJfdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+CgpUaGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs