All of lore.kernel.org
 help / color / mirror / Atom feed
From: Etienne Carriere <etienne.carriere@linaro.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/7] boot/optee-os: correct TA files install
Date: Tue, 14 May 2019 10:53:13 +0200	[thread overview]
Message-ID: <20190514085319.9031-1-etienne.carriere@linaro.org> (raw)

This change corrects TA binary files install sequence that
were previously install in target filesystem though
OPTEE_OS_INSTALL_IMAGES_CMDS instead of expected
OPTEE_OS_INSTALL_TARGET_CMDS.

This change removes useless mkdir prior call to $(INSTALL)
that already handles parent directory creation when needed.

This change conditions .ta files install upon their
generation as a custom package repository may not generate
any .ta files.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
Changes v3 -> v4:
- No change
Changes v2 -> v3:
- No change
Changes v1 -> v2:
- Patch introduced in v2
---
 boot/optee-os/optee-os.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/boot/optee-os/optee-os.mk b/boot/optee-os/optee-os.mk
index 6da20a9f3e..b22f560ba7 100644
--- a/boot/optee-os/optee-os.mk
+++ b/boot/optee-os/optee-os.mk
@@ -75,10 +75,10 @@ endef
 endif # BR2_TARGET_OPTEE_OS_CORE
 
 ifeq ($(BR2_TARGET_OPTEE_OS_SERVICES),y)
-define OPTEE_OS_INSTALL_IMAGES_SERVICES
-	mkdir -p $(TARGET_DIR)/lib/optee_armtz
-	$(INSTALL) -D -m 444 -t $(TARGET_DIR)/lib/optee_armtz \
-		$(@D)/$(OPTEE_OS_BUILDDIR_OUT)/ta/*/*.ta
+define OPTEE_OS_INSTALL_TARGET_CMDS
+	$(if $(wildcard $(@D)/$(OPTEE_OS_BUILDDIR_OUT)/ta/*/*.ta),
+		$(INSTALL) -D -m 444 -t $(TARGET_DIR)/lib/optee_armtz \
+			$(@D)/$(OPTEE_OS_BUILDDIR_OUT)/ta/*/*.ta)
 endef
 endif # BR2_TARGET_OPTEE_OS_SERVICES
 
-- 
2.17.1

             reply	other threads:[~2019-05-14  8:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  8:53 Etienne Carriere [this message]
2019-05-14  8:53 ` [Buildroot] [PATCH v4 2/7] boot/optee-os: install trusted shared libraries Etienne Carriere
2019-05-14 15:47   ` Thomas Petazzoni
2019-05-14  8:53 ` [Buildroot] [PATCH v4 3/7] boot/optee-os: bump version to 3.5.0 Etienne Carriere
2019-05-14 16:19   ` Thomas Petazzoni
2019-05-15  6:48     ` Etienne Carriere
2019-05-14  8:53 ` [Buildroot] [PATCH v4 4/7] package/optee-client: " Etienne Carriere
2019-05-14 16:19   ` Thomas Petazzoni
2019-05-14 16:21     ` Thomas Petazzoni
2019-05-14  8:53 ` [Buildroot] [PATCH v4 5/7] package/optee-test: " Etienne Carriere
2019-05-14 16:19   ` Thomas Petazzoni
2019-05-14  8:53 ` [Buildroot] [PATCH v4 6/7] package/optee-examples: " Etienne Carriere
2019-05-14 16:19   ` Thomas Petazzoni
2019-05-14  8:53 ` [Buildroot] [PATCH v4 7/7] package/optee-benchmark: " Etienne Carriere
2019-05-14 16:20   ` Thomas Petazzoni
2019-05-14 15:47 ` [Buildroot] [PATCH v4 1/7] boot/optee-os: correct TA files install Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190514085319.9031-1-etienne.carriere@linaro.org \
    --to=etienne.carriere@linaro.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.