All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Shawn Landden <shawn@git.icu>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: allow a differn't diff.context config for git format-patch
Date: Tue, 14 May 2019 05:54:46 -0400	[thread overview]
Message-ID: <20190514095446.GA12299@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+49okrzR7GAZCFDfaoJ9pvK+o=DVWoZ9vA6YL=u72s_rnjDxQ@mail.gmail.com>

On Sun, May 12, 2019 at 07:29:42AM -0500, Shawn Landden wrote:

> > After init_revisions(), we'll have called diff_setup(), which puts
> > diff_context_default into revs->diffopt. So we still have to do the "if
> > we have a format-specific value, then override..." conditional. But we
> > can do it without touching the hidden variable:
> >
> Looks like this fell into the cracks. You guys know the code much better
> than me, but do I have to write a patch to make this happen?

I think there is more work to be done in actually parsing such a config
option, plus adding documentation and tests.

But more importantly, it needs somebody to champion the feature. I don't
find it an unreasonable thing to want. But I'm not personally
interested, nor am I completely sure that it wouldn't have any unwanted
side effects.

So ideally somebody would write the patch and a compelling commit
message that explains why it is a good idea.

-Peff

  parent reply	other threads:[~2019-05-14  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 21:48 allow a differn't diff.context config for git format-patch Shawn Landden
2019-04-23  3:06 ` Jeff King
2019-04-23  3:45   ` Junio C Hamano
2019-04-23  3:55     ` Jeff King
2019-05-12 13:21       ` Shawn Landden
     [not found]       ` <CA+49okrzR7GAZCFDfaoJ9pvK+o=DVWoZ9vA6YL=u72s_rnjDxQ@mail.gmail.com>
2019-05-14  9:54         ` Jeff King [this message]
2019-05-14  9:57           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190514095446.GA12299@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=shawn@git.icu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.