All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: "Oleg Zhurakivskyy" <oleg.zhurakivskyy@intel.com>,
	"Clément Perrochaud" <clement.perrochaud@effinnov.com>,
	"Charles Gorand" <charles.gorand@effinnov.com>,
	linux-nfc@lists.01.org, "Samuel Ortiz" <sameo@linux.intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 00/12] NFC: nxp-nci: clean up and support new ID
Date: Tue, 14 May 2019 20:01:36 +0300	[thread overview]
Message-ID: <20190514170136.GI9224@smile.fi.intel.com> (raw)
In-Reply-To: <CA+icZUV=TBfabHsbzj_JPnxXBjo114LWVJ==xSS7zVPkajmNgw@mail.gmail.com>

On Tue, May 14, 2019 at 04:53:10PM +0200, Sedat Dilek wrote:
> On Tue, May 14, 2019 at 3:57 PM Oleg Zhurakivskyy
> <oleg.zhurakivskyy@intel.com> wrote:

> What about this one?
> 
> diff --git a/drivers/nfc/nxp-nci/Kconfig b/drivers/nfc/nxp-nci/Kconfig
> index a28c4265354d..b9e6486aa8fe 100644
> --- a/drivers/nfc/nxp-nci/Kconfig
> +++ b/drivers/nfc/nxp-nci/Kconfig
> @@ -2,8 +2,8 @@ config NFC_NXP_NCI
>         tristate "NXP-NCI NFC driver"
>         depends on NFC_NCI
>         ---help---
> -         Generic core driver for NXP NCI chips such as the NPC100
> -         or PN7150 families.
> +         Generic core driver for NXP NCI chips such as the NPC100 (PN547),
> +         NPC300 (PN548) or PN7150 families.
>           This is a driver based on the NCI NFC kernel layers and
>           will thus not work with NXP libnfc library.
> 
> @@ -19,6 +19,11 @@ config NFC_NXP_NCI_I2C
>           chips.
>           Select this if your platform is using the I2C bus.
> 
> +          Furthermore, the pin control and GPIO driver of the actual SoC or
> +          PCH is needed.
> +          For example set CONFIG_PINCTRL_SUNRISEPOINT=y to activate the
> +          Intel Sunrisepoint (PCH of Intel Skylake) pinctrl and GPIO driver.
> +

Besides some indentation problems (the help lines should be prefixed with
'TAB + 2 spaces'), this is not needed — it's obvious and usually distros
provide all of pin control drivers anyway.

For debugging one may check deferred devices via DebugFS, or use
'initcall_debug', or other facilities.

>           To compile this driver as a module, choose m here. The module will
>           be called nxp_nci_i2c.
> -         Say Y if unsure.
> +         Say N if unsure.


-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-05-14 17:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 10:43 [PATCH v2 00/12] NFC: nxp-nci: clean up and support new ID Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 01/12] NFC: nxp-nci: Add NXP1001 to the ACPI ID table Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 02/12] NFC: nxp-nci: Get rid of platform data Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 03/12] NFC: nxp-nci: Convert to use GPIO descriptor Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 04/12] NFC: nxp-nci: Add GPIO ACPI mapping table Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 05/12] NFC: nxp-nci: Get rid of code duplication in ->probe() Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 06/12] NFC: nxp-nci: Get rid of useless label Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 07/12] NFC: nxp-nci: Constify acpi_device_id Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 08/12] NFC: nxp-nci: Drop of_match_ptr() use Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 09/12] NFC: nxp-nci: Drop comma in terminator lines Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 10/12] NFC: nxp-nci: Remove unused macro pr_fmt() Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 11/12] NFC: nxp-nci: Remove 'default n' for tests Andy Shevchenko
2019-05-13 10:43 ` [PATCH v2 12/12] NFC: nxp-nci: Convert to SPDX license tags Andy Shevchenko
2019-05-13 11:43 ` [PATCH v2 00/12] NFC: nxp-nci: clean up and support new ID Sedat Dilek
2019-05-13 11:46   ` Sedat Dilek
2019-05-13 12:49     ` Oleg Zhurakivskyy
2019-05-13 12:56   ` Andy Shevchenko
2019-05-13 12:18 ` Sedat Dilek
2019-05-13 12:37   ` Andy Shevchenko
2019-05-14  8:34     ` Sedat Dilek
2019-05-14 11:44       ` Oleg Zhurakivskyy
2019-05-14 12:03         ` Sedat Dilek
2019-05-14 13:30           ` Oleg Zhurakivskyy
2019-05-14 13:44             ` Sedat Dilek
2019-05-14 13:56               ` Oleg Zhurakivskyy
2019-05-14 14:53                 ` Sedat Dilek
2019-05-14 17:01                   ` Andy Shevchenko [this message]
2019-05-15  8:32                     ` Sedat Dilek
2019-05-15 10:09                       ` Andy Shevchenko
2019-05-15 10:22                         ` Sedat Dilek
2019-05-13 19:48 ` Sedat Dilek
2019-05-14 10:03   ` Andy Shevchenko
2019-05-14 12:12     ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190514170136.GI9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=charles.gorand@effinnov.com \
    --cc=clement.perrochaud@effinnov.com \
    --cc=linux-nfc@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=oleg.zhurakivskyy@intel.com \
    --cc=sameo@linux.intel.com \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.