From: Lee Jones <lee.jones@linaro.org>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org,
marek.vasut@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org,
sergei.shtylyov@cogentembedded.com, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Wed, 15 May 2019 08:16:01 +0100 [thread overview]
Message-ID: <20190515071601.GQ4319@dell> (raw)
In-Reply-To: <OF794FCFCD.155B914B-ON482583FB.001EDBB3-482583FB.0020821B@mxic.com.tw>
On Wed, 15 May 2019, masonccyang@mxic.com.tw wrote:
> Hi Jones,
>
>
> > > +
> > > +struct rpc_spi {
> > > + struct rpc_mfd *mfd;
> >
> > The term MFD isn't a real thing. What you're obtaining below is
> > driver data and is normally articulated as 'ddata' in drivers.
>
> yes, it's just imply that data is from MFD.
>
> Should I rename "mfd" ?
Yes please.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-15 7:16 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 7:55 [PATCH v12 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD & SPI driver Mason Yang
2019-04-24 7:55 ` [PATCH v12 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-04-24 7:55 ` [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-05-14 6:52 ` Lee Jones
2019-05-15 5:55 ` masonccyang
2019-05-15 7:16 ` Lee Jones [this message]
2019-04-24 7:55 ` [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings Mason Yang
2019-04-24 21:23 ` Rob Herring
2019-04-24 21:54 ` Marek Vasut
2019-04-25 23:07 ` Rob Herring
2019-04-25 23:07 ` Rob Herring
2019-04-26 1:44 ` Marek Vasut
2019-04-26 1:44 ` Marek Vasut
2019-05-07 12:57 ` Lee Jones
2019-05-08 2:48 ` masonccyang
2019-05-08 3:52 ` Marek Vasut
2019-05-08 6:11 ` Lee Jones
2019-05-09 2:06 ` masonccyang
2019-05-09 19:23 ` Sergei Shtylyov
2019-05-10 1:06 ` masonccyang
2019-05-13 7:11 ` Geert Uytterhoeven
2019-05-13 7:11 ` Geert Uytterhoeven
2019-05-13 9:37 ` masonccyang
2019-05-13 14:43 ` Geert Uytterhoeven
2019-05-13 14:43 ` Geert Uytterhoeven
2019-05-14 2:33 ` masonccyang
2019-05-14 2:33 ` masonccyang
2019-05-13 19:08 ` Sergei Shtylyov
2019-05-13 19:08 ` Sergei Shtylyov
2019-05-14 9:46 ` masonccyang
2019-05-14 9:46 ` masonccyang
2019-05-14 9:46 ` masonccyang
2019-05-14 10:07 ` Geert Uytterhoeven
2019-05-14 10:07 ` Geert Uytterhoeven
2019-05-14 20:27 ` Sergei Shtylyov
2019-05-14 20:27 ` Sergei Shtylyov
2019-05-20 7:23 ` masonccyang
2019-05-20 7:23 ` masonccyang
2019-05-20 7:23 ` masonccyang
2019-05-20 7:44 ` Geert Uytterhoeven
2019-05-20 7:44 ` Geert Uytterhoeven
2019-05-21 1:28 ` masonccyang
2019-05-21 1:28 ` masonccyang
2019-05-22 16:32 ` Sergei Shtylyov
2019-05-22 16:32 ` Sergei Shtylyov
2019-05-22 17:05 ` Geert Uytterhoeven
2019-05-22 17:05 ` Geert Uytterhoeven
2019-05-22 17:23 ` Sergei Shtylyov
2019-05-22 17:23 ` Sergei Shtylyov
2019-05-22 17:44 ` Geert Uytterhoeven
2019-05-22 17:44 ` Geert Uytterhoeven
[not found] ` <OFAD9AA573.86373900-ON482583FA.0034781A-482583FA.0035B40C@LocalDomain>
2019-05-14 10:00 ` masonccyang
2019-05-14 10:00 ` masonccyang
2019-05-14 10:00 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515071601.GQ4319@dell \
--to=lee.jones@linaro.org \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.