From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E411DC04E53 for ; Wed, 15 May 2019 11:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B815B20862 for ; Wed, 15 May 2019 11:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918830; bh=uGqX99loL05PByMQw1blL16J0HtQ2rM0VMZvYsHnLqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=l163LCnYk9kcVopT2YikM7ew0Ao9BSKMUuNmbnmvO6KnchQ+U8ZVekSEDFGdCeTlo IdKjqgGJssBm3p6uShUk0bu6ON6NnIhS2HKaDgDZuHE3URCsaLF8jPPOb1gKSxRawI O9t5dmwxuP2i8bypZipp9tMb8oPHaVl0hJ7dgMbs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbfEOLNt (ORCPT ); Wed, 15 May 2019 07:13:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:49592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728897AbfEOLNr (ORCPT ); Wed, 15 May 2019 07:13:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 804632084E; Wed, 15 May 2019 11:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918827; bh=uGqX99loL05PByMQw1blL16J0HtQ2rM0VMZvYsHnLqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=liE8YVeBEHuZPIKFL03GhP7ebca3CJox/GtYNSoGeA9rb4iQSt1kN0CWY/7Bu1ohG eC0c62uSVxKuc8cuz1npZPWb7BNjLaQYz3K3GvBumjTuKTkJDMDxgAqlz1UGn/rojK JEOFz4Bzaqxp+Op84A8IeVBcJWSLU//iDE76l89Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tetsuo Handa , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 15/51] mISDN: Check address length before reading address family Date: Wed, 15 May 2019 12:55:50 +0200 Message-Id: <20190515090622.323232071@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090616.669619870@linuxfoundation.org> References: <20190515090616.669619870@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 238ffdc49ef98b15819cfd5e3fb23194e3ea3d39 ] KMSAN will complain if valid address length passed to bind() is shorter than sizeof("struct sockaddr_mISDN"->family) bytes. Signed-off-by: Tetsuo Handa Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/isdn/mISDN/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 99e5f9751e8b1..f96b8f2bdf743 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c @@ -712,10 +712,10 @@ base_sock_bind(struct socket *sock, struct sockaddr *addr, int addr_len) struct sock *sk = sock->sk; int err = 0; - if (!maddr || maddr->family != AF_ISDN) + if (addr_len < sizeof(struct sockaddr_mISDN)) return -EINVAL; - if (addr_len < sizeof(struct sockaddr_mISDN)) + if (!maddr || maddr->family != AF_ISDN) return -EINVAL; lock_sock(sk); -- 2.20.1