From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9ED6C04E53 for ; Wed, 15 May 2019 12:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81B1220657 for ; Wed, 15 May 2019 12:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922263; bh=NZk7Q8HWqSMvKNuUCzj9q5KAgh4kCTpC4hjYxmctfFs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xs26n1X8S6WEj9NO1VY/LDB0c6vZbmVlV+3FZg3nyziFuqG57Fvx4tN2dTMFNBYZV n0O/1FkaglBwpLM1AJ/smWwzTWiyk9q412AVRzsuzq28OHfB0D/OALjTG79wAL/uVu GGEQOibILr4ltWgXjHoiKdFnsauO4U2bGzgn7KYY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbfEOLGx (ORCPT ); Wed, 15 May 2019 07:06:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:37796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728788AbfEOLGr (ORCPT ); Wed, 15 May 2019 07:06:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8155B21743; Wed, 15 May 2019 11:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918407; bh=NZk7Q8HWqSMvKNuUCzj9q5KAgh4kCTpC4hjYxmctfFs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kt4875PUG78v+ZW+JUhRQ/XN+g6tIfPb0N+ctKckjghFMtcnzl6BhaNxjgRdPmlDb xYNW7Be05aVj3uzV0Ih7ZOHKtdLQmxhulyHu0tynaFHr3S4PhsMvEnG+Flc84+ODCa QYitVHtM7kZJaijltYtO7ZEFC2xZkIZKOrLZwRDc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Pirko , Hangbin Liu , "David S. Miller" Subject: [PATCH 4.4 076/266] team: fix possible recursive locking when add slaves Date: Wed, 15 May 2019 12:53:03 +0200 Message-Id: <20190515090725.008867622@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090722.696531131@linuxfoundation.org> References: <20190515090722.696531131@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hangbin Liu [ Upstream commit 925b0c841e066b488cc3a60272472b2c56300704 ] If we add a bond device which is already the master of the team interface, we will hold the team->lock in team_add_slave() first and then request the lock in team_set_mac_address() again. The functions are called like: - team_add_slave() - team_port_add() - team_port_enter() - team_modeop_port_enter() - __set_port_dev_addr() - dev_set_mac_address() - bond_set_mac_address() - dev_set_mac_address() - team_set_mac_address Although team_upper_dev_link() would check the upper devices but it is called too late. Fix it by adding a checking before processing the slave. v2: Do not split the string in netdev_err() Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device") Acked-by: Jiri Pirko Signed-off-by: Hangbin Liu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/team/team.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1136,6 +1136,12 @@ static int team_port_add(struct team *te return -EINVAL; } + if (netdev_has_upper_dev(dev, port_dev)) { + netdev_err(dev, "Device %s is already an upper device of the team interface\n", + portname); + return -EBUSY; + } + if (port_dev->features & NETIF_F_VLAN_CHALLENGED && vlan_uses_dev(dev)) { netdev_err(dev, "Device %s is VLAN challenged and team device has VLAN set up\n",