From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D69CC04E53 for ; Wed, 15 May 2019 12:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAB7320657 for ; Wed, 15 May 2019 12:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922072; bh=bo9yd0UhOWFKgWMME1z3sLKqkExmt0soqEeXTRFjdCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=s4MXbu0tYWgNIuLMdEZTTZIRlO4kuUqcXod7bb6U0YtkMIsfg6EE9CigpmjeoP8bH pIa8nZomIUXdygViDmSm/YqBndTjxC9LSpC58kxSD5ZSt65CLge2Au3sTPnTd+tI2N FXP4/LxGVL+UWeFUO05FHM9sTd8EH7AQLDT7VTYE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729541AbfEOMHv (ORCPT ); Wed, 15 May 2019 08:07:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:41752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728868AbfEOLJD (ORCPT ); Wed, 15 May 2019 07:09:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6860F21473; Wed, 15 May 2019 11:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918542; bh=bo9yd0UhOWFKgWMME1z3sLKqkExmt0soqEeXTRFjdCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fTZT2rigOx4c0nJEAoytp477DlFxHuMJs8DlVl53jmz7TEW4EuvBRsL014PulxIrn zHKZvmMYwhNZzfGGy8YJ/0m8TMBmX/IOqV5+iVZtIbCT6eHJoHYFfjBIiD7azrNQV2 +0+aTsPtSmh3oboPl+OOr2ZsgpLG0jxU0qhceW80= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Po-Hsu Lin , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 173/266] selftests/net: correct the return value for run_netsocktests Date: Wed, 15 May 2019 12:54:40 +0200 Message-Id: <20190515090728.774856831@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090722.696531131@linuxfoundation.org> References: <20190515090722.696531131@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ] The run_netsocktests will be marked as passed regardless the actual test result from the ./socket: selftests: net: run_netsocktests ======================================== -------------------- running socket test -------------------- [FAIL] ok 1..6 selftests: net: run_netsocktests [PASS] This is because the test script itself has been successfully executed. Fix this by exit 1 when the test failed. Signed-off-by: Po-Hsu Lin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- tools/testing/selftests/net/run_netsocktests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests index 16058bbea7a85..c195b44786627 100755 --- a/tools/testing/selftests/net/run_netsocktests +++ b/tools/testing/selftests/net/run_netsocktests @@ -6,7 +6,7 @@ echo "--------------------" ./socket if [ $? -ne 0 ]; then echo "[FAIL]" + exit 1 else echo "[PASS]" fi - -- 2.20.1