From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id BC4B11BF3D9 for ; Wed, 15 May 2019 11:14:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B8317860B0 for ; Wed, 15 May 2019 11:14:44 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxZsgfOaWy8V for ; Wed, 15 May 2019 11:14:40 +0000 (UTC) Received: from kadath.azazel.net (kadath.azazel.net [81.187.231.250]) by fraxinus.osuosl.org (Postfix) with ESMTPS id A1F808609D for ; Wed, 15 May 2019 11:14:40 +0000 (UTC) Received: from ulthar.dreamlands ([192.168.96.2]) by kadath.azazel.net with esmtp (Exim 4.89) (envelope-from ) id 1hQrrq-0003Fc-JN for driverdev-devel@linuxdriverproject.org; Wed, 15 May 2019 12:14:38 +0100 From: Jeremy Sowden Subject: [PATCH v2 3/5] staging: kpc2000: added designated initializers to two structs. Date: Wed, 15 May 2019 12:14:35 +0100 Message-Id: <20190515111437.18828-4-jeremy@azazel.net> In-Reply-To: <20190515111437.18828-1-jeremy@azazel.net> References: <20190515103454.18456-1-jeremy@azazel.net> <20190515111437.18828-1-jeremy@azazel.net> MIME-Version: 1.0 List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Linux Driver Project Developer List Fixed the following two sparse warnings by using designated initializers: drivers/staging/kpc2000/kpc2000/cell_probe.c:101:34: warning: Using plain integer as NULL pointer drivers/staging/kpc2000/kpc2000/cell_probe.c:364:34: warning: Using plain integer as NULL pointer Signed-off-by: Jeremy Sowden Reviewed-by: Dan Carpenter --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c index 30e6f176ddfa..b98d53c8637f 100644 --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c @@ -94,7 +94,7 @@ void parse_core_table_entry(struct core_table_entry *cte, const u64 read_val, co static int probe_core_basic(unsigned int core_num, struct kp2000_device *pcard, char *name, const struct core_table_entry cte) { - struct mfd_cell cell = {0}; + struct mfd_cell cell = { .id = core_num, .name = name }; struct resource resources[2]; struct kpc_core_device_platdata core_pdata = { @@ -110,8 +110,6 @@ static int probe_core_basic(unsigned int core_num, struct kp2000_device *pcard, cell.platform_data = &core_pdata; cell.pdata_size = sizeof(struct kpc_core_device_platdata); - cell.name = name; - cell.id = core_num; cell.num_resources = 2; memset(&resources, 0, sizeof(resources)); @@ -315,14 +313,13 @@ static int probe_core_uio(unsigned int core_num, struct kp2000_device *pcard, static int create_dma_engine_core(struct kp2000_device *pcard, size_t engine_regs_offset, int engine_num, int irq_num) { - struct mfd_cell cell = {0}; + struct mfd_cell cell = { .id = engine_num }; struct resource resources[2]; dev_dbg(&pcard->pdev->dev, "create_dma_core(pcard = [%p], engine_regs_offset = %zx, engine_num = %d)\n", pcard, engine_regs_offset, engine_num); cell.platform_data = NULL; cell.pdata_size = 0; - cell.id = engine_num; cell.name = KP_DRIVER_NAME_DMA_CONTROLLER; cell.num_resources = 2; -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel