From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: rt1308: Add RT1308 amplifier driver Date: Wed, 15 May 2019 17:14:29 +0100 Message-ID: <20190515161429.GH5613@sirena.org.uk> References: <20190416153510.GE4834@sirena.org.uk> <20190417150518.GB5703@sirena.org.uk> <20190508064537.GN14916@sirena.org.uk> <20190512080621.GH21483@sirena.org.uk> <20190513145608.GA5168@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1243662398697945326==" Return-path: Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [IPv6:2a01:7e01::f03c:91ff:fed4:a3b6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1FE6BF8078F for ; Wed, 15 May 2019 18:14:40 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Derek =?utf-8?B?W+aWueW+t+e+qV0=?= Cc: Oder Chiou , Jack Yu , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "lgirdwood@gmail.com" , Albert Chen , "bard.liao@intel.com" , Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= , "Flove(HsinFu)" List-Id: alsa-devel@alsa-project.org --===============1243662398697945326== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fmEUq8M7S0s+Fl0V" Content-Disposition: inline --fmEUq8M7S0s+Fl0V Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 14, 2019 at 11:10:58AM +0000, Derek [=E6=96=B9=E5=BE=B7=E7=BE= =A9] wrote: > I could remove comment for the limit setting in register patch/init list > to avoid users or integrators have any expectation. > And also there will not be any support at all the driver according to the > limit setting. It's better to have a comment than not have one, I think I'd be happier if I understood what was actually being limited here - that might make it clear why it's not system specific which is what's concerning me. --fmEUq8M7S0s+Fl0V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzcOuQACgkQJNaLcl1U h9DWAwf/ciMiFcz1L/yJG1WiGBUz97OFAkA6T4gEaKXBPFk6Eeqq3p+EZOBivc3e he+ivbc5nDda/iSLN4bbgGKfTxoOImo4XL8CrXoI/1FzOl+N0IuvdSgiL9eXfr2V 9jMGOeEmxKarAxKhqg2vupkZNpYfUT54YxsQ571cYc6ekRTjMUTCvi0xMNwguwx3 J/UOIe8I8DcPDCWxz4veJS+vTXfr89n7PlGqA9MJgeZR6OjV1yHrkyYWKcAY8l3B hzwGcR7A85DLTXvXo6FIHBD/gY68nJY1h2oTvnguUCYXJc2CX820YDiTaY3zjlk+ YRHPX/aVzIgLnl7M+zBoQlCG3wrYpg== =U5Xu -----END PGP SIGNATURE----- --fmEUq8M7S0s+Fl0V-- --===============1243662398697945326== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1243662398697945326==--