From: Eric Wong <e@80x24.org>
To: git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [WIP] repack leaving stale entries in objects/info/packs
Date: Wed, 15 May 2019 20:38:39 +0000 [thread overview]
Message-ID: <20190515203839.zixx23bwzeyto6a3@dcvr> (raw)
In-Reply-To: <20190515004551.emrxvboqemwnqh4g@dcvr>
I've also noticed objects/info/packs contains stale entries
after repack/gc runs on current git.
Tried adding reprepare_packed_git before update_server_info,
but that didn't seem to work; so maybe something isn't cleared.
Might have time to investigate more this week, might not...
diff --git a/builtin/repack.c b/builtin/repack.c
index 67f8978043..ec46f2099a 100644
--- a/builtin/repack.c
+++ b/builtin/repack.c
@@ -559,8 +559,10 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
prune_shallow(PRUNE_QUICK);
}
- if (!no_update_server_info)
+ if (!no_update_server_info) {
+ reprepare_packed_git(the_repository);
update_server_info(0);
+ }
remove_temporary_files();
if (git_env_bool(GIT_TEST_MULTI_PACK_INDEX, 0))
diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh
index 7411bf7fec..867d4fb0c7 100755
--- a/t/t6500-gc.sh
+++ b/t/t6500-gc.sh
@@ -71,6 +71,7 @@ test_expect_success 'gc --keep-largest-pack' '
git gc --keep-largest-pack &&
( cd .git/objects/pack && ls *.pack ) >pack-list &&
test_line_count = 2 pack-list &&
+ test_line_count = 2 .git/objects/info/packs &&
test_path_is_file $BASE_PACK &&
git fsck
)
next prev parent reply other threads:[~2019-05-15 20:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 1:34 [PATCH] update-server-info: avoid needless overwrites Eric Wong
2019-05-11 7:35 ` Eric Sunshine
2019-05-11 20:47 ` [PATCH v2] " Eric Wong
2019-05-11 21:17 ` [PATCH] " Eric Wong
2019-05-11 23:37 ` Ævar Arnfjörð Bjarmason
2019-05-12 0:38 ` Eric Wong
2019-05-12 4:08 ` Jeff King
2019-05-12 7:16 ` Ævar Arnfjörð Bjarmason
2019-05-14 9:47 ` Jeff King
2019-05-14 10:33 ` Ævar Arnfjörð Bjarmason
2019-05-14 11:24 ` Jeff King
2019-05-14 11:57 ` Ævar Arnfjörð Bjarmason
2019-05-14 11:50 ` Eric Wong
2019-05-14 12:13 ` dumb HTTP things I want to do Eric Wong
2019-05-14 12:27 ` Jeff King
2019-05-14 12:19 ` [PATCH] update-server-info: avoid needless overwrites Ævar Arnfjörð Bjarmason
2019-05-14 12:29 ` Jeff King
2019-05-15 0:45 ` [PATCH 2/1] server-info: conditionally update on fetch Eric Wong
2019-05-15 20:38 ` Eric Wong [this message]
2019-05-15 21:48 ` [WIP] repack leaving stale entries in objects/info/packs Jeff King
2019-05-23 8:59 ` [PATCH] server-info: do not list unlinked packs Eric Wong
2019-05-23 10:24 ` Jeff King
2019-05-23 17:27 ` [PATCH v2] " Eric Wong
2019-05-24 6:05 ` Jeff King
2019-05-24 7:34 ` Ævar Arnfjörð Bjarmason
2019-05-13 23:17 ` [PATCH v3] update-server-info: avoid needless overwrites Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515203839.zixx23bwzeyto6a3@dcvr \
--to=e@80x24.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--subject='Re: [WIP] repack leaving stale entries in objects/info/packs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.