From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8BCC04E87 for ; Thu, 16 May 2019 01:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2E2920873 for ; Thu, 16 May 2019 01:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bXMgsHQy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbfEPBqV (ORCPT ); Wed, 15 May 2019 21:46:21 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37216 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbfEOXl2 (ORCPT ); Wed, 15 May 2019 19:41:28 -0400 Received: by mail-pl1-f194.google.com with SMTP id p15so626778pll.4 for ; Wed, 15 May 2019 16:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZjzAq2AO1sRBqrHJUjIMR4JCd00dysDTYDWKUQqEjMQ=; b=bXMgsHQyNMU2fM0Ue9SNrNhQp2QCv7JSxc5jzX0IZmgsg2OidZNzsm8l3jUm1uE6nJ lWaqMUHtNuGJqztJtHFz8qq0mDt/CiCZpfad5s4Lar/0LSp9YNJ4LfCfOyPKjC1m6mz1 3ptuYCoxX+8Jb5kFkHkJRuLa8Cb48QvPHkyzvL/aOFptkBfoE1sfSG/DH75K0zkMGOCk UKLn1z8DM2/dwHP26TVmBpEDMUleMKoGHiO5SPFdigIH4tDV5uYGfhAUHlUkpBA9aeGT zfHAkEmYsHIQ8owAl5TDHSjfDoC//9ZGpi9UGnLUd1nHfq3vJ58bJ/rhc01P05NZBFF2 oyyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZjzAq2AO1sRBqrHJUjIMR4JCd00dysDTYDWKUQqEjMQ=; b=et6dwWeZappUIlVkiE/a2vFfKhOM3dMXXTat+RRmp8ZiIu1Eg5pZVzBmq5/WK2D1x0 8opM/tPUK19NCPCUsc2CT6SBgwD6EFruJokqNrInQfwcd6UF0MTNWmRAzYj0TvmoKAxa VFPlt/vRn8uM/98gY0TygUUrk4B6ClodPi09u7n9HBJo6f2M6AM3DOdPZYC3Yd7JLapX C4wZEqtftBjXyFSmEWGESefKPkiedk2uQdm3kuDg2qsO+xGHuAsKS1MbGA8xpxisq3KJ JVmQFaJgp4B8cndqSzjuyDPeyVUkzrFGsaClv4PDykJhUdiqjcsk//RNAXSR3m3gJr4n AEoA== X-Gm-Message-State: APjAAAWHW/HNArsHZKJgAbGa3dotv8KJlAGKBtSBhRY3qGxL5h+9+oRy yYRHrufDBNRbayS5Qy15dj25Wg== X-Google-Smtp-Source: APXvYqyRpmmXxhxDQ6tCx1u6g4+IFs/LWvWFlwdifLuOAObsUDyvgkOgAz2yesijZ/zlqJKH0WhsiQ== X-Received: by 2002:a17:902:2d03:: with SMTP id o3mr11064877plb.309.1557963687169; Wed, 15 May 2019 16:41:27 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g22sm4011790pfo.28.2019.05.15.16.41.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 16:41:25 -0700 (PDT) Date: Wed, 15 May 2019 16:41:23 -0700 From: Bjorn Andersson To: Doug Anderson Cc: Rob Clark , Rob Clark , linux-arm-msm , Stephen Boyd , Andy Gross , David Brown , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, LKML Subject: Re: [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory Message-ID: <20190515234123.GP31438@minitux> References: <20190509184415.11592-1-robdclark@gmail.com> <20190509184415.11592-3-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 15 May 14:50 PDT 2019, Doug Anderson wrote: > Hi, > > On Tue, May 14, 2019 at 9:10 PM Rob Clark wrote: > > > On Mon, May 13, 2019 at 3:48 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Thu, May 9, 2019 at 11:44 AM Rob Clark wrote: > > > > > > > From: Douglas Anderson > > > > > > > > Let's fixup the reserved memory to re-add the things we deleted in > > > > ("CHROMIUM: arm64: dts: qcom: sdm845-cheza: Temporarily delete > > > > reserved-mem changes") in a way that plays nicely with the new > > > > upstream definitions. > > > > > > The message above makes no sense since that commit you reference isn't > > > in upstream. > > > > > > ...but in any case, why not squash this in with the previous commit? > > > > Yeah, I should have mentioned this was my intention, I just left it > > unsquashed since (at the time) it was something I had cherry-picked on > > top of current 4.19 cros kernel.. > > > > anyways, I pushed an (unsquashed, converted to fixup!'s) update to: > > > > https://github.com/freedreno/kernel-msm/commits/wip/cheza-dtb-upstreaming > > > > which has updates based on you're review comments (at least assuming I > > understood them correctly).. plus some unrelated to cheza-dt patches > > on top to get things actually working (ie. ignore everything on top of > > the fixup!'s) > > Looks OK to me. Are you going to post this? Bjorn / Andy: do you > guys have opinions here? > I think this is a good opportunity to get people with Cheza off 4.19, so I'm all for landing this upstream. Regards, Bjorn > > > I didn't see any comments on the 'delete zap-shader' patch, so > > hopefully that means what I did there was a sane (or at least not > > insane) way to handle android/linux tz vs what we have on cheza? > > I wasn't CCed, so I assumed you were looking for feedback from others > on that one. ;-) Oh, but I guess Jordan and Bjorn also weren't > CCed... In any case, I replied now.