From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16427C04AB4 for ; Thu, 16 May 2019 05:16:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E630F20818 for ; Thu, 16 May 2019 05:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726486AbfEPFQp (ORCPT ); Thu, 16 May 2019 01:16:45 -0400 Received: from orcrist.hmeau.com ([5.180.42.13]:42954 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfEPFQp (ORCPT ); Thu, 16 May 2019 01:16:45 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hR8ku-00037D-Td; Thu, 16 May 2019 13:16:36 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hR8kh-0003Nn-3A; Thu, 16 May 2019 13:16:23 +0800 Date: Thu, 16 May 2019 13:16:23 +0800 From: Herbert Xu To: Jakub Kicinski Cc: davem@davemloft.net, tgraf@suug.ch, netdev@vger.kernel.org, oss-drivers@netronome.com, neilb@suse.com, Simon Horman Subject: Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer Message-ID: <20190516051622.b4x6hlkuevof4jzr@gondor.apana.org.au> References: <20190515205501.17810-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515205501.17810-1-jakub.kicinski@netronome.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 15, 2019 at 01:55:01PM -0700, Jakub Kicinski wrote: > Since the bit_spin_lock() operations don't actually dereference > the pointer, it's fine to forcefully drop the RCU annotation. > This fixes 7 sparse warnings per include site. > > Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash bucket.") > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman I don't think this is the right fix. We should remove the __rcu marker from the opaque type rhash_lock_head since it cannot be directly dereferenced. I'm working on a fix to this. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt