All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] gettext/flex/m4/bzip2/gzip/parted/slang/attr: Add make to -ptest packages
@ 2019-05-16 11:49 Richard Purdie
  2019-05-16 11:49 ` [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-05-16 11:49 UTC (permalink / raw)
  To: openembedded-core

This solves ptest runtime errors where make was missing causing the ptests
to fail.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/gettext/gettext_0.19.8.1.bb | 1 +
 meta/recipes-devtools/flex/flex_2.6.0.bb      | 2 +-
 meta/recipes-devtools/m4/m4-1.4.18.inc        | 2 ++
 meta/recipes-extended/bzip2/bzip2_1.0.6.bb    | 2 ++
 meta/recipes-extended/gzip/gzip_1.10.bb       | 2 ++
 meta/recipes-extended/parted/parted_3.2.bb    | 2 +-
 meta/recipes-extended/slang/slang_2.3.2.bb    | 2 ++
 meta/recipes-support/attr/attr.inc            | 2 +-
 8 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/gettext/gettext_0.19.8.1.bb b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
index 627568bc3f7..30121ad23e1 100644
--- a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
+++ b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
@@ -166,6 +166,7 @@ do_install_ptest() {
     fi
 }
 
+RDEPENDS_${PN}-ptest += "make"
 RDEPENDS_${PN}-ptest_append_libc-glibc = "\
     glibc-gconv-big5 \
     glibc-charmap-big5 \
diff --git a/meta/recipes-devtools/flex/flex_2.6.0.bb b/meta/recipes-devtools/flex/flex_2.6.0.bb
index b89b7515b56..b477cd8c7f2 100644
--- a/meta/recipes-devtools/flex/flex_2.6.0.bb
+++ b/meta/recipes-devtools/flex/flex_2.6.0.bb
@@ -48,7 +48,7 @@ PACKAGES =+ "${PN}-libfl"
 FILES_${PN}-libfl = "${libdir}/libfl.so.* ${libdir}/libfl_pic.so.*"
 
 RDEPENDS_${PN} += "m4"
-RDEPENDS_${PN}-ptest += "bash gawk"
+RDEPENDS_${PN}-ptest += "bash gawk make"
 
 do_compile_ptest() {
 	oe_runmake -C ${B}/tests -f ${B}/tests/Makefile top_builddir=${B} INCLUDES=-I${S}/src buildtests
diff --git a/meta/recipes-devtools/m4/m4-1.4.18.inc b/meta/recipes-devtools/m4/m4-1.4.18.inc
index f433b3f2dd0..af0ff45863c 100644
--- a/meta/recipes-devtools/m4/m4-1.4.18.inc
+++ b/meta/recipes-devtools/m4/m4-1.4.18.inc
@@ -52,6 +52,8 @@ do_install_ptest() {
                      ${D}${PTEST_PATH}/tests/test-xalloc-die
 }
 
+
+RDEPENDS_${PN}-ptest += "make"
 RDEPENDS_${PN}-ptest_append_libc-glibc = "\
      locale-base-fr-fr.iso-8859-1 \
 "
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.6.bb b/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
index 7d04e30d536..15a8e51550a 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
@@ -40,6 +40,8 @@ do_install_ptest () {
 
 FILES_libbz2 = "${libdir}/lib*${SOLIBS}"
 
+RDEPENDS_${PN}-ptest += "make"
+
 PROVIDES_append_class-native = " bzip2-replacement-native"
 BBCLASSEXTEND = "native nativesdk"
 
diff --git a/meta/recipes-extended/gzip/gzip_1.10.bb b/meta/recipes-extended/gzip/gzip_1.10.bb
index 75de9706310..6a5b2459e6d 100644
--- a/meta/recipes-extended/gzip/gzip_1.10.bb
+++ b/meta/recipes-extended/gzip/gzip_1.10.bb
@@ -12,6 +12,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
 
 PROVIDES_append_class-native = " gzip-replacement-native"
 
+RDEPENDS_${PN}-ptest += "make"
+
 BBCLASSEXTEND = "native"
 
 inherit ptest
diff --git a/meta/recipes-extended/parted/parted_3.2.bb b/meta/recipes-extended/parted/parted_3.2.bb
index 6189fd22465..ceac52892db 100644
--- a/meta/recipes-extended/parted/parted_3.2.bb
+++ b/meta/recipes-extended/parted/parted_3.2.bb
@@ -47,7 +47,7 @@ do_install_ptest() {
 	sed -e 's| ../parted||' -i $t/tests/*.sh
 }
 
-RDEPENDS_${PN}-ptest = "bash coreutils perl util-linux-losetup python3"
+RDEPENDS_${PN}-ptest = "bash coreutils perl util-linux-losetup python3 make"
 
 inherit update-alternatives
 
diff --git a/meta/recipes-extended/slang/slang_2.3.2.bb b/meta/recipes-extended/slang/slang_2.3.2.bb
index e53c4321b9a..e3293109379 100644
--- a/meta/recipes-extended/slang/slang_2.3.2.bb
+++ b/meta/recipes-extended/slang/slang_2.3.2.bb
@@ -75,6 +75,8 @@ do_install_ptest() {
 
 FILES_${PN} += "${libdir}/${BPN}/v2/modules/ ${datadir}/slsh/"
 
+RDEPENDS_${PN}-ptest += "make"
+
 PARALLEL_MAKE = ""
 PARALLEL_MAKEINST = ""
 
diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
index cfa38a71964..1a29eb339e7 100644
--- a/meta/recipes-support/attr/attr.inc
+++ b/meta/recipes-support/attr/attr.inc
@@ -41,6 +41,6 @@ do_install_ptest() {
 	sed -e 's|; @echo|; echo|' -i ${D}${PTEST_PATH}/test/Makefile
 }
 
-RDEPENDS_${PN}-ptest = "attr coreutils perl-module-filehandle perl-module-getopt-std perl-module-posix"
+RDEPENDS_${PN}-ptest = "attr coreutils perl-module-filehandle perl-module-getopt-std perl-module-posix make"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc
  2019-05-16 11:49 [PATCH 1/2] gettext/flex/m4/bzip2/gzip/parted/slang/attr: Add make to -ptest packages Richard Purdie
@ 2019-05-16 11:49 ` Richard Purdie
  2019-05-20 18:43   ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-05-16 11:49 UTC (permalink / raw)
  To: openembedded-core

Avoid:

libgcc_s.so.1 must be installed for pthread_cancel to work

when running the ptest without libgcc.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-support/apr/apr-util_1.6.1.bb | 1 +
 meta/recipes-support/apr/apr_1.7.0.bb      | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/meta/recipes-support/apr/apr-util_1.6.1.bb b/meta/recipes-support/apr/apr-util_1.6.1.bb
index 0c90f8d2527..1f9fea25d87 100644
--- a/meta/recipes-support/apr/apr-util_1.6.1.bb
+++ b/meta/recipes-support/apr/apr-util_1.6.1.bb
@@ -79,6 +79,7 @@ INSANE_SKIP_${PN} += "dev-so"
 inherit ptest
 
 RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-gconv-iso8859-1 glibc-gconv-iso8859-2 glibc-gconv-utf-7"
+RDEPENDS_${PN}-ptest += "libgcc"
 
 do_compile_ptest() {
 	cd ${B}/test
diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
index a58651d0774..09a65bfdd68 100644
--- a/meta/recipes-support/apr/apr_1.7.0.bb
+++ b/meta/recipes-support/apr/apr_1.7.0.bb
@@ -53,6 +53,8 @@ do_configure_prepend() {
 FILES_${PN}-dev += "${libdir}/apr.exp ${datadir}/build-1/*"
 RDEPENDS_${PN}-dev += "bash"
 
+RDEPENDS_${PN}-ptest += "libgcc"
+
 #for some reason, build/libtool.m4 handled by buildconf still be overwritten
 #when autoconf, so handle it again.
 do_configure_append() {
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc
  2019-05-16 11:49 ` [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc Richard Purdie
@ 2019-05-20 18:43   ` Khem Raj
  2019-05-20 18:57     ` Andre McCurdy
  2019-05-21 12:28     ` richard.purdie
  0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2019-05-20 18:43 UTC (permalink / raw)
  To: Richard Purdie, openembedded-core



On 5/16/19 4:49 AM, Richard Purdie wrote:
> Avoid:
> 
> libgcc_s.so.1 must be installed for pthread_cancel to work
> 
> when running the ptest without libgcc.
> 


this is interesting, do we get this error explicitly from running some 
tests ?

I wonder why libgcc is not detected during rdep calculation time.

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-support/apr/apr-util_1.6.1.bb | 1 +
>   meta/recipes-support/apr/apr_1.7.0.bb      | 2 ++
>   2 files changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-support/apr/apr-util_1.6.1.bb b/meta/recipes-support/apr/apr-util_1.6.1.bb
> index 0c90f8d2527..1f9fea25d87 100644
> --- a/meta/recipes-support/apr/apr-util_1.6.1.bb
> +++ b/meta/recipes-support/apr/apr-util_1.6.1.bb
> @@ -79,6 +79,7 @@ INSANE_SKIP_${PN} += "dev-so"
>   inherit ptest
>   
>   RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-gconv-iso8859-1 glibc-gconv-iso8859-2 glibc-gconv-utf-7"
> +RDEPENDS_${PN}-ptest += "libgcc"
>   
>   do_compile_ptest() {
>   	cd ${B}/test
> diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
> index a58651d0774..09a65bfdd68 100644
> --- a/meta/recipes-support/apr/apr_1.7.0.bb
> +++ b/meta/recipes-support/apr/apr_1.7.0.bb
> @@ -53,6 +53,8 @@ do_configure_prepend() {
>   FILES_${PN}-dev += "${libdir}/apr.exp ${datadir}/build-1/*"
>   RDEPENDS_${PN}-dev += "bash"
>   
> +RDEPENDS_${PN}-ptest += "libgcc"
> +
>   #for some reason, build/libtool.m4 handled by buildconf still be overwritten
>   #when autoconf, so handle it again.
>   do_configure_append() {
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc
  2019-05-20 18:43   ` Khem Raj
@ 2019-05-20 18:57     ` Andre McCurdy
  2019-05-21 12:28     ` richard.purdie
  1 sibling, 0 replies; 6+ messages in thread
From: Andre McCurdy @ 2019-05-20 18:57 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Mon, May 20, 2019 at 11:43 AM Khem Raj <raj.khem@gmail.com> wrote:
> On 5/16/19 4:49 AM, Richard Purdie wrote:
> > Avoid:
> >
> > libgcc_s.so.1 must be installed for pthread_cancel to work
> >
> > when running the ptest without libgcc.
>
> this is interesting, do we get this error explicitly from running some
> tests ?
>
> I wonder why libgcc is not detected during rdep calculation time.

Other questions... why does it only affect ptest and not other use
cases? Is calling dlopen() on libgcc glibc specific? If so, perhaps a
better fix would be to add the rdep to the glibc pthreads library?

> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >   meta/recipes-support/apr/apr-util_1.6.1.bb | 1 +
> >   meta/recipes-support/apr/apr_1.7.0.bb      | 2 ++
> >   2 files changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-support/apr/apr-util_1.6.1.bb b/meta/recipes-support/apr/apr-util_1.6.1.bb
> > index 0c90f8d2527..1f9fea25d87 100644
> > --- a/meta/recipes-support/apr/apr-util_1.6.1.bb
> > +++ b/meta/recipes-support/apr/apr-util_1.6.1.bb
> > @@ -79,6 +79,7 @@ INSANE_SKIP_${PN} += "dev-so"
> >   inherit ptest
> >
> >   RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-gconv-iso8859-1 glibc-gconv-iso8859-2 glibc-gconv-utf-7"
> > +RDEPENDS_${PN}-ptest += "libgcc"
> >
> >   do_compile_ptest() {
> >       cd ${B}/test
> > diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
> > index a58651d0774..09a65bfdd68 100644
> > --- a/meta/recipes-support/apr/apr_1.7.0.bb
> > +++ b/meta/recipes-support/apr/apr_1.7.0.bb
> > @@ -53,6 +53,8 @@ do_configure_prepend() {
> >   FILES_${PN}-dev += "${libdir}/apr.exp ${datadir}/build-1/*"
> >   RDEPENDS_${PN}-dev += "bash"
> >
> > +RDEPENDS_${PN}-ptest += "libgcc"
> > +
> >   #for some reason, build/libtool.m4 handled by buildconf still be overwritten
> >   #when autoconf, so handle it again.
> >   do_configure_append() {
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc
  2019-05-20 18:43   ` Khem Raj
  2019-05-20 18:57     ` Andre McCurdy
@ 2019-05-21 12:28     ` richard.purdie
  2019-05-21 17:25       ` Khem Raj
  1 sibling, 1 reply; 6+ messages in thread
From: richard.purdie @ 2019-05-21 12:28 UTC (permalink / raw)
  To: Khem Raj, openembedded-core

On Mon, 2019-05-20 at 11:43 -0700, Khem Raj wrote:
> 
> On 5/16/19 4:49 AM, Richard Purdie wrote:
> > Avoid:
> > 
> > libgcc_s.so.1 must be installed for pthread_cancel to work
> > 
> > when running the ptest without libgcc.
> > 
> 
> this is interesting, do we get this error explicitly from running
> some 
> tests ?
> 
> I wonder why libgcc is not detected during rdep calculation time.

pthread_cancel doesn't directly link to anything in libgcc so there
isn't a dependency for the rdep calculations to find.

Ross has a work in progress where we'd notice binaries using
pthread_cancel and automatically add a libgcc dependency but its not
ready yet.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc
  2019-05-21 12:28     ` richard.purdie
@ 2019-05-21 17:25       ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2019-05-21 17:25 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer

On Tue, May 21, 2019 at 5:29 AM <richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2019-05-20 at 11:43 -0700, Khem Raj wrote:
> >
> > On 5/16/19 4:49 AM, Richard Purdie wrote:
> > > Avoid:
> > >
> > > libgcc_s.so.1 must be installed for pthread_cancel to work
> > >
> > > when running the ptest without libgcc.
> > >
> >
> > this is interesting, do we get this error explicitly from running
> > some
> > tests ?
> >
> > I wonder why libgcc is not detected during rdep calculation time.
>
> pthread_cancel doesn't directly link to anything in libgcc so there
> isn't a dependency for the rdep calculations to find.
>
> Ross has a work in progress where we'd notice binaries using
> pthread_cancel and automatically add a libgcc dependency but its not
> ready yet.
>

are we running into this case
https://bugs.launchpad.net/ubuntu/+source/gcc-3.3/+bug/40285/comments/30

> Cheers,
>
> Richard
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-05-21 17:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 11:49 [PATCH 1/2] gettext/flex/m4/bzip2/gzip/parted/slang/attr: Add make to -ptest packages Richard Purdie
2019-05-16 11:49 ` [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc Richard Purdie
2019-05-20 18:43   ` Khem Raj
2019-05-20 18:57     ` Andre McCurdy
2019-05-21 12:28     ` richard.purdie
2019-05-21 17:25       ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.