From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector Date: Thu, 16 May 2019 15:07:32 +0200 Message-ID: <20190516130732.GA12435@ravnborg.org> References: <20190506180139.6913-1-noralf@tronnes.org> <20190506180139.6913-9-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190506180139.6913-9-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLgoKU2VlIGZldyBjb21tZW50cyBpbiB0aGUgZm9sbG93aW5nLgoKCVNhbQoKT24g TW9uLCBNYXkgMDYsIDIwMTkgYXQgMDg6MDE6MzZQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVzIHdy b3RlOgo+IEFsbCBkcml2ZXJzIGFkZCBhbGwgdGhlaXIgY29ubmVjdG9ycyBzbyB0aGVyZSdzIG5v IG5lZWQgdG8ga2VlcCBhcm91bmQgYW4KPiBhcnJheSBvZiBhdmFpbGFibGUgY29ubmVjdG9ycy4K PiAKPiBSZW5hbWUgZnVuY3Rpb25zIHdoaWNoIHNpZ25hdHVyZSBpcyBjaGFuZ2VkIHNpbmNlIHRo ZXkgd2lsbCBiZSBtb3ZlZCB0bwo+IGRybV9jbGllbnQgaW4gYSBsYXRlciBwYXRjaC4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0K PiBAQCAtMTY0NSw4ICsxNDYxLDkgQEAgc3RhdGljIGludCBkcm1fZmJfaGVscGVyX3NpbmdsZV9m Yl9wcm9iZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJc3RydWN0IGRybV9j bGllbnRfZGV2ICpjbGllbnQgPSAmZmJfaGVscGVyLT5jbGllbnQ7Cj4gIAlpbnQgcmV0ID0gMDsK PiAgCWludCBjcnRjX2NvdW50ID0gMDsKPiAtCWludCBpOwo+ICsJc3RydWN0IGRybV9jb25uZWN0 b3JfbGlzdF9pdGVyIGNvbm5faXRlcjsKPiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZhY2Vf c2l6ZSBzaXplczsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gIAlzdHJ1 Y3QgZHJtX21vZGVfc2V0ICptb2RlX3NldDsKPiAgCWludCBiZXN0X2RlcHRoID0gMDsKPiAgCj4g QEAgLTE2NjMsMTEgKzE0ODAsMTEgQEAgc3RhdGljIGludCBkcm1fZmJfaGVscGVyX3NpbmdsZV9m Yl9wcm9iZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJaWYgKHByZWZlcnJl ZF9icHAgIT0gc2l6ZXMuc3VyZmFjZV9icHApCj4gIAkJc2l6ZXMuc3VyZmFjZV9kZXB0aCA9IHNp emVzLnN1cmZhY2VfYnBwID0gcHJlZmVycmVkX2JwcDsKPiAgCj4gLQlkcm1fZmJfaGVscGVyX2Zv cl9lYWNoX2Nvbm5lY3RvcihmYl9oZWxwZXIsIGkpIHsKPiAtCQlzdHJ1Y3QgZHJtX2ZiX2hlbHBl cl9jb25uZWN0b3IgKmZiX2hlbHBlcl9jb25uID0gZmJfaGVscGVyLT5jb25uZWN0b3JfaW5mb1tp XTsKPiArCWRybV9jb25uZWN0b3JfbGlzdF9pdGVyX2JlZ2luKGZiX2hlbHBlci0+ZGV2LCAmY29u bl9pdGVyKTsKPiArCWRybV9jbGllbnRfZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29ubmVjdG9y LCAmY29ubl9pdGVyKSB7Cj4gIAkJc3RydWN0IGRybV9jbWRsaW5lX21vZGUgKmNtZGxpbmVfbW9k ZTsKCkkgZmFpbCB0byBzZWUgd2hlbiB0byB1c2UgZHJtX2NsaWVudF9mb3JfZWFjaF9jb25uZWN0 b3JfaXRlcigpIGFuZCB3aGVuCnRvIHVzZSBhIHNpbXBsZSBmb3IgbG9vcC4KSW4gdGhpcyBwYXRj aCBkcm1fZmJfaGVscGVyX2Zvcl9lYWNoX2Nvbm5lY3RvcigpIGlzIGhlcmUgcmVwbGFjZWQgYnkg dGhlCml0ZXJhdG9yIHZhcmlhbnQgYW5kIGluIG1hbnkgb3RoZXIgcGxhY2VkIGEgc2ltcGxlIGZv ciBsb29wLgoKVGhlIG9sZCBjb2RlLCBpbiB0aGlzIHBsYWNlLCB3b3VsZCBnbyB0aHJvdWdoIGFs bCBjb25uZWN0b3JzLCBidXQgdGhpcwpjb2RlIHdpbGwgc2tpcCAJRFJNX01PREVfQ09OTkVDVE9S X1dSSVRFQkFDSyBjb25lY3RvcnMuClNvIGl0IGRvZXMgbm90IGxpa2UgaWRlbnRpY2FsIGNvZGUu Cgo+ICAKPiAtCQljbWRsaW5lX21vZGUgPSAmZmJfaGVscGVyX2Nvbm4tPmNvbm5lY3Rvci0+Y21k bGluZV9tb2RlOwo+ICsJCWNtZGxpbmVfbW9kZSA9ICZjb25uZWN0b3ItPmNtZGxpbmVfbW9kZTsK PiAgCj4gIAkJaWYgKGNtZGxpbmVfbW9kZS0+YnBwX3NwZWNpZmllZCkgewo+ICAJCQlzd2l0Y2gg KGNtZGxpbmVfbW9kZS0+YnBwKSB7Cj4gQEAgLTE2OTIsNiArMTUwOSw3IEBAIHN0YXRpYyBpbnQg ZHJtX2ZiX2hlbHBlcl9zaW5nbGVfZmJfcHJvYmUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hl bHBlciwKPiAgCQkJYnJlYWs7Cj4gIAkJfQo+ICAJfQo+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0 ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ICAKPiAgCS8qCj4gIAkgKiBJZiB3ZSBydW4gaW50byBhIHNp dHVhdGlvbiB3aGVyZSwgZm9yIGV4YW1wbGUsIHRoZSBwcmltYXJ5IHBsYW5lCj4gQEAgLTE4NzYs MjYgKzE2OTQsMTIgQEAgdm9pZCBkcm1fZmJfaGVscGVyX2ZpbGxfaW5mbyhzdHJ1Y3QgZmJfaW5m byAqaW5mbywKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfZmlsbF9pbmZvKTsK PiAgCj4gK3N0YXRpYyB2b2lkIGRybV9jbGllbnRfY29ubmVjdG9yc19lbmFibGVkKHN0cnVjdCBk cm1fY29ubmVjdG9yICoqY29ubmVjdG9ycywKPiArCQkJCQkgIHVuc2lnbmVkIGludCBjb25uZWN0 b3JfY291bnQsCj4gKwkJCQkJICBib29sICplbmFibGVkKQo+ICB7Cj4gIAlib29sIGFueV9lbmFi bGVkID0gZmFsc2U7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJaW50 IGkgPSAwOwo+ICAKPiAtCWRybV9mYl9oZWxwZXJfZm9yX2VhY2hfY29ubmVjdG9yKGZiX2hlbHBl ciwgaSkgewo+IC0JCWNvbm5lY3RvciA9IGZiX2hlbHBlci0+Y29ubmVjdG9yX2luZm9baV0tPmNv bm5lY3RvcjsKPiArCWZvciAoaSA9IDA7IGkgPCBjb25uZWN0b3JfY291bnQ7IGkrKykgewo+ICsJ CWNvbm5lY3RvciA9IGNvbm5lY3RvcnNbaV07ClRoaXMgaXMgZm9yIGV4YW1wbGUgYSBwbGFjZSB3 aGVyZSB0aGUgZHJtX2ZiX2hlbHBlcl9mb3JfZWFjaF9jb25uZWN0b3IoKQppcyByZXBsYWNlZCBi eSBhIHNpbXBsZSBmb3IgbG9vcC4KVGhlIHNpbXBsZSBmb3IgbG9vcCBpcyBuaWNlIGFuZCByZWFk YWJsZSAtIGp1c3QgYSBjb21tZW50IHJlcGxhdGVkIHRvCnRoZSBhYm92ZSBjb21tZW50LgoKPiAg CQlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9IG1vZGVzW2ldOwo+ICAJCXN0cnVjdCBk cm1fY3J0YyAqY3J0YyA9IGNydGNzW2ldOwo+ICAJCXN0cnVjdCBkcm1fZmJfb2Zmc2V0ICpvZmZz ZXQgPSAmb2Zmc2V0c1tpXTsKPiAgCj4gIAkJaWYgKG1vZGUgJiYgY3J0Yykgewo+ICAJCQlzdHJ1 Y3QgZHJtX21vZGVfc2V0ICptb2Rlc2V0ID0gZHJtX2NsaWVudF9maW5kX21vZGVzZXQoY2xpZW50 LCBjcnRjKTsKPiAtCQkJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciA9Cj4gLQkJCQlm Yl9oZWxwZXItPmNvbm5lY3Rvcl9pbmZvW2ldLT5jb25uZWN0b3I7Cj4gKwkJCXN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IgPSBjb25uZWN0b3JzW2ldOwo+ICAKPiAgCQkJRFJNX0RFQlVH X0tNUygiZGVzaXJlZCBtb2RlICVzIHNldCBvbiBjcnRjICVkICglZCwlZClcbiIsCj4gIAkJCQkg ICAgICBtb2RlLT5uYW1lLCBjcnRjLT5iYXNlLmlkLCBvZmZzZXQtPngsIG9mZnNldC0+eSk7Cj4g QEAgLTI1MzksNiArMjM1NCwxMCBAQCBzdGF0aWMgdm9pZCBkcm1fc2V0dXBfY3J0Y3Moc3RydWN0 IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCWtmcmVlKG1vZGVzKTsKPiAgCWtmcmVlKG9m ZnNldHMpOwo+ICAJa2ZyZWUoZW5hYmxlZCk7Cj4gK2ZyZWVfY29ubmVjdG9yczoKPiArCWZvciAo aSA9IDA7IGkgPCBjb25uZWN0b3JfY291bnQ7IGkrKykKPiArCQlkcm1fY29ubmVjdG9yX3B1dChj b25uZWN0b3JzW2ldKTsKVGhpcyBtYXkgY2FsbCBkcm1fY29ubmVjdG9yX3B1dChOVUxMKSBhcyBu b3QgYWxsIGNvbm5lY3RvcnMgYXJlIGluaXQuCgo+ICsJa2ZyZWUoY29ubmVjdG9ycyk7Cj4gIH0K PiAgCj4gIC8qCj4gQEAgLTI1NTEsMTAgKzIzNzAsMTEgQEAgc3RhdGljIHZvaWQgZHJtX3NldHVw X2NydGNzKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gIHN0YXRpYyB2b2lkIGRy bV9zZXR1cF9jcnRjc19mYihzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCA9ICZmYl9oZWxwZXItPmNsaWVudDsKPiAr CXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7Cj4gIAlzdHJ1Y3QgZmJf aW5mbyAqaW5mbyA9IGZiX2hlbHBlci0+ZmJkZXY7Cj4gIAl1bnNpZ25lZCBpbnQgcm90YXRpb24s IHN3X3JvdGF0aW9ucyA9IDA7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ ICAJc3RydWN0IGRybV9tb2RlX3NldCAqbW9kZXNldDsKPiAtCWludCBpOwo+ICAKPiAgCW11dGV4 X2xvY2soJmNsaWVudC0+bW9kZXNldF9tdXRleCk7Cj4gIAlkcm1fY2xpZW50X2Zvcl9lYWNoX21v ZGVzZXQobW9kZXNldCwgY2xpZW50KSB7Cj4gQEAgLTI1NzEsMTAgKzIzOTEsOCBAQCBzdGF0aWMg dm9pZCBkcm1fc2V0dXBfY3J0Y3NfZmIoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikK PiAgCX0KPiAgCW11dGV4X3VubG9jaygmY2xpZW50LT5tb2Rlc2V0X211dGV4KTsKPiAgCj4gLQlt dXRleF9sb2NrKCZmYl9oZWxwZXItPmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwpXaHkgaXMgaXQg T0sgdG8gZHJvcCB0aGlzIGxvY2s/CkluIGdlbmVyYWwgSSBmYWlsIHRvIHNlZSBob3cgdGhlIGNv bm5lY3RvciBkYXRhIGlzIHByb3RlY3RlZCAobG9ja2luZwpydWxlcz8pIFRoaXMgaXMgbGlrZWx5 IGp1c3QgbWUgbWlzc2luZyB0aGUgYmlnZ2VyIHBpY3R1cmUgaGVyZS4uCgo+ICsJZHJtX2Nvbm5l Y3Rvcl9saXN0X2l0ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ICAKPiAgCXN3aXRjaCAoc3dfcm90YXRp b25zKSB7Cj4gIAljYXNlIERSTV9NT0RFX1JPVEFURV8wOgoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVk ZS9kcm0vZHJtX2NsaWVudC5oIGIvaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oCj4gaW5kZXggNmNm NDg0MTlmNzdmLi44ZDk0ODgwYmJlMjUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2Ns aWVudC5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2NsaWVudC5oCj4gQEAgLTcsNiArNyw3IEBA Cj4gICNpbmNsdWRlIDxsaW51eC9tdXRleC5oPgo+ICAjaW5jbHVkZSA8bGludXgvdHlwZXMuaD4K PiAgCj4gKyNpbmNsdWRlIDxkcm0vZHJtX2Nvbm5lY3Rvci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2Ry bV9jcnRjLmg+Cj4gIAo+ICBzdHJ1Y3QgZHJtX2NsaWVudF9kZXY7Cj4gQEAgLTE2OSw2ICsxNzAs MjAgQEAgaW50IGRybV9jbGllbnRfbW9kZXNldF9kcG1zKHN0cnVjdCBkcm1fY2xpZW50X2RldiAq Y2xpZW50LCBpbnQgbW9kZSk7Cj4gIAlmb3IgKCh7IGxvY2tkZXBfYXNzZXJ0X2hlbGQoJihjbGll bnQpLT5tb2Rlc2V0X211dGV4KTsgfSksIFwKPiAgCSAgICAgbW9kZXNldCA9IChjbGllbnQpLT5t b2Rlc2V0czsgbW9kZXNldC0+Y3J0YzsgbW9kZXNldCsrKQo+ICAKPiArLyoqCj4gKyAqIGRybV9j bGllbnRfZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIgLSBjb25uZWN0b3JfbGlzdCBpdGVyYXRvciBt YWNybwo+ICsgKiBAY29ubmVjdG9yOiAmc3RydWN0IGRybV9jb25uZWN0b3IgcG9pbnRlciB1c2Vk IGFzIGN1cnNvcgo+ICsgKiBAaXRlcjogJnN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlcgo+ ICsgKgo+ICsgKiBUaGlzIGl0ZXJhdGVzIHRoZSBjb25uZWN0b3JzIHRoYXQgYXJlIHVzZWFibGUg Zm9yIGludGVybmFsIGNsaWVudHMgKGV4Y2x1ZGVzCj4gKyAqIHdyaXRlYmFjayBjb25uZWN0b3Jz KS4KPiArICoKPiArICogRm9yIG1vcmUgaW5mbyBzZWUgZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcl9p dGVyKCkuCj4gKyAqLwo+ICsjZGVmaW5lIGRybV9jbGllbnRfZm9yX2VhY2hfY29ubmVjdG9yX2l0 ZXIoY29ubmVjdG9yLCBpdGVyKSBcCj4gKwlkcm1fZm9yX2VhY2hfY29ubmVjdG9yX2l0ZXIoY29u bmVjdG9yLCBpdGVyKSBcCj4gKwkJaWYgKGNvbm5lY3Rvci0+Y29ubmVjdG9yX3R5cGUgIT0gRFJN X01PREVfQ09OTkVDVE9SX1dSSVRFQkFDSykKPiArCj4gIGludCBkcm1fY2xpZW50X2RlYnVnZnNf aW5pdChzdHJ1Y3QgZHJtX21pbm9yICptaW5vcik7Cj4gIAo+ICAjZW5kaWYKPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBl ci5oCj4gaW5kZXggNmIzMzRmNGQ4YTIyLi5lMTRkNTJlZjk2MzggMTAwNjQ0Cj4gLS0tIGEvaW5j bHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBl ci5oCj4gQEAgLTk3LDE2ICs5NywxMCBAQCBzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9mdW5jcyB7Cj4g IAkJCXN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZhY2Vfc2l6ZSAqc2l6ZXMpOwo+ICB9Owo+ICAK PiAtc3RydWN0IGRybV9mYl9oZWxwZXJfY29ubmVjdG9yIHsKPiAtCXN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3I7Cj4gLX07Cj4gLQo+ICAvKioKPiAgICogc3RydWN0IGRybV9mYl9oZWxw ZXIgLSBtYWluIHN0cnVjdHVyZSB0byBlbXVsYXRlIGZiZGV2IG9uIHRvcCBvZiBLTVMKPiAgICog QGZiOiBTY2Fub3V0IGZyYW1lYnVmZmVyIG9iamVjdAo+ICAgKiBAZGV2OiBEUk0gZGV2aWNlCj4g LSAqIEBjb25uZWN0b3JfY291bnQ6IG51bWJlciBvZiBjb25uZWN0ZWQgY29ubmVjdG9ycwo+IC0g KiBAY29ubmVjdG9yX2luZm9fYWxsb2NfY291bnQ6IHNpemUgb2YgY29ubmVjdG9yX2luZm8KPiAg ICogQGZ1bmNzOiBkcml2ZXIgY2FsbGJhY2tzIGZvciBmYiBoZWxwZXIKPiAgICogQGZiZGV2OiBl bXVsYXRlZCBmYmRldiBkZXZpY2UgaW5mbyBzdHJ1Y3QKPiAgICogQHBzZXVkb19wYWxldHRlOiBm YWtlIHBhbGV0dGUgb2YgMTYgY29sb3JzCj4gQEAgLTEzOCwxNSArMTMyLDYgQEAgc3RydWN0IGRy bV9mYl9oZWxwZXIgewo+ICAKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRldjsKPiAtCWludCBjb25uZWN0b3JfY291bnQ7Cj4gLQlpbnQgY29u bmVjdG9yX2luZm9fYWxsb2NfY291bnQ7Cj4gLQkvKioKPiAtCSAqIEBjb25uZWN0b3JfaW5mbzoK PiAtCSAqCj4gLQkgKiBBcnJheSBvZiBwZXItY29ubmVjdG9yIGluZm9ybWF0aW9uLiBEbyBub3Qg aXRlcmF0ZSBkaXJlY3RseSwgYnV0IHVzZQo+IC0JICogZHJtX2ZiX2hlbHBlcl9mb3JfZWFjaF9j b25uZWN0b3IuCj4gLQkgKi8KPiAtCXN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqKmNv bm5lY3Rvcl9pbmZvOwoKQXMgd2UgYXJlIHJlbW92aW5nIGNvbm5lY3Rvcl9pbmZvIHRoZSBjb21t ZW50IGZvciB0aGUgQGxvY2sgbWVtYmVyCnNob3VsZCBiZSBhZGp1c3RlZCBub3QgdG8gbWVudGlv biBjb25uZWN0b3JfaW5mby4KCgo+ICAJY29uc3Qgc3RydWN0IGRybV9mYl9oZWxwZXJfZnVuY3Mg KmZ1bmNzOwo+ICAJc3RydWN0IGZiX2luZm8gKmZiZGV2Owo+ICAJdTMyIHBzZXVkb19wYWxldHRl WzE3XTsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4