[Buildroot] [PATCH 1/1] package/busybox: select individual libraries when selecting SELinux support.

[Buildroot] [PATCH 1/1] package/busybox: select individual libraries when selecting SELinux support.

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

From the help test of individual binaries:

With this option enabled, each applet is a separate binary, which is needed for
proper operation with SELinux

As such, it only makes sense to select this option when SELinux support is
selected as well.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/busybox/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/busybox/Config.in b/package/busybox/Config.in
index e5c5f89a4d..bab00bf835 100644
--- a/package/busybox/Config.in
+++ b/package/busybox/Config.in
@@ -42,6 +42,7 @@ config BR2_PACKAGE_BUSYBOX_SELINUX
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on !BR2_arc
+	select BR2_PACKAGE_BUSYBOX_INDIVIDUAL_BINARIES
 	select BR2_PACKAGE_LIBSELINUX
 	help
 	  Enable SELinux support in BusyBox. Please note that
-- 
2.21.0

[Buildroot] [PATCH 1/1] package/busybox: select individual libraries when selecting SELinux support.

[Thomas Petazzoni]

Hello,

On Thu, 16 May 2019 11:52:00 -0400
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> From the help test of individual binaries:
> 
> With this option enabled, each applet is a separate binary, which is needed for
> proper operation with SELinux
> 
> As such, it only makes sense to select this option when SELinux support is
> selected as well.

The wording here is a bit unfortunate, as one could read this as if you
had added a "depends on BR2_PACKAGE_BUSYBOX_SELINUX" to
"BR2_PACKAGE_BUSYBOX_INDIVIDUAL_BINARIES", so that "individual
binaries" can only be used with SELinux.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/busybox: select individual libraries when selecting SELinux support.

[Thomas Petazzoni]

Hello Adam,

On Thu, 16 May 2019 11:52:00 -0400
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> From the help test of individual binaries:
> 
> With this option enabled, each applet is a separate binary, which is needed for
> proper operation with SELinux
> 
> As such, it only makes sense to select this option when SELinux support is
> selected as well.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/busybox/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to next, after slightly tweaking the commit log to reduce the
confusion it was causing IMO.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com