All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: keerthy <j-keerthy@ti.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, t-kristo@ti.com
Subject: Re: [PATCH 2/2] arm: dts: dra76-evm: Disable rtc target module
Date: Thu, 16 May 2019 09:47:30 -0700	[thread overview]
Message-ID: <20190516164729.GC5447@atomide.com> (raw)
In-Reply-To: <f3c2a6cd-b478-cec4-cde6-3eb5b6a11392@ti.com>

* keerthy <j-keerthy@ti.com> [190516 16:31]:
> 
> 
> On 5/16/2019 9:42 PM, Tony Lindgren wrote:
> > Hi,
> > 
> > * Keerthy <j-keerthy@ti.com> [190516 09:06]:
> > > rtc is fused out on dra76 and accessing target module
> > > register is causing a boot crash hence disable it.
> > 
> > So for a fix, can we have a separate dra7 something dtsi file
> > to disable these instead?
> > 
> > Or are there already multiple SoC revisions for the same EVM?
> 
> dra76 & dra71 have rtc fused out. So i did not introduce a new dtsi file
> to disable.

But then any new board with dra76 or dra71 will need to debug
the same issue again. Sure we can get away for now tweaking the
board file, but to me it sounds like it's going to be more
devices that will be affected too?

Is there some feature matrix available somewhere online?

> > Then in the long run, if there are the same EVMs with multiple
> > SoC options, the best thing to do is to would be to detect the
> > SoC type and update the property dynamically to set the features
> > not available on the booted SoC to status = "disabled". Seems
> > like that could be done in the ti-sysc driver probe unless needed
> > earlier.
> 
> For now rtc is disabled only in dra71/dra76. So best disable it in the
> evm.dts? Not sure if we need dynamic disabling as we know at DT level that
> it is to be disabled.

Well the thing is we should make introducing new board dts files
as easy as including the SoC dtsi file and with that it should
boot with no extra debugging.

How about add minimal dra76 and dra71 dtsi files in addition to
the board specific fix(es)? Then for v5.3, we can deal adding more
dra7 specifc evm files using these dtsi files or dynamically start
disabling modules.

Regards,

Tony

  reply	other threads:[~2019-05-16 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  9:06 [PATCH 1/2] arm: dts: dra76-evm: Disable usb4_tm target module Keerthy
2019-05-16  9:06 ` [PATCH 2/2] arm: dts: dra76-evm: Disable rtc " Keerthy
2019-05-16 16:12   ` Tony Lindgren
2019-05-16 16:31     ` keerthy
2019-05-16 16:47       ` Tony Lindgren [this message]
2019-05-16 16:54         ` keerthy
2019-05-16 16:58           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516164729.GC5447@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.