All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/wpewebkit: bump to version 2.24.1
Date: Thu, 16 May 2019 21:07:03 +0200	[thread overview]
Message-ID: <20190516190703.GC2441@scaer> (raw)
In-Reply-To: <20190516001516.GB4444@momiji>

Adrian, All,

On 2019-05-16 00:15 +0300, Adrian Perez de Castro spake thusly:
> On Wed, 15 May 2019 21:53:34 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > On 2019-05-15 21:11 +0300, Adrian Perez de Castro spake thusly:
> > Well, as you said previously, what good is a browser without support for
> > one of the most prominent image format on the web?
> > But please note that openjpeg is a JPEG 2000 codec, not a JPEG one.
> > JPEG 2000 is much less used on the web:
> >     https://en.wikipedia.org/wiki/Comparison_of_web_browsers#Image_format_support
> > Only Konqueror, Midori, Omniweb, and Safari are said to support it.
> 
> ?and now WebKitGTK, and WPE WebKit :)
> 
> With my WebKit maintainer hat on, let me tell you a short story.

/me sits by the fire and listens carefully to stories from the
trenches... :-)

> We have been forced to add support for JPEG2000 [1] because our user-agent is
> similar to that of Safari (because? our WebKit ports *are* using the same Web
> engine as Safari?there is no point denying it!) and a few sites started over
> a year ago to send JPEG2000 images replies, then a few more, and then some.
> At some point Akamai's Image Manager [2] started serving JPEG2000 images
> transparently: the HTML references an URL ending in ?.png? (for example),
> and Akamai will return a JPEG2000 in the response (with an appropriate
> Content-Type HTTP header, of course). At this point, if we don't support
> JPEG2000, a good chunk of popular websites will just look broken because
> the images returned by popular CDNs or the websites themselves cannot be
> decoded.
> 
> This above is what I meant with ?many websites will silently fail to
> show images without [OpenJPEG support] enabled?.

So, from what you are saying, I understand that support for jpeg 2000
*is* de facto mandatory.

> I hope this helps understand why I am so insistent in having the OpenJPEG
> support enabled unconditionally: preventing that the Web is broken when
> browsing with a WebKit-based browser.

Yes, I understand that. Thanks for the explanations.

> The rationale why we have in the CMake build files in WebKit an ?USE_OPENJPEG?
> build-time option is to disable it when configuring for distributions which
> either a.) do not ship an OpenJPEG package, or b.) ship an old version that
> does not include some new API that WebKit needs (example: Ubuntu LTS).
> Buildroot does not fall into any of the categories above, and therefore I
> would argue that either we use ?select? to depend unconditionally on OpenJPEG,
> or ?imply? to choose it by default while still allowing to deselect it by
> hand.

I would not even give the option to disable it. Given the size of
openjpeg as compared to that of *webkit, there is not even the slightest
reason to make it configurable (IMHO).

> > Also, Thomas, please note that NetSurf does not support it eitther. ;-]
> Then again, NetSurf does not have an user-agent close enough to a WebKit
> one as to be served JPEG2000 images }:-)

That was a partially-private joke with Thomas, as he is keen on removing
netsurf after having lost countless hair trying to fix it. ;-)

> I hope that my little store above might help you change your mind, if
> only a little bit :-)

Yes, I changed my mind, from a conditional to mandatory dependency. ;-)
Sorry, still no imply for me! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-05-16 19:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 11:41 [Buildroot] [PATCH 0/5] Update WPE WebKit to 2.24.x Adrian Perez de Castro
2019-05-14 11:41 ` [Buildroot] [PATCH 1/5] package/libwpe: bump to version 1.2.0 Adrian Perez de Castro
2019-05-15  6:52   ` François Perrad
2019-05-20 19:32   ` Thomas Petazzoni
2019-05-14 11:41 ` [Buildroot] [PATCH 2/5] package/wpebackend-fdo: " Adrian Perez de Castro
2019-05-15  6:53   ` François Perrad
2019-05-15 18:07     ` Adrian Perez de Castro
2019-05-16 11:32       ` Adrian Perez de Castro
2019-05-20 19:33   ` Thomas Petazzoni
2019-05-14 11:41 ` [Buildroot] [PATCH 3/5] package/libepoxy: update to version 1.5.3, convert to Meson Adrian Perez de Castro
2019-05-20 19:33   ` Thomas Petazzoni
2019-05-14 11:41 ` [Buildroot] [PATCH 4/5] package/wpewebkit: bump to version 2.24.1 Adrian Perez de Castro
2019-05-15  6:55   ` François Perrad
2019-05-15 11:52     ` Adrian Perez de Castro
2019-05-15 14:05       ` Thomas Petazzoni
2019-05-15 18:11         ` Adrian Perez de Castro
2019-05-15 19:53           ` Yann E. MORIN
2019-05-15 21:15             ` Adrian Perez de Castro
2019-05-16 19:07               ` Yann E. MORIN [this message]
2019-05-17 15:36                 ` Adrian Perez de Castro
2019-05-14 11:41 ` [Buildroot] [PATCH 5/5] package/cog: bump version to 0.3.0 Adrian Perez de Castro
2019-05-14 20:33   ` Adrian Perez de Castro
2019-05-14 21:36     ` Arnout Vandecappelle
2019-05-15 18:50       ` Adrian Perez de Castro
2019-05-20 21:40 ` [Buildroot] [PATCH/next v2 0/3] Update WPE WebKit to 2.24.x Adrian Perez de Castro
2019-05-20 21:40   ` [Buildroot] [PATCH/next v2 1/3] package/wpebackend-fdo: bump to version 1.2.0 Adrian Perez de Castro
2019-05-21 18:11     ` François Perrad
2019-05-26 12:35     ` Thomas Petazzoni
2019-05-27 10:29       ` Adrian Perez de Castro
2019-05-20 21:40   ` [Buildroot] [PATCH/next v2 2/3] package/wpewebkit: bump to version 2.24.2 Adrian Perez de Castro
2019-05-21 18:12     ` François Perrad
2019-05-20 21:40   ` [Buildroot] [PATCH/next v2 3/3] package/cog: bump version to 0.3.0 Adrian Perez de Castro
2019-05-21 18:12     ` François Perrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516190703.GC2441@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.