From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id B794B1C162A for ; Thu, 16 May 2019 21:38:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0FBAC87346 for ; Thu, 16 May 2019 21:38:18 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D7RSM6bFZIOv for ; Thu, 16 May 2019 21:38:17 +0000 (UTC) Received: from kadath.azazel.net (kadath.azazel.net [81.187.231.250]) by whitealder.osuosl.org (Postfix) with ESMTPS id 754318733E for ; Thu, 16 May 2019 21:38:17 +0000 (UTC) From: Jeremy Sowden Subject: [PATCH v2 9/9] staging: kpc2000: declare all kp device attributes as static. Date: Thu, 16 May 2019 22:38:14 +0100 Message-Id: <20190516213814.22232-10-jeremy@azazel.net> In-Reply-To: <20190516213814.22232-1-jeremy@azazel.net> References: <20190516200411.17715-1-jeremy@azazel.net> <20190516213814.22232-1-jeremy@azazel.net> MIME-Version: 1.0 List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Linux Driver Project Developer List Cc: Greg KH The definitions are only used to populate the kp_attr_list attribute array, so declare them as static. Fixes the following sparse warnings: drivers/staging/kpc2000/kpc2000/core.c:152:1: warning: symbol 'dev_attr_ssid' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:153:1: warning: symbol 'dev_attr_ddna' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:154:1: warning: symbol 'dev_attr_card_id' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:155:1: warning: symbol 'dev_attr_hw_rev' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:156:1: warning: symbol 'dev_attr_build' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:157:1: warning: symbol 'dev_attr_build_date' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:158:1: warning: symbol 'dev_attr_build_time' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:159:1: warning: symbol 'dev_attr_cpld_reg' was not declared. Should it be static? drivers/staging/kpc2000/kpc2000/core.c:161:1: warning: symbol 'dev_attr_cpld_reconfigure' was not declared. Should it be static? Signed-off-by: Jeremy Sowden --- drivers/staging/kpc2000/kpc2000/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c index 6fa3dd6531ef..6a06153a20ec 100644 --- a/drivers/staging/kpc2000/kpc2000/core.c +++ b/drivers/staging/kpc2000/kpc2000/core.c @@ -111,15 +111,15 @@ static ssize_t cpld_reconfigure(struct device *dev, return count; } -DEVICE_ATTR_RO(ssid); -DEVICE_ATTR_RO(ddna); -DEVICE_ATTR_RO(card_id); -DEVICE_ATTR_RO(hw_rev); -DEVICE_ATTR_RO(build); -DEVICE_ATTR_RO(build_date); -DEVICE_ATTR_RO(build_time); -DEVICE_ATTR_RO(cpld_reg); -DEVICE_ATTR(cpld_reconfigure, 0220, NULL, cpld_reconfigure); +static DEVICE_ATTR_RO(ssid); +static DEVICE_ATTR_RO(ddna); +static DEVICE_ATTR_RO(card_id); +static DEVICE_ATTR_RO(hw_rev); +static DEVICE_ATTR_RO(build); +static DEVICE_ATTR_RO(build_date); +static DEVICE_ATTR_RO(build_time); +static DEVICE_ATTR_RO(cpld_reg); +static DEVICE_ATTR(cpld_reconfigure, 0220, NULL, cpld_reconfigure); static const struct attribute *kp_attr_list[] = { &dev_attr_ssid.attr, -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel