From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id EB4DE1C162A for ; Fri, 17 May 2019 07:15:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D72E984FC0 for ; Fri, 17 May 2019 07:15:35 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0GjLKR0X-Aqb for ; Fri, 17 May 2019 07:15:35 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 693AE84F6F for ; Fri, 17 May 2019 07:15:35 +0000 (UTC) Date: Fri, 17 May 2019 09:15:32 +0200 From: Greg KH Subject: Re: [PATCH v2 3/9] staging: kpc2000: declare all kpc_uio_class device attributes as static. Message-ID: <20190517071532.GD23217@kroah.com> References: <20190516200411.17715-1-jeremy@azazel.net> <20190516213814.22232-1-jeremy@azazel.net> <20190516213814.22232-4-jeremy@azazel.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190516213814.22232-4-jeremy@azazel.net> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Jeremy Sowden Cc: Linux Driver Project Developer List On Thu, May 16, 2019 at 10:38:08PM +0100, Jeremy Sowden wrote: > The definitions are only used to populate the kpc_uio_class_attrs > attribute array, so declare them as static. > > Fixes the following sparse warnings: > > drivers/staging/kpc2000/kpc2000/cell_probe.c:220:1: warning: symbol 'dev_attr_offset' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:221:1: warning: symbol 'dev_attr_size' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:222:1: warning: symbol 'dev_attr_type' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:223:1: warning: symbol 'dev_attr_s2c_dma' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:224:1: warning: symbol 'dev_attr_c2s_dma' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:225:1: warning: symbol 'dev_attr_irq_count' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:226:1: warning: symbol 'dev_attr_irq_base_num' was not declared. Should it be static? > drivers/staging/kpc2000/kpc2000/cell_probe.c:227:1: warning: symbol 'dev_attr_core_num' was not declared. Should it be static? Ah, you did it here, nevermind... _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel