From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 17 May 2019 08:42:00 +0200 Subject: [U-Boot] [PATCH v4 04/13] clk: Extend struct clk to provide information regarding clock rate In-Reply-To: <66b7e1e5-4ee9-fd2d-d66b-97e71bbb03b8@denx.de> References: <20190516221042.3583-1-lukma@denx.de> <20190516221042.3583-5-lukma@denx.de> <66b7e1e5-4ee9-fd2d-d66b-97e71bbb03b8@denx.de> Message-ID: <20190517084200.1f092845@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > On 5/17/19 12:10 AM, Lukasz Majewski wrote: > > This commit extends the struct clk to provide information regarding > > the clock rate. > > As a result the clock tree traversal is performed at most once, and > > further reads are using the cached value. > > > > Signed-off-by: Lukasz Majewski > > > > --- > > > > Changes in v4: > > - None > > > > Changes in v3: None > > > > include/clk.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/clk.h b/include/clk.h > > index a909b71f1a..1f2fd15bb5 100644 > > --- a/include/clk.h > > +++ b/include/clk.h > > @@ -40,6 +40,7 @@ struct udevice; > > * other clock APIs to identify which clock signal to operate upon. > > * > > * @dev: The device which implements the clock signal. > > + * @rate: The clock rate (in HZ). > > * @id: The clock signal ID within the provider. > > * @data: An optional data field for scenarios where a single > > integer ID is not > > * sufficient. If used, it can be populated through > > an .of_xlate op and @@ -55,6 +56,7 @@ struct udevice; > > */ > > struct clk { > > struct udevice *dev; > > + unsigned long rate; /* in HZ */ > > Can this be unsigned long long ? Think of 3 GHz PLL on arm32 in IDT > Versaclock line of clock synthesisers ; this would overflow right > here. > Thanks for spotting this - I will use unsigned long long instead. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: