All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <xzhou@redhat.com>
To: Luis Henriques <lhenriques@suse.com>
Cc: fstests@vger.kernel.org, Xiong Zhou <xzhou@redhat.com>
Subject: Re: [PATCH 2/2] overlay/023: use numeric user and group IDs in getfacl
Date: Sat, 18 May 2019 11:55:34 +0800	[thread overview]
Message-ID: <20190518035534.7dtcygww65hneuby@XZHOUW.usersys.redhat.com> (raw)
In-Reply-To: <20190517112422.20671-3-lhenriques@suse.com>

On Fri, May 17, 2019 at 12:24:22PM +0100, Luis Henriques wrote:
> This prevents test failures if cases where, e.g., /etc/group doesn't
> include the 'root' group ID.

Ack for this patch(I don't see that other 1/2 one). Thanks!

Xiong

> 
> Cc: Xiong Zhou <xzhou@redhat.com>
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> ---
>  tests/overlay/023     | 2 +-
>  tests/overlay/023.out | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/overlay/023 b/tests/overlay/023
> index 7e48349d1a12..edd034c3a9e3 100755
> --- a/tests/overlay/023
> +++ b/tests/overlay/023
> @@ -55,7 +55,7 @@ setfacl -d -m o::rwx $wkdir
>  _scratch_mount
>  
>  # getting acls, ACL set on workdir should be cleaned
> -getfacl -p $wkdir/work 2>&1 | _filter_scratch | _filter_ovl_dirs
> +getfacl -n -p $wkdir/work 2>&1 | _filter_scratch | _filter_ovl_dirs
>  
>  # success, all done
>  status=0
> diff --git a/tests/overlay/023.out b/tests/overlay/023.out
> index 4a243c5b44ce..911d272d2241 100644
> --- a/tests/overlay/023.out
> +++ b/tests/overlay/023.out
> @@ -1,7 +1,7 @@
>  QA output created by 023
>  # file: SCRATCH_DEV/OVL_WORK/work
> -# owner: root
> -# group: root
> +# owner: 0
> +# group: 0
>  user::---
>  group::---
>  other::---

      reply	other threads:[~2019-05-18  3:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 11:24 [PATCH 0/2] Use numeric user and group IDs in getfacl Luis Henriques
2019-05-17 11:24 ` [PATCH 1/2] generic/319: use " Luis Henriques
2019-05-17 15:15   ` Filipe Manana
2019-05-17 11:24 ` [PATCH 2/2] overlay/023: " Luis Henriques
2019-05-18  3:55   ` Murphy Zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190518035534.7dtcygww65hneuby@XZHOUW.usersys.redhat.com \
    --to=xzhou@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=lhenriques@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.