From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Adam Michaelis <adam.michaelis@rockwellcollins.com>,
linux-iio@vger.kernel.org, lars@metafoo.de,
michael.hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com,
charles-antoine.couret@essensium.com, devicetree@vger.kernel.org,
brandon.maier@rockwellcollins.com,
clayton.shotwell@rockwellcollins.com
Subject: Re: [PATCH v3 3/5] dt-bindings: iio: ad7949: Add adi,reference-select
Date: Sat, 18 May 2019 10:07:53 +0100 [thread overview]
Message-ID: <20190518100753.39b438cb@archlinux> (raw)
In-Reply-To: <20190514182311.GA31516@bogus>
On Tue, 14 May 2019 13:23:11 -0500
Rob Herring <robh@kernel.org> wrote:
> On Mon, 13 May 2019 09:53:03 -0500, Adam Michaelis wrote:
> > Adding optional parameter to AD7949 to specify the source for the
> > reference voltage signal. Default value is maintained with option '3' to
> > match previous version of driver.
> >
> > Signed-off-by: Adam Michaelis <adam.michaelis@rockwellcollins.com>
> > ---
> > V2:
> > - Add some defines to reduce use of magic numbers.
> > V3:
> > - Re-think usage of device tree parameter to focus on the
> > actual reference sources instead of the raw hardware
> > configuration.
> > ---
> > .../devicetree/bindings/iio/adc/ad7949.txt | 21 +++++++++++++++++++--
> > 1 file changed, 19 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Looks fine to me as well. Analog review awaited before applying.
For reference
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2019-05-18 9:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 14:53 [PATCH v3 1/5] iio: ad7949: Fix dummy read cycle placement Adam Michaelis
2019-05-13 14:53 ` [PATCH v3 2/5] iio: ad7949: Support internal Vref Adam Michaelis
2019-05-18 9:07 ` Jonathan Cameron
2019-05-23 12:12 ` Alexandru Ardelean
2019-05-23 12:51 ` Ardelean, Alexandru
2019-05-23 12:51 ` Ardelean, Alexandru
2019-05-13 14:53 ` [PATCH v3 3/5] dt-bindings: iio: ad7949: Add adi,reference-select Adam Michaelis
2019-05-14 18:23 ` Rob Herring
2019-05-14 18:23 ` Rob Herring
2019-05-18 9:07 ` Jonathan Cameron [this message]
2019-05-23 12:16 ` Alexandru Ardelean
2019-05-13 14:53 ` [PATCH v3 4/5] iio: ad7949: Fix SPI interfacing for 14-bit messages Adam Michaelis
2019-05-18 9:10 ` Jonathan Cameron
2019-05-23 12:39 ` Alexandru Ardelean
2019-05-13 14:53 ` [PATCH v3 5/5] iio: ad7949: Remove logic for config readback Adam Michaelis
2019-05-18 9:19 ` Jonathan Cameron
2019-05-18 9:36 ` [PATCH v3 1/5] iio: ad7949: Fix dummy read cycle placement Jonathan Cameron
2019-05-23 11:47 ` Alexandru Ardelean
2019-05-24 11:49 ` Couret Charles-Antoine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518100753.39b438cb@archlinux \
--to=jic23@kernel.org \
--cc=adam.michaelis@rockwellcollins.com \
--cc=brandon.maier@rockwellcollins.com \
--cc=charles-antoine.couret@essensium.com \
--cc=clayton.shotwell@rockwellcollins.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.hennerich@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.